Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Add separate, sr-only text for spacers/gaps

Alexander Brandon Coles0d010950ef9f
diff --git a/config/locales/js-en.yml b/config/locales/js-en.yml
index 27cf07e621c..f87d64a8382 100644
--- a/config/locales/js-en.yml
+++ b/config/locales/js-en.yml
@@ -697,6 +697,7 @@ en:
pagination:
no_other_page: "You are on the only page."
+ pages_skipped: "Pages skipped."
page_navigation: "Pagination navigation"
per_page_navigation: 'Items per page selection'
pages:
diff --git a/frontend/src/app/shared/components/table-pagination/table-pagination.component.html b/frontend/src/app/shared/components/table-pagination/table-pagination.component.html
index d2e715204b2..bb722490eb6 100644
--- a/frontend/src/app/shared/components/table-pagination/table-pagination.component.html
+++ b/frontend/src/app/shared/components/table-pagination/table-pagination.component.html
@@ -24,7 +24,10 @@
[textContent]="pageNumber"
></button>
</li>
- <li class="op-pagination--space">…</li>
+ <li class="op-pagination--space">
+ <span class="sr-only" [textContent]="text.pages_skipped"></span>
+ <span aria-hidden="true">…</span>
+ </li>
</ng-container>
<ng-container *ngIf="pageNumbers.length > 1">
@@ -48,7 +51,10 @@
[textContent]="pageNumber"
></button>
</li>
- <li *ngIf="postPageNumbers.length" class="op-pagination--space" role="separator">…</li>
+ <li class="op-pagination--space">
+ <span class="sr-only" [textContent]="text.pages_skipped"></span>
+ <span aria-hidden="true">…</span>
+ </li>
</ng-container>
<ng-container *ngIf="postPageNumbers.length">
diff --git a/frontend/src/app/shared/components/table-pagination/table-pagination.component.ts b/frontend/src/app/shared/components/table-pagination/table-pagination.component.ts
index 6c26f0a0d49..0e2dcd19781 100644
--- a/frontend/src/app/shared/components/table-pagination/table-pagination.component.ts
+++ b/frontend/src/app/shared/components/table-pagination/table-pagination.component.ts
@@ -65,6 +65,7 @@ export class TablePaginationComponent extends UntilDestroyedMixin implements OnI
label_next: this.I18n.t('js.label_next'),
per_page: this.I18n.t('js.label_per_page'),
no_other_page: this.I18n.t('js.pagination.no_other_page'),
+ pages_skipped: this.I18n.t('js.pagination.pages_skipped'),
page_navigation: this.I18n.t('js.pagination.page_navigation'),
per_page_navigation: this.I18n.t('js.pagination.per_page_navigation'),
page_number: (num:number) => this.I18n.t('js.pagination.pages.page_number', { number: num }),
diff --git a/lib/open_project/link_renderer.rb b/lib/open_project/link_renderer.rb
index 17c653c21f4..1652717536f 100644
--- a/lib/open_project/link_renderer.rb
+++ b/lib/open_project/link_renderer.rb
@@ -53,7 +53,10 @@ module OpenProject
end
def gap
- tag(:li, "&#x2026;", class: "op-pagination--space", role: "separator")
+ tag(:li,
+ tag(:span, "&#x2026;", "aria-hidden": "true") +
+ tag(:span, I18n.t(:"js.pagination.pages_skipped"), class: "sr-only"),
+ class: "op-pagination--space")
end
def previous_page