Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

better naming & parameter

as-op0fe4d90c7c85
diff --git a/app/models/work_package/exports/attributes.rb b/app/models/work_package/exports/attributes.rb
index 8f81fc1fb5d..dd1791f5b01 100644
--- a/app/models/work_package/exports/attributes.rb
+++ b/app/models/work_package/exports/attributes.rb
@@ -30,14 +30,13 @@
module WorkPackage::Exports
module Attributes
- def allowed_to_view_wp_project_phase?(work_package)
- User.current.allowed_in_project?(:view_project_phases, work_package.project) &&
- work_package.project.phases.active.any?
+ def allowed_to_view_project_phases?(project)
+ User.current.allowed_in_project?(:view_project_phases, project) && project.phases.active.any?
end
def allowed_to_view_attribute?(obj, attribute_name)
if attribute_name.to_sym == :project_phase && obj.is_a?(WorkPackage)
- allowed_to_view_wp_project_phase?(obj)
+ allowed_to_view_project_phases?(obj.project)
else
true
end