OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Adapt banner component not overriding static_links
Oliver Günther141deb5eea9f
diff --git a/spec/components/enterprise_edition/banner_component_spec.rb b/spec/components/enterprise_edition/banner_component_spec.rbindex 59b0eb34c75..3c66f44d5d3 100644--- a/spec/components/enterprise_edition/banner_component_spec.rb+++ b/spec/components/enterprise_edition/banner_component_spec.rb@@ -49,15 +49,9 @@ RSpec.describe EnterpriseEdition::BannerComponent, type: :component do}.compact}end- let(:static_links) do- {- enterprise_features: {- some_enterprise_feature: {- href:- }- }- }- end++ let(:enterprise_feature_link) { href }+let(:translations) do{ee: {@@ -82,8 +76,13 @@ RSpec.describe EnterpriseEdition::BannerComponent, type: :component dobefore doallow(OpenProject::Static::Links)- .to receive(:links)- .and_return(static_links)+ .to receive(:url_for)+ .and_call_original++ allow(OpenProject::Static::Links)+ .to receive(:url_for)+ .with(:enterprise_features, :some_enterprise_feature)+ .and_return(enterprise_feature_link)allow(OpenProject::Token).to receive(:lowest_plan_for)@@ -248,16 +247,7 @@ RSpec.describe EnterpriseEdition::BannerComponent, type: :component doendcontext "without a link key in the static_link file" do- let(:static_links) do- {- enterprise_features: {- default: {- href: "https://example.com"- },- some_enterprise_feature: {}- }- }- end+ let(:enterprise_feature_link) { nil }it "uses the default" dorender_component_in_mo@@ -266,7 +256,8 @@ RSpec.describe EnterpriseEdition::BannerComponent, type: :component doexpect(component).to have_text(expected_title)expect(component).to have_text(expected_description)- expect(component).to have_link("More information", href: "https://example.com")++ expect(component).to have_link("More information", href: "https://www.openproject.org/enterprise-edition")endend