Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Merge pull request #20308 from opf/filter-project-updated-at

Jan Sandbrink2047cc348090
diff --cc app/components/projects/projects_filters_component.rb
index b992cebd33b,2d563bfc164..1f24f0baac6
--- a/app/components/projects/projects_filters_component.rb
+++ b/app/components/projects/projects_filters_component.rb
@@@ -59,15 -59,10 +59,16 @@@ class Projects::ProjectsFiltersComponen
Queries::Projects::Filters::ProjectStatusFilter,
Queries::Projects::Filters::PublicFilter,
Queries::Projects::Filters::TemplatedFilter,
- Queries::Projects::Filters::TypeFilter
+ Queries::Projects::Filters::TypeFilter,
+ Queries::Projects::Filters::UpdatedAtFilter
]
- allowlist.any? { |clazz| filter.is_a? clazz }
+ # FavoritedFilter used to be called favored. The filter should not break for stored queries. Therefore,
+ # the filter is instantiated twice, once for "favorited", once for "favored".
+ # At the same time, the "Favorite" filter should not be displayed twice in the filter list.
+ # Removing it here has the drawback of a stored "favored" filter not showing up in the component.
+ # This is accepted.
+
+ allowlist.any? { |clazz| filter.is_a? clazz } && filter.name != :favored
end
end