OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Hide My time tracking menu if without log_own_time or log_time permission
Oliver Günther2220f4d6ca10
diff --git a/modules/costs/lib/costs/engine.rb b/modules/costs/lib/costs/engine.rbindex 2771bed1cd1..52ae26593e4 100644--- a/modules/costs/lib/costs/engine.rb+++ b/modules/costs/lib/costs/engine.rb@@ -147,6 +147,9 @@ module Costs{ controller: "/my/time_tracking", action: "index" },after: :my_page,caption: :label_my_time_tracking,+ if: ->(*) do+ User.current.allowed_in_any_project?(:log_own_time) || User.current.allowed_in_any_project?(:log_time)+ end,icon: :stopwatchenddiff --git a/modules/costs/spec/requests/my_time_menu_spec.rb b/modules/costs/spec/requests/my_time_menu_spec.rbnew file mode 100644index 00000000000..c622a0ded23--- /dev/null+++ b/modules/costs/spec/requests/my_time_menu_spec.rb@@ -0,0 +1,71 @@+# frozen_string_literal: true++#-- copyright+# OpenProject is an open source project management software.+# Copyright (C) the OpenProject GmbH+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License version 3.+#+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:+# Copyright (C) 2006-2013 Jean-Philippe Lang+# Copyright (C) 2010-2013 the ChiliProject Team+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License+# as published by the Free Software Foundation; either version 2+# of the License, or (at your option) any later version.+#+# This program is distributed in the hope that it will be useful,+# but WITHOUT ANY WARRANTY; without even the implied warranty of+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+# GNU General Public License for more details.+#+# You should have received a copy of the GNU General Public License+# along with this program; if not, write to the Free Software+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.+#+# See COPYRIGHT and LICENSE files for more details.+#++++require "spec_helper"++RSpec.describe "My time menu",+ :skip_csrf,+ type: :rails_request do+ shared_let(:project) { create(:project, enabled_module_names: %i[work_package_tracking costs]) }++ let(:request) { get "/" }++ subject do+ request+ response+ end++ context "when user has no permission in any project" do+ current_user { build_stubbed(:user) }++ it "shows a pagination" do+ expect(subject).to have_http_status(:ok)+ expect(page).to have_no_text "My time tracking"+ end+ end++ context "when user has permission to log_own_time" do+ current_user { create(:user, member_with_permissions: { project => %i[log_own_time] }) }++ it "shows a pagination" do+ expect(subject).to have_http_status(:ok)+ expect(page).to have_text "My time tracking"+ end+ end++ context "when user has permission to log_time" do+ current_user { create(:user, member_with_permissions: { project => %i[log_time] }) }++ it "shows a pagination" do+ expect(subject).to have_http_status(:ok)+ expect(page).to have_text "My time tracking"+ end+ end+end