OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
[#66439] improved readability of file info query
Eric Schubert26f6c3e61cc2
diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rb b/modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rbindex 54439420e80..29c27a7e493 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rb@@ -37,20 +37,18 @@ module StoragesFIELDS = %w[id name fileSystemInfo file folder size createdBy lastModifiedBy parentReference webUrl].freezedef call(auth_strategy:, input_data:)- identifier_hash = split_identifier(input_data.file_id)- drive_id = identifier_hash[:drive_id]- item_id = identifier_hash[:location]+ split_identifier(input_data.file_id) => { drive_id:, location: item_id }- make_base_query(auth_strategy:, drive_id:, item_id:).or do |error|+ fetch_file_info(auth_strategy:, drive_id:, item_id:).or do |error|return Failure(error) unless error.code == :not_found && auth_strategy.value!.user.present?- admin_query(drive_id, item_id)+ fetch_file_info_without_user(drive_id, item_id)endendprivate- def make_base_query(auth_strategy:, drive_id:, item_id:)+ def fetch_file_info(auth_strategy:, drive_id:, item_id:)Authentication[auth_strategy].call(storage: @storage) do |http|drive_item_query.call(http:, drive_id:, item_id:, fields: FIELDS).fmap { |json| storage_file_info(json) }@@ -61,7 +59,7 @@ module Storages@drive_item_query ||= Internal::DriveItemQuery.new(@storage)end- def admin_query(drive_id, item_id)+ def fetch_file_info_without_user(drive_id, item_id)Authentication[userless_strategy].call(storage: @storage) do |http|drive_item_query.call(http:, drive_id:, item_id:, fields: FIELDS).fmap { |json| storage_file_info(json, status: "forbidden", status_code: 403) }