OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
add tests with restricted project/work_package referenced by ID
as-op2c6ff99dd810
diff --git a/spec/models/work_package/pdf_export/common/macro_spec.rb b/spec/models/work_package/pdf_export/common/macro_spec.rbindex e32a5387cb8..45b3a7c1936 100644--- a/spec/models/work_package/pdf_export/common/macro_spec.rb+++ b/spec/models/work_package/pdf_export/common/macro_spec.rb@@ -95,6 +95,26 @@ RSpec.describe WorkPackage::PDFExport::Common::Macro do})end+ shared_let(:restricted_other_project) do+ create(+ :project,+ name: "Other Project",+ work_package_custom_fields: [custom_field, formatted_custom_field],+ project_custom_fields: [project_custom_field],+ custom_field_values: { project_custom_field.id => "Project custom value 3" }+ )+ end+ shared_let(:restricted_work_package) do+ create(+ :work_package,+ subject: "Work package 3",+ project: restricted_other_project,+ type: type_task,+ custom_field_values: {+ custom_field.id => "Custom value 3"+ }+ )+ endshared_let(:formatter) { Class.new { extend WorkPackage::PDFExport::Common::Macro } }let(:additional_permissions) { [] }let(:user) do@@ -208,6 +228,30 @@ RSpec.describe WorkPackage::PDFExport::Common::Macro doendend+ describe "with restricted work package ID and attribute" do+ let(:markdown) { "workPackageValue:#{restricted_work_package.id}:subject" }++ it "outputs an error message" do+ expect(formatted).to include("Macro error, resource not found")+ end+ end++ describe "with restricted work package ID and custom field" do+ let(:markdown) { "workPackageValue:#{restricted_work_package.id}:\"Custom Field 1\"" }++ it "outputs an error message" do+ expect(formatted).to include("Macro error, resource not found")+ end+ end++ describe "with restricted work package ID and formatted custom field" do+ let(:markdown) { "workPackageValue:#{restricted_work_package.id}:\"Custom Formatted Field\"" }++ it "outputs an error message" do+ expect(formatted).to include("Macro error, resource not found")+ end+ end+describe "with non-existent work package ID" dolet(:markdown) { "workPackageValue:999:subject" }@@ -466,6 +510,30 @@ RSpec.describe WorkPackage::PDFExport::Common::Macro doendend+ describe "with restricted project ID" do+ let(:markdown) { "projectValue:#{restricted_other_project.id}:name" }++ it "outputs an error message" do+ expect(formatted).to include("Macro error, resource not found")+ end+ end++ describe "with restricted project identifier" do+ let(:markdown) { "projectValue:\"#{restricted_other_project.identifier}\":name" }++ it "outputs an error message" do+ expect(formatted).to include("Macro error, resource not found")+ end+ end++ describe "with restricted project ID and custom field" do+ let(:markdown) { "projectValue:#{restricted_other_project.id}:\"Project Custom Field 1\"" }++ it "outputs an error message" do+ expect(formatted).to include("Macro error, resource not found")+ end+ end+describe "with status attribute" dolet(:markdown) { "projectValue:status_code" }