Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

separate hash by name and list of registered formats in CustomFieldFormat

Ivan Kuchin2da4502ac139
diff --git a/lib/open_project/custom_field_format.rb b/lib/open_project/custom_field_format.rb
index b8edca8294f..c4c2cafbc67 100644
--- a/lib/open_project/custom_field_format.rb
+++ b/lib/open_project/custom_field_format.rb
@@ -32,7 +32,7 @@ module OpenProject
class CustomFieldFormat
include Redmine::I18n
- class_attribute :registered, default: {}
+ class_attribute :registered_by_name, default: {}
attr_reader :name, :order, :label, :edit_as, :class_names
@@ -82,39 +82,40 @@ module OpenProject
end
class << self
+ def registered = registered_by_name.values
+
def map(&)
yield self
end
# Registers a custom field format
def register(custom_field_format, _options = {})
- registered[custom_field_format.name] = custom_field_format unless registered.include?(custom_field_format.name)
+ return if registered_by_name.has_key?(custom_field_format.name)
+
+ registered_by_name[custom_field_format.name] = custom_field_format
end
def available
- registered.select do |_, format|
- format.available?
- end
+ registered.select(&:available?)
end
def available_formats
- available.keys
+ available.map(&:name)
end
def find_by(name:)
- registered[name.to_s]
+ registered_by_name[name.to_s]
end
def available_for_class_name(class_name)
available
- .values
.select { |field| field.class_names.nil? || field.class_names.include?(class_name) }
.sort_by(&:order)
.reject { |format| format.label.nil? }
end
def disabled_formats
- registered.select { |_, format| format.disabled? }.keys
+ registered.select(&:disabled?).map(&:name)
end
end
end