Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

don't set send_notifications for projects copy dependencies

Ivan Kuchin2ffbf961096f
diff --git a/app/services/projects/copy/members_dependent_service.rb b/app/services/projects/copy/members_dependent_service.rb
index a5c7bed4251..26f7e016fac 100644
--- a/app/services/projects/copy/members_dependent_service.rb
+++ b/app/services/projects/copy/members_dependent_service.rb
@@ -61,11 +61,7 @@ module Projects::Copy
attributes = member
.attributes.dup.except("id", "project_id", "created_at", "updated_at")
- .merge(role_ids:,
- project: target,
- # This is magic for now. The settings has been set before in the Projects::CopyService
- # It would be better if this was not sneaked in but rather passed in as a parameter.
- send_notifications: ActionMailer::Base.perform_deliveries)
+ .merge(role_ids:, project: target)
Members::CreateService
.new(user: User.current, contract_class: EmptyContract)
diff --git a/app/services/projects/copy/wiki_dependent_service.rb b/app/services/projects/copy/wiki_dependent_service.rb
index a152516a17d..c55d90ffa94 100644
--- a/app/services/projects/copy/wiki_dependent_service.rb
+++ b/app/services/projects/copy/wiki_dependent_service.rb
@@ -71,14 +71,9 @@ module Projects::Copy
end
def copy_wiki_page(source_page, new_parent_id)
- # Relying on ActionMailer::Base.perform_deliveries is violating cohesion
- # but the value is currently not otherwise provided
service_call = WikiPages::CopyService
.new(user:, model: source_page, contract_class: WikiPages::CopyContract)
- .call(wiki: target.wiki,
- parent_id: new_parent_id,
- send_notifications: ActionMailer::Base.perform_deliveries,
- copy_attachments: copy_attachments?)
+ .call(wiki: target.wiki, parent_id: new_parent_id, copy_attachments: copy_attachments?)
if service_call.success?
service_call.result
diff --git a/app/services/projects/copy/work_packages_dependent_service.rb b/app/services/projects/copy/work_packages_dependent_service.rb
index b3462215eaf..a660a769d6f 100644
--- a/app/services/projects/copy/work_packages_dependent_service.rb
+++ b/app/services/projects/copy/work_packages_dependent_service.rb
@@ -138,10 +138,7 @@ module Projects::Copy
responsible_id: work_package_responsible_id(source_work_package),
custom_field_values: custom_value_attributes(source_work_package, user_cf_ids),
# We don't support copying budgets right now
- budget_id: nil,
-
- # We persist the setting in the job which will trigger a delayed job for potentially sending the journal notifications.
- send_notifications: params.dig(:params, :send_notifications)
+ budget_id: nil
}
end