Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Remove seeming redundant check_box checked|value definitions.

Kabiru Mwenja30e3cb4508c6
diff --git a/app/forms/my/look_and_feel_form.rb b/app/forms/my/look_and_feel_form.rb
index 2ba5c6b3510..f28a2312326 100644
--- a/app/forms/my/look_and_feel_form.rb
+++ b/app/forms/my/look_and_feel_form.rb
@@ -50,18 +50,15 @@ class My::LookAndFeelForm < ApplicationForm
f.check_box_group(data: { my__look_and_feel_target: "autoThemeContrast" }) do |group|
group.check_box name: :force_light_theme_contrast,
label: attribute_name(:force_light_theme_contrast),
- checked: user_preference.force_light_theme_contrast?,
caption: attribute_name(:force_light_theme_contrast_caption)
group.check_box name: :force_dark_theme_contrast,
label: attribute_name(:force_dark_theme_contrast),
- checked: user_preference.force_dark_theme_contrast?,
caption: attribute_name(:force_dark_theme_contrast_caption)
end
f.check_box_group(data: { my__look_and_feel_target: "singleThemeContrast" }) do |group|
group.check_box name: :increase_theme_contrast,
label: attribute_name(:increase_contrast),
- checked: user_preference.increase_theme_contrast?,
caption: attribute_name(:increase_contrast_caption)
end
@@ -86,10 +83,6 @@ class My::LookAndFeelForm < ApplicationForm
private
- def user_preference
- User.current.pref
- end
-
def disable_keyboard_shortcuts_caption
attribute_name(:disable_keyboard_shortcuts_caption_html,
href: OpenProject::Static::Links.url_for(:shortcuts)).html_safe # rubocop:disable Rails/OutputSafety