OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
[#66093] Refactor project list rendering
Tobias Dillmann3575aa12b20a
diff --git a/app/components/projects/row_component.rb b/app/components/projects/row_component.rbindex 29a0f20a607..da8604afef1 100644--- a/app/components/projects/row_component.rb+++ b/app/components/projects/row_component.rb@@ -78,7 +78,7 @@ module Projectsendend- def custom_field_column(column)+ def custom_field_column(column) # rubocop:disable Metrics/AbcSizereturn nil unless user_can_view_project?cf = column.custom_field@@ -94,19 +94,25 @@ module Projectselsif custom_value.is_a?(Array)safe_join(Array(custom_value).compact_blank, ", ")elsif cf.calculated_value?- errors = cf.calculated_value_errors.where(project:)-- if errors.any?- render(Primer::Alpha::Dialog.new(title: I18n.t("calculated_values.error_dialog.title"),- data: { test_selector: "calculated-value-error-dialog-#{cf.id}" })) do |dialog|- dialog.with_show_button(icon: "alert-fill",- "aria-label": I18n.t("calculated_values.error_dialog.title"),- data: { test_selector: "calculated-value-error-btn-#{cf.id}" },- scheme: :invisible)- dialog.with_body { errors.map(&:error_message).join(" ") }- end- else- custom_value+ calculated_value_or_error(cf, custom_value)+ else+ custom_value+ end+ end++ def calculated_value_or_error(calculated_value, custom_value)+ errors = calculated_value.calculated_value_errors.where(project:)++ if errors.any?+ render(Primer::Alpha::Dialog.new(title: I18n.t("calculated_values.error_dialog.title"),+ data: {+ test_selector: "calculated-value-error-dialog-#{calculated_value.id}"+ })) do |dialog|+ dialog.with_show_button(icon: "alert-fill",+ "aria-label": I18n.t("calculated_values.error_dialog.title"),+ data: { test_selector: "calculated-value-error-btn-#{calculated_value.id}" },+ scheme: :invisible)+ dialog.with_body { errors.map(&:error_message).join(" ") }endelsecustom_value