Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#65886] Fix Settings multi-lang input

Alexander Brandon Coles3cd266b7841e
diff --git a/frontend/src/app/core/setup/globals/global-listeners/settings.ts b/frontend/src/app/core/setup/globals/global-listeners/settings.ts
index 4dac33b2ce0..ca224ba4362 100644
--- a/frontend/src/app/core/setup/globals/global-listeners/settings.ts
+++ b/frontend/src/app/core/setup/globals/global-listeners/settings.ts
@@ -1,3 +1,5 @@
+import { ICKEditorInstance } from 'core-app/shared/components/editor/components/ckeditor/ckeditor.types';
+
/**
* Move from legacy app/assets/javascripts/application.js.erb
*
@@ -32,10 +34,10 @@ export function listenToSettingChanges() {
const id:string = self.attr('id') || '';
const settingName = id.replace('lang-for-', '');
const newLang = self.val() as string;
- const textAreaId = `#settings-${settingName}`;
- const textArea = jQuery(textAreaId);
- /* eslint-disable-next-line @typescript-eslint/no-unsafe-assignment */
- const editor = jQuery(`opce-ckeditor-augmented-textarea[data-textarea-selector='"${textAreaId}"'`).data('editor');
+ const textAreaId = `settings-${settingName}`;
+ const textArea = jQuery(`#${textAreaId}`);
+ const augmentedTextarea = jQuery(`opce-ckeditor-augmented-textarea[data-text-area-id='"${textAreaId}"']`);
+ const editor = augmentedTextarea.data('editor') as ICKEditorInstance;
return {
id, settingName, newLang, textArea, editor,
@@ -57,7 +59,7 @@ export function listenToSettingChanges() {
.change(function () {
const data = langSelectSwitchData(this);
- const storedValue = jQuery(`#${data.id}-${data.newLang}`).val();
+ const storedValue = jQuery(`#${data.id}-${data.newLang}`).val()!.toString();
data.editor.setData(storedValue);
data.textArea.attr('name', `settings[${data.settingName}][${data.newLang}]`);
diff --git a/frontend/src/app/shared/components/editor/components/ckeditor/ckeditor.types.ts b/frontend/src/app/shared/components/editor/components/ckeditor/ckeditor.types.ts
index bcaae992dec..5366f8ec447 100644
--- a/frontend/src/app/shared/components/editor/components/ckeditor/ckeditor.types.ts
+++ b/frontend/src/app/shared/components/editor/components/ckeditor/ckeditor.types.ts
@@ -25,7 +25,7 @@ export interface ICKEditorInstance {
state:string;
- getData(options:{ trim:boolean }):string;
+ getData(options?:{ trim:boolean }):string;
setData(content:string):void;