Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Remove unused stimulus index outlet definitions

Kabiru Mwenja4022fcf6cd3d
diff --git a/app/components/work_packages/activities_tab/index_component.rb b/app/components/work_packages/activities_tab/index_component.rb
index b674ea39780..04dcce4b307 100644
--- a/app/components/work_packages/activities_tab/index_component.rb
+++ b/app/components/work_packages/activities_tab/index_component.rb
@@ -78,14 +78,10 @@ module WorkPackages
index_stimulus_controller("-unsaved-changes-confirmation-message-value") => unsaved_changes_confirmation_message
}
stimulus_controller_outlets = {
- auto_scrolling_stimulus_controller("-#{index_stimulus_controller}-outlet") => index_component_dom_selector,
- editor_stimulus_controller("-#{index_stimulus_controller}-outlet") => index_component_dom_selector,
editor_stimulus_controller("-#{auto_scrolling_stimulus_controller}-outlet") => index_component_dom_selector,
editor_stimulus_controller("-#{stems_stimulus_controller}-outlet") => index_component_dom_selector,
- polling_stimulus_controller("-#{index_stimulus_controller}-outlet") => index_component_dom_selector,
polling_stimulus_controller("-#{auto_scrolling_stimulus_controller}-outlet") => index_component_dom_selector,
- polling_stimulus_controller("-#{stems_stimulus_controller}-outlet") => index_component_dom_selector,
- stems_stimulus_controller("-#{index_stimulus_controller}-outlet") => index_component_dom_selector
+ polling_stimulus_controller("-#{stems_stimulus_controller}-outlet") => index_component_dom_selector
}
{ test_selector: "op-wp-activity-tab" }
@@ -102,7 +98,6 @@ module WorkPackages
action: editor_stimulus_controller(":onSubmit-end@window->#{internal_comment_stimulus_controller}#onSubmitEnd"),
internal_comment_stimulus_controller("-highlight-class") => "work-packages-activities-tab-journals-new-component--journal-notes-body__internal-comment", # rubocop:disable Layout/LineLength
internal_comment_stimulus_controller("-hidden-class") => "d-none",
- internal_comment_stimulus_controller("-#{index_stimulus_controller}-outlet") => index_component_dom_selector,
internal_comment_stimulus_controller("-is-internal-value") => false, # Initial value
internal_comment_stimulus_controller("-#{editor_stimulus_controller}-outlet") => index_component_dom_selector
}
diff --git a/app/components/work_packages/activities_tab/journals/item_component.rb b/app/components/work_packages/activities_tab/journals/item_component.rb
index a90ef2b5cbc..7e87215d153 100644
--- a/app/components/work_packages/activities_tab/journals/item_component.rb
+++ b/app/components/work_packages/activities_tab/journals/item_component.rb
@@ -164,7 +164,6 @@ module WorkPackages
quote_comments_stimulus_controller("-user-name-param") => journal.user.name,
quote_comments_stimulus_controller("-is-internal-param") => journal.internal?,
quote_comments_stimulus_controller("-text-wrote-param") => I18n.t(:text_wrote),
- quote_comments_stimulus_controller("-#{index_stimulus_controller}-outlet") => index_component_dom_selector,
quote_comments_stimulus_controller("-#{internal_comment_stimulus_controller}-outlet") => add_comment_component_dom_selector, # rubocop:disable Layout/LineLength
quote_comments_stimulus_controller("-#{editor_stimulus_controller}-outlet") => index_component_dom_selector
}
diff --git a/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/editor.controller.ts b/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/editor.controller.ts
index 0af8f354821..08d18018860 100644
--- a/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/editor.controller.ts
+++ b/frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/editor.controller.ts
@@ -187,7 +187,7 @@ export default class EditorController extends BaseController {
};
const editorElement = this.ckEditorAugmentedTextarea;
- if (editorElement && editorElement.addEventListener) {
+ if (editorElement) {
editorElement.addEventListener('editorEscape', handlers.onEscapeEditor, { signal });
editorElement.addEventListener('editorKeyup', handlers.adjustMargin, { signal });
editorElement.addEventListener('editorBlur', handlers.onBlurEditor, { signal });