OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
check for permission
as-op449498af65ff
diff --git a/modules/budgets/app/models/projects/exports/formatters/budget_currency_attribute.rb b/modules/budgets/app/models/projects/exports/formatters/budget_currency_attribute.rbindex 72035f0d9de..068423fd672 100644--- a/modules/budgets/app/models/projects/exports/formatters/budget_currency_attribute.rb+++ b/modules/budgets/app/models/projects/exports/formatters/budget_currency_attribute.rb@@ -30,7 +30,6 @@module Projects::Exports::Formattersclass BudgetCurrencyAttribute < ::Exports::Formatters::Default-def self.apply?(attribute, _export_format)budget_mapping.key? attribute.to_symend@@ -44,7 +43,7 @@ module Projects::Exports::Formattersenddef format(project, **)- return unless project.module_enabled?("budgets")+ return unless project.module_enabled?("budgets") && User.current.allowed_in_project?(:view_budgets, project)project_budgets = ::Budgets::Patches::Projects::RowComponentPatch::ProjectBudgets.new(project)budgets_attribute = BudgetCurrencyAttribute.budget_mapping.fetch(attribute.to_sym)@@ -58,4 +57,3 @@ module Projects::Exports::Formattersendendend-diff --git a/modules/budgets/app/models/projects/exports/formatters/budget_spent_ratio.rb b/modules/budgets/app/models/projects/exports/formatters/budget_spent_ratio.rbindex 1d837743f31..588af803857 100644--- a/modules/budgets/app/models/projects/exports/formatters/budget_spent_ratio.rb+++ b/modules/budgets/app/models/projects/exports/formatters/budget_spent_ratio.rb@@ -30,16 +30,15 @@module Projects::Exports::Formattersclass BudgetSpentRatio < ::Exports::Formatters::Default- def self.apply?(attribute, export_format)+ def self.apply?(attribute, _export_format)attribute.to_sym == :budget_spent_ratioenddef format(project, **)- return unless project.module_enabled?("budgets")+ return unless project.module_enabled?("budgets") && User.current.allowed_in_project?(:view_budgets, project)project_budgets = ::Budgets::Patches::Projects::RowComponentPatch::ProjectBudgets.new(project)number_to_percentage(project_budgets.total_ratio, precision: 0) if project_budgetsendendend-diff --git a/modules/budgets/spec/models/projects/exports/formatters/budget_formatters_spec.rb b/modules/budgets/spec/models/projects/exports/formatters/budget_currency_attribute_spec.rbsimilarity index 55%rename from modules/budgets/spec/models/projects/exports/formatters/budget_formatters_spec.rbrename to modules/budgets/spec/models/projects/exports/formatters/budget_currency_attribute_spec.rbindex 7e5a0ed9b17..3157753f3ec 100644--- a/modules/budgets/spec/models/projects/exports/formatters/budget_formatters_spec.rb+++ b/modules/budgets/spec/models/projects/exports/formatters/budget_currency_attribute_spec.rb@@ -30,32 +30,65 @@require "rails_helper"-RSpec.describe "Projects budget formatters" do+RSpec.describe Projects::Exports::Formatters::BudgetCurrencyAttribute dolet(:project) { create(:project) }let(:project_budgets_double) { instance_double(Budgets::Patches::Projects::RowComponentPatch::ProjectBudgets) }let(:budgets_patch_class) { Budgets::Patches::Projects::RowComponentPatch::ProjectBudgets }+ let(:user_with_permission) { create(:user, member_with_permissions: { project => [:view_budgets] }) }+ let(:user_without_permission) { create(:user) }before doallow(budgets_patch_class).to receive(:new).with(project).and_return(project_budgets_double)end- describe Projects::Exports::Formatters::BudgetCurrencyAttribute do- describe ".apply?" do- it "returns true for supported budget attributes" do- expect(described_class.apply?(:budget_available, :csv)).to be true- expect(described_class.apply?(:budget_spent, :csv)).to be true- expect(described_class.apply?(:budget_planned, :csv)).to be true- expect(described_class.apply?(:budget_available, :pdf)).to be true- expect(described_class.apply?(:budget_spent, :pdf)).to be true- expect(described_class.apply?(:budget_planned, :pdf)).to be true+ describe ".apply?" do+ it "returns true for supported budget attributes" do+ expect(described_class.apply?(:budget_available, :csv)).to be true+ expect(described_class.apply?(:budget_spent, :csv)).to be true+ expect(described_class.apply?(:budget_planned, :csv)).to be true+ expect(described_class.apply?(:budget_available, :pdf)).to be true+ expect(described_class.apply?(:budget_spent, :pdf)).to be true+ expect(described_class.apply?(:budget_planned, :pdf)).to be true+ end++ it "returns false for unsupported attributes" do+ expect(described_class.apply?(:budget_spent_ratio, :csv)).to be false+ end+ end++ describe "#format" do+ it "returns nil when the an attribute is not available" do+ allow(project_budgets_double).to receive(:total_available).and_return(42.7)+ instance = described_class.new(:budget_available)++ expect(instance.format(project)).to be_nil+ end++ it "returns nil when ProjectBudgets is not available" do+ allow(budgets_patch_class).to receive(:new).with(project).and_return(nil)+ instance = described_class.new(:budget_spent_ratio)++ expect(instance.format(project)).to be_nil+ end++ context "with user without permission" do+ before do+ User.current = user_without_permissionend- it "returns false for unsupported attributes" do- expect(described_class.apply?(:budget_spent_ratio, :csv)).to be false+ it "returns nil" do+ allow(project_budgets_double).to receive(:total_available).and_return(42.7)+ instance = described_class.new(:budget_available)++ expect(instance.format(project)).to be_nilendend- describe "#format" do+ context "with user with permission" do+ before do+ User.current = user_with_permission+ end+it "formats the budget available" doallow(project_budgets_double).to receive(:total_available).and_return(42.7)instance = described_class.new(:budget_available)@@ -78,41 +111,4 @@ RSpec.describe "Projects budget formatters" doendendend-- describe Projects::Exports::Formatters::BudgetSpentRatio do- describe ".apply?" do- it "returns true for :budget_spent_ratio" do- expect(described_class.apply?(:budget_spent_ratio, :csv)).to be true- expect(described_class.apply?(:budget_spent_ratio, :pdf)).to be true- end-- it "returns false for other attributes" do- expect(described_class.apply?(:budget_spent, :pdf)).to be false- expect(described_class.apply?(:budget_planned, :unknown)).to be false- end- end-- describe "#format" do- it "formats the spent ratio percentage" do- allow(project_budgets_double).to receive(:total_ratio).and_return(42.7)- instance = described_class.new(:budget_spent_ratio)-- expect(instance.format(project)).to eq("43%")- end-- it "returns nil when the spent ratio is not available" do- allow(project_budgets_double).to receive(:total_ratio).and_return(nil)- instance = described_class.new(:budget_spent_ratio)-- expect(instance.format(project)).to be_nil- end-- it "returns nil when ProjectBudgets is not available" do- allow(budgets_patch_class).to receive(:new).with(project).and_return(nil)- instance = described_class.new(:budget_spent_ratio)-- expect(instance.format(project)).to be_nil- end- end- endenddiff --git a/modules/budgets/spec/models/projects/exports/formatters/budget_spent_ratio_spec.rb b/modules/budgets/spec/models/projects/exports/formatters/budget_spent_ratio_spec.rbnew file mode 100644index 00000000000..587ae432a8f--- /dev/null+++ b/modules/budgets/spec/models/projects/exports/formatters/budget_spent_ratio_spec.rb@@ -0,0 +1,97 @@+# frozen_string_literal: true++#-- copyright+# OpenProject is an open source project management software.+# Copyright (C) the OpenProject GmbH+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License version 3.+#+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:+# Copyright (C) 2006-2013 Jean-Philippe Lang+# Copyright (C) 2010-2013 the ChiliProject Team+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License+# as published by the Free Software Foundation; either version 2+# of the License, or (at your option) any later version.+#+# This program is distributed in the hope that it will be useful,+# but WITHOUT ANY WARRANTY; without even the implied warranty of+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+# GNU General Public License for more details.+#+# You should have received a copy of the GNU General Public License+# along with this program; if not, write to the Free Software+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.+#+# See COPYRIGHT and LICENSE files for more details.+#++++require "rails_helper"++RSpec.describe Projects::Exports::Formatters::BudgetSpentRatio do+ let(:project) { create(:project) }+ let(:project_budgets_double) { instance_double(Budgets::Patches::Projects::RowComponentPatch::ProjectBudgets) }+ let(:budgets_patch_class) { Budgets::Patches::Projects::RowComponentPatch::ProjectBudgets }+ let(:user_with_permission) { create(:user, member_with_permissions: { project => [:view_budgets] }) }+ let(:user_without_permission) { create(:user) }++ before do+ allow(budgets_patch_class).to receive(:new).with(project).and_return(project_budgets_double)+ end++ describe ".apply?" do+ it "returns true for :budget_spent_ratio" do+ expect(described_class.apply?(:budget_spent_ratio, :csv)).to be true+ expect(described_class.apply?(:budget_spent_ratio, :pdf)).to be true+ end++ it "returns false for other attributes" do+ expect(described_class.apply?(:budget_spent, :pdf)).to be false+ expect(described_class.apply?(:budget_planned, :unknown)).to be false+ end+ end++ describe "#format" do+ it "returns nil when the spent ratio is not available" do+ allow(project_budgets_double).to receive(:total_ratio).and_return(nil)+ instance = described_class.new(:budget_spent_ratio)++ expect(instance.format(project)).to be_nil+ end++ it "returns nil when ProjectBudgets is not available" do+ allow(budgets_patch_class).to receive(:new).with(project).and_return(nil)+ instance = described_class.new(:budget_spent_ratio)++ expect(instance.format(project)).to be_nil+ end++ context "with user without permission" do+ before do+ User.current = user_without_permission+ end++ it "returns nil" do+ allow(project_budgets_double).to receive(:total_ratio).and_return(42.7)+ instance = described_class.new(:budget_spent_ratio)++ expect(instance.format(project)).to be_nil+ end+ end++ context "with user with permission" do+ before do+ User.current = user_with_permission+ end++ it "formats the spent ratio percentage" do+ allow(project_budgets_double).to receive(:total_ratio).and_return(42.7)+ instance = described_class.new(:budget_spent_ratio)++ expect(instance.format(project)).to eq("43%")+ end+ end+ end+end