Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Fix method on project index

Oliver Günther4642663272e8
diff --git a/app/components/projects/index_page_header_component.rb b/app/components/projects/index_page_header_component.rb
index e793a12fc46..4fe7f038c07 100644
--- a/app/components/projects/index_page_header_component.rb
+++ b/app/components/projects/index_page_header_component.rb
@@ -147,7 +147,10 @@ class Projects::IndexPageHeaderComponent < ApplicationComponent
mobile_icon: nil, # Do not show on mobile as it is already part of the menu
mobile_label: nil,
href:,
- data: { "turbo-stream": true, method: },
+ data: {
+ turbo_stream: true,
+ turbo_method: method
+ },
target: ""
) do
render(
@@ -166,7 +169,10 @@ class Projects::IndexPageHeaderComponent < ApplicationComponent
label:,
href:,
content_arguments: {
- data: { "turbo-stream": true, method: }
+ data: {
+ turbo_stream: true,
+ turbo_method: method
+ }
}
) do |item|
item.with_leading_visual_icon(icon: :"op-save")
diff --git a/app/controllers/projects/queries_controller.rb b/app/controllers/projects/queries_controller.rb
index 98f60c8af14..f665e0f1f0e 100644
--- a/app/controllers/projects/queries_controller.rb
+++ b/app/controllers/projects/queries_controller.rb
@@ -142,7 +142,10 @@ class Projects::QueriesController < ApplicationController
if service_call.success?
flash[:notice] = I18n.t(success_i18n_key)
- redirect_to modified_query.visible? ? projects_path(query_id: modified_query.id) : projects_path
+ redirect_to(
+ modified_query.visible? ? projects_path(query_id: modified_query.id) : projects_path,
+ status: :see_other
+ )
else
flash[:error] = I18n.t(error_i18n_key, errors: service_call.errors.full_messages.join("\n"))
diff --git a/spec/support/pages/projects/index.rb b/spec/support/pages/projects/index.rb
index 345202716a8..a45933123a8 100644
--- a/spec/support/pages/projects/index.rb
+++ b/spec/support/pages/projects/index.rb
@@ -342,6 +342,7 @@ module Pages
def save_query
click_more_menu_item("Save")
+ wait_for_network_idle
end
def save_query_as(name)