Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Fix rubocop errors in TimeEntriesController

Klaus Zanders499fa5fc4108
diff --git a/modules/costs/app/controllers/time_entries_controller.rb b/modules/costs/app/controllers/time_entries_controller.rb
index 3ddd507b201..cd19b9b71de 100644
--- a/modules/costs/app/controllers/time_entries_controller.rb
+++ b/modules/costs/app/controllers/time_entries_controller.rb
@@ -45,7 +45,7 @@ class TimeEntriesController < ApplicationController
def dialog
@show_work_package = params[:work_package_id].blank?
- @show_user = show_user_input_in_dialog
+ @show_user = show_user_input_in_dialog?
@limit_to_project_id = @project&.id
prefill_time_entry_from_params
@@ -122,7 +122,7 @@ class TimeEntriesController < ApplicationController
respond_with_turbo_streams(status: call.success? ? :ok : :bad_request)
end
- def destroy
+ def destroy # rubocop:disable Metrics/AbcSize
call = TimeEntries::DeleteService.new(user: current_user, model: @time_entry).call
@time_entry = call.result
@@ -177,7 +177,7 @@ class TimeEntriesController < ApplicationController
end
end
- def show_user_input_in_dialog
+ def show_user_input_in_dialog?
return false if params[:onlyMe] == "true"
if @project