OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Better naming what the `delete_detail` method is doing
Klaus Zanders49ba0dc406d6
diff --git a/app/components/activities/item_component.rb b/app/components/activities/item_component.rbindex 6fe7b1e3cc9..fcbb391d45c 100644--- a/app/components/activities/item_component.rb+++ b/app/components/activities/item_component.rb@@ -125,17 +125,17 @@ class Activities::ItemComponent < ViewComponent::Basedetails = @event.journal.detailsdetails.delete(:user_id) if details[:logged_by_id] == details[:user_id]- delete_detail(details, :work_package_id)- delete_detail(details, :entity_type)- delete_detail(details, :entity_id)- delete_detail(details, :comments)- delete_detail(details, :activity_id)- delete_detail(details, :spent_on)+ remove_detail_when_changing_from_empty(details, "work_package_id")+ remove_detail_when_changing_from_empty(details, "entity_type")+ remove_detail_when_changing_from_empty(details, "entity_id")+ remove_detail_when_changing_from_empty(details, "comments")+ remove_detail_when_changing_from_empty(details, "activity_id")+ remove_detail_when_changing_from_empty(details, "spent_on")detailsend- def delete_detail(details, field)+ def remove_detail_when_changing_from_empty(details, field)details.delete(field) if details[field] && details[field].first.nil?end