Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#64348] use #formula_referenced_custom_field_ids

Tobias Dillmann52c15efaa096
diff --git a/app/models/custom_field/calculated_value.rb b/app/models/custom_field/calculated_value.rb
index 935dda30861..2caab0291b4 100644
--- a/app/models/custom_field/calculated_value.rb
+++ b/app/models/custom_field/calculated_value.rb
@@ -143,8 +143,8 @@ module CustomField::CalculatedValue
def has_circular_reference?(custom_field, original_id, visited = Set.new)
return true unless visited.add?(custom_field.id)
- if custom_field.field_format_calculated_value? && custom_field.formula
- referenced_custom_fields = custom_field.formula.fetch("referenced_custom_fields", [])
+ if custom_field.field_format_calculated_value?
+ referenced_custom_fields = custom_field.formula_referenced_custom_field_ids
return true if referenced_custom_fields.include?(original_id)