OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Allow waiting for reference value to change after saving in flashes
Oliver Günther555c6ac32a04
diff --git a/modules/meeting/spec/features/structured_meetings/structured_meeting_update_flash_spec.rb b/modules/meeting/spec/features/structured_meetings/structured_meeting_update_flash_spec.rbindex fb859e3a30b..5bb68fe2392 100644--- a/modules/meeting/spec/features/structured_meetings/structured_meeting_update_flash_spec.rb+++ b/modules/meeting/spec/features/structured_meetings/structured_meeting_update_flash_spec.rb@@ -92,7 +92,7 @@ RSpec.describe "Meetings CRUD",within_window(first_window) doitem = MeetingAgendaItem.find_by(title: "Update toast test item")- show_page.edit_agenda_item(item) do+ show_page.edit_agenda_item(item, wait_for_reference_update: true) dofill_in "Title", with: "Updated title"enddiff --git a/modules/meeting/spec/support/pages/meetings/show.rb b/modules/meeting/spec/support/pages/meetings/show.rbindex f15304c246d..0b1742cb27b 100644--- a/modules/meeting/spec/support/pages/meetings/show.rb+++ b/modules/meeting/spec/support/pages/meetings/show.rb@@ -442,15 +442,18 @@ module Pages::Meetingsendend- def edit_agenda_item(item, save: true, &)+ def edit_agenda_item(item, save: true, wait_for_reference_update: false, &)select_action item, "Edit"expect_item_edit_form(item)+ reference_value = meeting_reference_valuepage.within("#meeting-agenda-items-form-component-#{item.id}") doyieldif saveclick_save_and_wait_for_agenda_item_updateendend++ wait_for_reference_changed(reference_value) if save && wait_for_reference_updateenddef expect_item_edit_form(item, visible: true)@@ -704,5 +707,16 @@ module Pages::Meetingspage.execute_script("arguments[0].value = arguments[1]", input.native, time)page.execute_script("arguments[0].dispatchEvent(new Event('input'))", input.native)end++ def meeting_reference_value+ page_header = page.find("#meetings-header-component page-header")+ page_header["data-reference-value"]+ end++ def wait_for_reference_changed(old_reference_value)+ expect(page).to have_css("#meetings-header-component page-header") do |element|+ element["data-reference-value"] != old_reference_value+ end+ endendend