OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
fix set attribute service
Klaus Zanders60aaa8cb16d3
diff --git a/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb b/modules/costs/spec/services/time_entries/set_attributes_service_spec.rbindex bc7ea05c1e5..19d0b9ddd62 100644--- a/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb+++ b/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb@@ -104,7 +104,7 @@ RSpec.describe TimeEntries::SetAttributesService, type: :model docontext "with params" dolet(:params) do{- work_package:,+ entity: work_package,project:,activity:,spent_on:,@@ -116,7 +116,8 @@ RSpec.describe TimeEntries::SetAttributesService, type: :model dolet(:expected) do{user_id: user.id,- work_package_id: work_package.id,+ entity_type: "WorkPackage",+ entity_id: work_package.id,project_id: project.id,activity_id: activity.id,spent_on: Date.parse(spent_on),@@ -172,7 +173,8 @@ RSpec.describe TimeEntries::SetAttributesService, type: :model dospent_on: Time.zone.today,ongoing: true,user_id: user.id,- work_package_id: work_package.id,+ entity_type: "WorkPackage",+ entity_id: work_package.id,activity_id: activity.id}end@@ -227,11 +229,11 @@ RSpec.describe TimeEntries::SetAttributesService, type: :model docontext "with project not specified" dolet(:params) do{- work_package:+ entity: work_package}end- it "sets the project to the work_package's project" do+ it "sets the project to the entities project" dosubjectexpect(time_entry_instance.project)