Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#66899] fixed node assertions of the suggestion list

Eric Schubert657f71d80c79
diff --git a/frontend/src/stimulus/controllers/pattern-input.controller.ts b/frontend/src/stimulus/controllers/pattern-input.controller.ts
index 5c69485e256..a5d49bd67e3 100644
--- a/frontend/src/stimulus/controllers/pattern-input.controller.ts
+++ b/frontend/src/stimulus/controllers/pattern-input.controller.ts
@@ -395,7 +395,8 @@ export default class PatternInputController extends Controller {
// insert the HTML
filtered.forEach((group, idx) => {
const groupHeader = this.suggestionsHeadingTemplateTarget.content.cloneNode(true);
- if (this.isElement(groupHeader)) {
+
+ if (this.isDocumentFragmentNode(groupHeader)) {
const headerElement = groupHeader.querySelector('h2');
if (headerElement) {
headerElement.innerText = group.label;
@@ -406,7 +407,7 @@ export default class PatternInputController extends Controller {
group.values.forEach((suggestion) => {
const suggestionTemplate = this.suggestionsItemTemplateTarget.content.cloneNode(true);
- if (!this.isElement(suggestionTemplate)) { return; }
+ if (!this.isDocumentFragmentNode(suggestionTemplate)) { return; }
const suggestionItem = suggestionTemplate.firstElementChild;
if (this.isElement(suggestionItem)) {
@@ -623,6 +624,10 @@ export default class PatternInputController extends Controller {
return this.isElement(node) && node.dataset.role === 'list_item';
}
+ private isDocumentFragmentNode(node:Node|null):node is DocumentFragment {
+ return node !== null && node.nodeType === Node.DOCUMENT_FRAGMENT_NODE;
+ }
+
private isText(node:Node|null):node is Text {
return node !== null && node.nodeType === Node.TEXT_NODE;
}