OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
no parents allowed for portfolio
ulferts6882ca018320
diff --git a/app/models/projects/scopes/assignable_parents.rb b/app/models/projects/scopes/assignable_parents.rbindex f454e48137f..387a18330c1 100644--- a/app/models/projects/scopes/assignable_parents.rb+++ b/app/models/projects/scopes/assignable_parents.rb@@ -34,9 +34,13 @@ module Projects::Scopesclass_methods dodef assignable_parents(user, project)- Project- .allowed_to(user, :add_subprojects)- .where.not(id: project.self_and_descendants)+ if project.portfolio?+ Project.none+ else+ Project+ .allowed_to(user, :add_subprojects)+ .where.not(id: project.self_and_descendants)+ endendendenddiff --git a/spec/models/projects/scopes/assignable_parents_spec.rb b/spec/models/projects/scopes/assignable_parents_spec.rbindex 28b08e322cb..da9804bdc4c 100644--- a/spec/models/projects/scopes/assignable_parents_spec.rb+++ b/spec/models/projects/scopes/assignable_parents_spec.rb@@ -36,12 +36,27 @@ RSpec.describe Projects::Scopes::AssignableParents doshared_let(:user) { create(:user) }shared_let(:project_with_permission) { create(:project, members: { user => add_subprojects_role }) }shared_let(:parent_project) { create(:project, members: { user => add_subprojects_role }) }- shared_let(:subject_project) { create(:project, parent: parent_project, members: { user => add_subprojects_role }) }+ shared_let(:subject_project, reload: true) do+ create(:project, parent: parent_project, members: { user => add_subprojects_role })+ endshared_let(:child_project) { create(:project, parent: subject_project, members: { user => add_subprojects_role }) }shared_let(:project_without_permission) { create(:project, members: { user => view_role }) }- it "returns all projects the user has the add_subprojects permission in but without self or descendants" do- expect(Project.assignable_parents(user, subject_project))- .to contain_exactly(project_with_permission, parent_project)+ context "for a project" do+ it "returns all projects the user has the add_subprojects permission in but without self or descendants" do+ expect(Project.assignable_parents(user, subject_project))+ .to contain_exactly(project_with_permission, parent_project)+ end+ end++ context "for a portfolio" do+ before do+ subject_project.portfolio!+ end++ it "is empty" do+ expect(Project.assignable_parents(user, subject_project))+ .to be_empty+ endendend