OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Implement Project Status widget read-only mode
Alexander Brandon Coles693c5b7edebf
diff --git a/modules/overviews/app/components/overviews/widgets/project_status_component.html.erb b/modules/overviews/app/components/overviews/widgets/project_status_component.html.erbindex e145d5a824c..58dddd08bfb 100644--- a/modules/overviews/app/components/overviews/widgets/project_status_component.html.erb+++ b/modules/overviews/app/components/overviews/widgets/project_status_component.html.erb@@ -29,19 +29,30 @@ See COPYRIGHT and LICENSE files for more details.<%=component_wrapper tag: :"turbo-frame" do- settings_primer_form_with(- model: project,- url: project_widgets_project_status_path(project),- method: :patch,- data: { turbo: true }- ) do |f|- render(- Primer::Forms::FormList.new(- Projects::StatusButtonComponent.new(project:, user: current_user, hide_help_text: true),- Projects::Settings::StatusForm.new(f, hide_label: true),- Projects::Settings::Submit.new(f, label: I18n.t("projects.settings.button_update_status_description"))- )- )+ flex_layout do |flex|+ flex.with_row(mb: 3) do+ render(Projects::StatusButtonComponent.new(project:, user: current_user, hide_help_text: true))+ end++ flex.with_row do+ if edit_enabled?+ settings_primer_form_with(+ model: project,+ url: project_widgets_project_status_path(project),+ method: :patch,+ data: { turbo: true }+ ) do |f|+ render(+ Primer::Forms::FormList.new(+ Projects::Settings::StatusForm.new(f, hide_label: true),+ Projects::Settings::Submit.new(f, label: I18n.t("projects.settings.button_update_status_description"))+ )+ )+ end+ else+ format_text(project, :status_explanation)+ end+ endendend%>diff --git a/modules/overviews/app/components/overviews/widgets/project_status_component.rb b/modules/overviews/app/components/overviews/widgets/project_status_component.rbindex 82fa058a4c6..9bc73e7e921 100644--- a/modules/overviews/app/components/overviews/widgets/project_status_component.rb+++ b/modules/overviews/app/components/overviews/widgets/project_status_component.rb@@ -43,6 +43,12 @@ module Overviews@project = project@current_user = current_userend++ private++ def edit_enabled?+ current_user.allowed_in_project?(:edit_project, project)+ endendendenddiff --git a/modules/overviews/spec/components/overviews/widgets/project_status_component_spec.rb b/modules/overviews/spec/components/overviews/widgets/project_status_component_spec.rbindex 7867d5bcb51..8983133e6b3 100644--- a/modules/overviews/spec/components/overviews/widgets/project_status_component_spec.rb+++ b/modules/overviews/spec/components/overviews/widgets/project_status_component_spec.rb@@ -37,7 +37,7 @@ RSpec.describe Overviews::Widgets::ProjectStatusComponent, type: :component dorender_inline(described_class.new(...))end- let(:project) { build_stubbed(:project) }+ let(:project) { build_stubbed(:project, status_explanation: "**This project is in jeopardy!**") }let(:user) { build_stubbed(:user) }current_user { user }@@ -50,21 +50,36 @@ RSpec.describe Overviews::Widgets::ProjectStatusComponent, type: :component doexpect(rendered_component).to have_element :"turbo-frame"end- it "renders form" do- expect(rendered_component).to have_element :form, method: :post,- action: project_widgets_project_status_path(project)+ it "renders Projects Status Button component" do+ expect(rendered_component).to have_element id: "projects-status-button-component"end- it "renders hidden method field" do- expect(rendered_component).to have_field "_method", type: :hidden, with: "patch"+ context "when user is not allowed to edit" do+ it "renders status description as formatted text" do+ expect(rendered_component).to have_css "p"+ expect(rendered_component).to have_css "strong", text: "This project is in jeopardy!"+ endend- it "renders Projects Status Button component" do- expect(rendered_component).to have_element id: "projects-status-button-component"- end+ context "when user is allowed to edit" do+ before do+ mock_permissions_for(user) do |mock|+ mock.allow_in_project(:edit_project, project:)+ end+ end++ it "renders form" do+ expect(rendered_component).to have_element :form, method: :post,+ action: project_widgets_project_status_path(project)+ end++ it "renders hidden method field" do+ expect(rendered_component).to have_field "_method", type: :hidden, with: "patch"+ end- it "renders text area field" do- expect(rendered_component).to have_element "opce-ckeditor-augmented-textarea",- "data-test-selector": "augmented-text-area-status_explanation"+ it "renders text area field" do+ expect(rendered_component).to have_element "opce-ckeditor-augmented-textarea",+ "data-test-selector": "augmented-text-area-status_explanation"+ endendend