Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

fix have_enterprise_banner matcher, positional argument is used everywhere instead of keyword argument

Ivan Kuchin70dc8d454468
diff --git a/spec/support/matchers/has_enterprise_banner.rb b/spec/support/matchers/has_enterprise_banner.rb
index 1250799c311..9f8e33f2bef 100644
--- a/spec/support/matchers/has_enterprise_banner.rb
+++ b/spec/support/matchers/has_enterprise_banner.rb
@@ -28,16 +28,17 @@
# See COPYRIGHT and LICENSE files for more details.
#++
-RSpec::Matchers.define :have_enterprise_banner do |**args|
+RSpec::Matchers.define :have_enterprise_banner do |plan, **args|
include TestSelectorFinders
match do |page|
- if args[:plan]
- expected_text = I18n.t("ee.upsell.plan_text_html", plan: args[:plan].capitalize)
- page.find(test_selector("op-enterprise-banner"), **args, text: expected_text)
- else
- page.find(test_selector("op-enterprise-banner"), **args)
+ if plan
+ plan_name = I18n.t("ee.upsell.plan_name", plan: plan.capitalize)
+ expected_text = I18n.t("ee.upsell.plan_text_html", plan_name:)
+ args[:text] = expected_text
end
+
+ page.find(test_selector("op-enterprise-banner"), **args)
end
match_when_negated do |page|