Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Use `hidden` attribute for better a11ly

Kabiru Mwenja7560cb00d2fa
diff --git a/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts b/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts
index 36bbaaae081..2ac5a1a9e79 100644
--- a/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts
+++ b/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts
@@ -38,7 +38,6 @@ export default class LookAndFeelController extends Controller {
declare singleThemeContrastTarget:HTMLElement;
private syncWithOsValue = 'sync_with_os';
- private displayNoneClass = 'd-none';
private viewComponentSelector = '[data-view-component="true"]';
connect() {
@@ -57,7 +56,9 @@ export default class LookAndFeelController extends Controller {
}
private toggleElementVisibility(targetElement:HTMLElement, shouldShow:boolean) {
- const container = targetElement.closest(this.viewComponentSelector);
- container?.classList.toggle(this.displayNoneClass, !shouldShow);
+ const viewComponentContainer = targetElement.closest(this.viewComponentSelector);
+ if (viewComponentContainer) {
+ (viewComponentContainer as HTMLElement).hidden = !shouldShow;
+ }
}
}