OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
DRY up validation specs using Shoulda Matchers
Alexander Brandon Coles79ab56080618
diff --git a/config/locales/en.yml b/config/locales/en.ymlindex 2e0f4abb545..72fef6083ff 100644--- a/config/locales/en.yml+++ b/config/locales/en.yml@@ -1059,6 +1059,8 @@ en:admin_only: "Admin-only"custom_value:value: "Value"+ design_color:+ variable: "Variable"doorkeeper/application:uid: "Client ID"secret: "Client secret"diff --git a/spec/models/color_spec.rb b/spec/models/color_spec.rbindex e8e0f2d9dd2..6fc29522757 100644--- a/spec/models/color_spec.rb+++ b/spec/models/color_spec.rb@@ -80,55 +80,22 @@ RSpec.describe Color doendend- describe "- Validations" do- let(:attributes) do- { name: "Color No. 1",- hexcode: "#FFFFFF" }+ describe "validations" do+ it "validates name is present and at most 255 chars" do+ expect(subject).to validate_presence_of(:name)+ expect(subject).to validate_length_of(:name).is_at_most(255)end- describe "name" do- it "is invalid w/o a name" do- attributes[:name] = nil- color = described_class.new(attributes)-- expect(color).not_to be_valid-- expect(color.errors[:name]).to be_present- expect(color.errors[:name]).to eq(["can't be blank."])- end-- it "is invalid w/ a name longer than 255 characters" do- attributes[:name] = "A" * 500- color = described_class.new(attributes)-- expect(color).not_to be_valid-- expect(color.errors[:name]).to be_present- expect(color.errors[:name]).to eq(["is too long (maximum is 255 characters)."])- end+ it "validates hexcode is present" do+ expect(subject).to validate_presence_of(:hexcode)end- describe "hexcode" do- it "is invalid w/o a hexcode" do- attributes[:hexcode] = nil- color = described_class.new(attributes)-- expect(color).not_to be_valid-- expect(color.errors[:hexcode]).to be_present- expect(color.errors[:hexcode]).to eq(["can't be blank."])- end-- it "is invalid w/ malformed hexcodes" do- expect(described_class.new(attributes.merge(hexcode: "0#FFFFFF"))).not_to be_valid- expect(described_class.new(attributes.merge(hexcode: "#FFFFFF0"))).not_to be_valid- expect(described_class.new(attributes.merge(hexcode: "white"))).not_to be_valid- end+ it "does not allow malformed hexcodes" do+ expect(subject).not_to allow_values("0#FFFFFF", "#FFFFFF0", "white").for(:hexcode)+ end- it "is valid w/ proper hexcodes" do- expect(described_class.new(attributes.merge(hexcode: "#FFFFFF"))).to be_valid- expect(described_class.new(attributes.merge(hexcode: "#FF00FF"))).to be_valid- end+ it "allows valid hexcodes" do+ expect(subject).to allow_values("#FFFFFF", "#FF00FF").for(:hexcode)endendenddiff --git a/spec/models/design_color_spec.rb b/spec/models/design_color_spec.rbindex 4ca32ca2859..25b443d2038 100644--- a/spec/models/design_color_spec.rb+++ b/spec/models/design_color_spec.rb@@ -45,49 +45,45 @@ RSpec.describe DesignColor doendend- describe "#get_hexcode" do- it "returns hexcode if present" do- primary_color- expect(primary_color.hexcode).to eq("#3493B3")+ describe "validations" do+ it "validates variable is present and unique" do+ expect(subject).to validate_presence_of(:variable)+ expect(subject).to validate_uniqueness_of(:variable)end- it "returns nil hexcode if hexcode not present" do- expect(described_class.new(variable: "primary-button-color").hexcode)- .to be_nil+ it "validates hexcode is present" do+ expect(subject).to validate_presence_of(:hexcode)end- end-- describe "validations" do- context "a color_variable already exists" do- let(:design_color) do- described_class.new variable: "foo", hexcode: "#AB1234"- end- before do- design_color.save- end+ it "does not allow malformed hexcodes" do+ expect(subject).not_to allow_values(+ "1",+ "#1",+ "#1111111",+ "#HHHHHH"+ ).for(:hexcode)+ end- it "fails validation for another design_color with same name" do- second_color_variable = described_class.new variable: "foo", hexcode: "#888888"- expect(second_color_variable).not_to be_valid- end+ it "allows valid hexcodes" do+ expect(subject).to allow_values(+ "111111",+ "#111111",+ "#ABC123",+ "#111",+ "111"+ ).for(:hexcode)end+ end- context "the hexcode's validation" do- it "fails validations" do- expect(described_class.new(variable: "foo", hexcode: "1")).not_to be_valid- expect(described_class.new(variable: "foo", hexcode: "#1")).not_to be_valid- expect(described_class.new(variable: "foo", hexcode: "#1111111")).not_to be_valid- expect(described_class.new(variable: "foo", hexcode: "#HHHHHH")).not_to be_valid- end+ describe "#hexcode" do+ it "returns hexcode if present" do+ primary_color+ expect(primary_color.hexcode).to eq("#3493B3")+ end- it "passes validations" do- expect(described_class.new(variable: "foo", hexcode: "111111")).to be_valid- expect(described_class.new(variable: "foo", hexcode: "#111111")).to be_valid- expect(described_class.new(variable: "foo", hexcode: "#ABC123")).to be_valid- expect(described_class.new(variable: "foo", hexcode: "#111")).to be_valid- expect(described_class.new(variable: "foo", hexcode: "111")).to be_valid- end+ it "returns nil hexcode if hexcode not present" do+ expect(described_class.new(variable: "primary-button-color").hexcode)+ .to be_nilendend