OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
add calculated value strategy
Ivan Kuchin7acbaff85a3e
diff --git a/app/models/custom_value/calculated_value_strategy.rb b/app/models/custom_value/calculated_value_strategy.rbnew file mode 100644index 00000000000..153890ca9f1--- /dev/null+++ b/app/models/custom_value/calculated_value_strategy.rb@@ -0,0 +1,56 @@+# frozen_string_literal: true++#-- copyright+# OpenProject is an open source project management software.+# Copyright (C) the OpenProject GmbH+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License version 3.+#+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:+# Copyright (C) 2006-2013 Jean-Philippe Lang+# Copyright (C) 2010-2013 the ChiliProject Team+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License+# as published by the Free Software Foundation; either version 2+# of the License, or (at your option) any later version.+#+# This program is distributed in the hope that it will be useful,+# but WITHOUT ANY WARRANTY; without even the implied warranty of+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+# GNU General Public License for more details.+#+# You should have received a copy of the GNU General Public License+# along with this program; if not, write to the Free Software+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.+#+# See COPYRIGHT and LICENSE files for more details.+#++++class CustomValue::CalculatedValueStrategy < CustomValue::FormatStrategy+ include ActionView::Helpers::NumberHelper++ def typed_value+ if value.present?+ integer_value? ? value.to_i : value.to_f+ end+ end++ def formatted_value+ integer_value? ? value.to_s : number_with_delimiter(value.to_s)+ end++ def validate_type_of_value+ Kernel.Float(value)+ nil+ rescue StandardError+ :not_a_number+ end++ private++ def integer_value?+ value && value =~ /\A\d+\z/+ end+enddiff --git a/config/initializers/custom_field_format.rb b/config/initializers/custom_field_format.rbindex 329b8c06b43..57e1ebc3b5d 100644--- a/config/initializers/custom_field_format.rb+++ b/config/initializers/custom_field_format.rb@@ -97,5 +97,6 @@ OpenProject::CustomFieldFormat.map do |fields|order: 13,enabled: lambda doOpenProject::FeatureDecisions.calculated_value_project_attribute_active?- end)+ end,+ formatter: "CustomValue::CalculatedValueStrategy")enddiff --git a/spec/models/custom_value/calculated_value_strategy_spec.rb b/spec/models/custom_value/calculated_value_strategy_spec.rbnew file mode 100644index 00000000000..03d232e5ecd--- /dev/null+++ b/spec/models/custom_value/calculated_value_strategy_spec.rb@@ -0,0 +1,166 @@+# frozen_string_literal: true++#-- copyright+# OpenProject is an open source project management software.+# Copyright (C) the OpenProject GmbH+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License version 3.+#+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:+# Copyright (C) 2006-2013 Jean-Philippe Lang+# Copyright (C) 2010-2013 the ChiliProject Team+#+# This program is free software; you can redistribute it and/or+# modify it under the terms of the GNU General Public License+# as published by the Free Software Foundation; either version 2+# of the License, or (at your option) any later version.+#+# This program is distributed in the hope that it will be useful,+# but WITHOUT ANY WARRANTY; without even the implied warranty of+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+# GNU General Public License for more details.+#+# You should have received a copy of the GNU General Public License+# along with this program; if not, write to the Free Software+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.+#+# See COPYRIGHT and LICENSE files for more details.+#++++require "spec_helper"++RSpec.describe CustomValue::CalculatedValueStrategy do+ let(:instance) { described_class.new(custom_value) }+ let(:custom_value) { instance_double(CustomValue, value:) }++ describe "#typed_value" do+ subject { instance.typed_value }++ context "when value is a float string" do+ let(:value) { "3.14" }++ it { is_expected.to be(3.14) }+ end++ context "when value is an int string" do+ let(:value) { "42" }++ it { is_expected.to be(42) }+ end++ context "when value is blank" do+ let(:value) { "" }++ it { is_expected.to be_nil }+ end++ context "when value is nil" do+ let(:value) { nil }++ it { is_expected.to be_nil }+ end+ end++ describe "#formatted_value" do+ subject { instance.formatted_value }++ context "when value is a float string" do+ let(:value) { "3.14" }++ it "is the float string" do+ expect(subject).to eql value+ end++ it "is localized" do+ I18n.with_locale(:de) do+ expect(subject).to eql "3,14"+ end+ end+ end++ context "when value is an int string" do+ let(:value) { "42" }++ it "is the int string" do+ expect(subject).to eql value+ end+ end++ context "when value is blank" do+ let(:value) { "" }++ it "is a blank string" do+ expect(subject).to eql value+ end+ end++ context "when value is nil" do+ let(:value) { nil }++ it "is a blank string" do+ expect(subject).to eql ""+ end+ end+ end++ describe "#validate_type_of_value" do+ subject { instance.validate_type_of_value }++ context "when value is a float string in decimal notation" do+ let(:value) { "3.14" }++ it "accepts" do+ expect(subject).to be_nil+ end+ end++ context "when value is a float string in exp. notation" do+ let(:value) { "5.0e-14" }++ it "accepts" do+ expect(subject).to be_nil+ end+ end++ context "when value is a positive int string" do+ let(:value) { "10" }++ it "accepts" do+ expect(subject).to be_nil+ end+ end++ context "when value is a negative int string" do+ let(:value) { "-10" }++ it "accepts" do+ expect(subject).to be_nil+ end+ end++ context "when value is not a float string" do+ let(:value) { "banana" }++ it "rejects" do+ expect(subject).to be(:not_a_number)+ end+ end++ context "when value is a float" do+ let(:value) { 3.14 }++ it "accepts" do+ expect(subject).to be_nil+ end+ end++ context "when value is an int" do+ let(:value) { 3 }++ it "accepts" do+ expect(subject).to be_nil+ end+ end+ end+end