Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#66093] Error removal happens in `handle_calcluation_errors!` now

Tobias Dillmann7b646524cc1e
diff --git a/app/models/acts_as_customizable/calculated_value.rb b/app/models/acts_as_customizable/calculated_value.rb
index 4bd233a7252..69a82f83cba 100644
--- a/app/models/acts_as_customizable/calculated_value.rb
+++ b/app/models/acts_as_customizable/calculated_value.rb
@@ -47,8 +47,6 @@ module ActsAsCustomizable::CalculatedValue
enabled_ids = enabled_custom_field_ids
given = calculated_value_fields_given(custom_fields:, enabled_ids:)
- remove_calculated_value_errors!(custom_fields.map(&:id))
-
result, errors = calculate_custom_fields_result(
given:,
to_compute: calculated_value_fields_to_compute(custom_fields:, enabled_ids:)
@@ -112,6 +110,8 @@ module ActsAsCustomizable::CalculatedValue
end
def handle_calculation_errors!(given_cfs, enabled_ids, calculated_fields, result, errors)
+ remove_calculated_value_errors!(calculated_fields.map(&:id))
+
return unless is_a?(Project) && errors.any?
enabled_calculated_fields = calculated_fields.filter { it.id.in?(enabled_ids) }