Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#66613] Projects list with URL project attribute cannot be exported

as-op87344b1f2882
diff --git a/app/models/exports/formatters/link_formatter.rb b/app/models/exports/formatters/link_formatter.rb
index d8e30880d6f..fed4cf2cf66 100644
--- a/app/models/exports/formatters/link_formatter.rb
+++ b/app/models/exports/formatters/link_formatter.rb
@@ -39,6 +39,8 @@ module Exports
ApplicationController.helpers.link_to(@href, @href)
end
+ delegate :blank?, to: :@href
+
def to_s
@href
end
diff --git a/app/models/projects/exports/pdf_export/report.rb b/app/models/projects/exports/pdf_export/report.rb
index 34101f5ea10..00b3366ab51 100644
--- a/app/models/projects/exports/pdf_export/report.rb
+++ b/app/models/projects/exports/pdf_export/report.rb
@@ -158,7 +158,11 @@ module Projects::Exports::PDFExport
value = format_attribute(project, value_name, :pdf)
return nil if hide_empty_attributes? && value.blank?
- value = make_link_href_cell(url_helpers.project_url(project), value) if value_name == :id
+ if value.is_a?(::Exports::Formatters::LinkFormatter)
+ value = get_cf_link_cell(value)
+ elsif value_name == :id
+ value = make_link_href_cell(url_helpers.project_url(project), value)
+ end
[
{ content: caption }.merge(styles.project_attributes_table_label_cell),
value || ""
diff --git a/spec/models/projects/exporter/exportable_project_context.rb b/spec/models/projects/exporter/exportable_project_context.rb
index 3968137d416..7d755db3bbb 100644
--- a/spec/models/projects/exporter/exportable_project_context.rb
+++ b/spec/models/projects/exporter/exportable_project_context.rb
@@ -38,8 +38,9 @@ RSpec.shared_context "with a project with an arrangement of custom fields" do
shared_let(:string_cf) { create(:string_project_custom_field, position: 7) }
shared_let(:date_cf) { create(:date_project_custom_field, position: 8) }
shared_let(:hidden_cf) { create(:string_project_custom_field, position: 9, admin_only: true) }
+ shared_let(:link_cf) { create(:link_project_custom_field, position: 10) }
- let!(:not_used_string_cf) { create(:string_project_custom_field, position: 10) }
+ let!(:not_used_string_cf) { create(:string_project_custom_field, position: 11) }
shared_let(:system_version) { create(:version, sharing: "system") }
@@ -70,7 +71,8 @@ RSpec.shared_context "with a project with an arrangement of custom fields" do
string_cf.id => "Some small text",
date_cf.id => Time.zone.today,
user_cf.id => other_user.id,
- hidden_cf.id => "hidden"
+ hidden_cf.id => "hidden",
+ link_cf.id => "https://www.example.com"
})
project.save!(validate: false)
diff --git a/spec/models/projects/exports/pdf_spec.rb b/spec/models/projects/exports/pdf_spec.rb
index 57f950b6c92..a43bd916adc 100644
--- a/spec/models/projects/exports/pdf_spec.rb
+++ b/spec/models/projects/exports/pdf_spec.rb
@@ -127,10 +127,12 @@ RSpec.describe Projects::Exports::PDF do
"4.5"
when "text"
"Some long text"
- when "string", "list", "link"
+ when "string", "list"
"Some small text"
when "date"
format_date(Time.zone.today)
+ when "link"
+ "https://www.example.com"
end
end