Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Use SCIM-client instead of SCIM client in specs.

Pavel Balashou88726fd50ae0
diff --git a/spec/features/admin/scim_clients/create_spec.rb b/spec/features/admin/scim_clients/create_spec.rb
index 400e7b0a1dd..85daabe5c1a 100644
--- a/spec/features/admin/scim_clients/create_spec.rb
+++ b/spec/features/admin/scim_clients/create_spec.rb
@@ -30,13 +30,13 @@
require "spec_helper"
-RSpec.describe "Creating a SCIM client", :js, :selenium, driver: :firefox_de do
+RSpec.describe "Creating a SCIM-client", :js, :selenium, driver: :firefox_de do
shared_let(:admin) { create(:admin, preferences: { time_zone: "Etc/UTC" }) }
shared_let(:oidc_provider) { create(:oidc_provider) }
current_user { admin }
- it "can create a SCIM client authenticating through JWT", :aggregate_failures, with_ee: [:scim_api] do
+ it "can create a SCIM-client authenticating through JWT", :aggregate_failures, with_ee: [:scim_api] do
visit new_admin_scim_client_path
expect(page).to be_axe_clean.within("#content")
@@ -51,29 +51,29 @@ RSpec.describe "Creating a SCIM client", :js, :selenium, driver: :firefox_de do
expect(page).to have_text("Name can't be blank")
expect(page).to have_text("Subject claim can't be blank")
- fill_in "Name", with: "My SCIM Client"
+ fill_in "Name", with: "My SCIM-Client"
fill_in "Subject claim", with: "123-abc-456-def"
click_on("Create")
- wait_for { ScimClient.find_by(name: "My SCIM Client") }.not_to be_nil
+ wait_for { ScimClient.find_by(name: "My SCIM-Client") }.not_to be_nil
- created_client = ScimClient.find_by(name: "My SCIM Client")
+ created_client = ScimClient.find_by(name: "My SCIM-Client")
expect(page).to have_current_path(edit_admin_scim_client_path(created_client, first_time_setup: true))
expect(created_client.auth_provider_id).to eq(oidc_provider.id)
expect(created_client.authentication_method).to eq("sso")
expect(created_client.auth_provider_link&.external_id).to eq("123-abc-456-def")
end
- it "can create a SCIM client authenticating through client credentials", with_ee: [:scim_api] do
+ it "can create a SCIM-client authenticating through client credentials", with_ee: [:scim_api] do
visit new_admin_scim_client_path
- fill_in "Name", with: "My SCIM Client"
+ fill_in "Name", with: "My SCIM-client"
select oidc_provider.display_name, from: "Authentication provider"
select "OAuth 2.0 client credentials", from: "Authentication method"
click_on("Create")
- wait_for { ScimClient.find_by(name: "My SCIM Client") }.not_to be_nil
+ wait_for { ScimClient.find_by(name: "My SCIM-client") }.not_to be_nil
- created_client = ScimClient.find_by(name: "My SCIM Client")
+ created_client = ScimClient.find_by(name: "My SCIM-client")
expect(page).to have_current_path(edit_admin_scim_client_path(created_client, first_time_setup: true))
page.within_modal("Client credentials created") do
@@ -84,17 +84,17 @@ RSpec.describe "Creating a SCIM client", :js, :selenium, driver: :firefox_de do
end
end
- it "can create a SCIM client authenticating through a static access token", with_ee: [:scim_api] do
+ it "can create a SCIM-client authenticating through a static access token", with_ee: [:scim_api] do
visit new_admin_scim_client_path
- fill_in "Name", with: "My SCIM Client"
+ fill_in "Name", with: "My SCIM-client"
select oidc_provider.display_name, from: "Authentication provider"
select "Static access token", from: "Authentication method"
click_on("Create")
- wait_for { ScimClient.find_by(name: "My SCIM Client") }.not_to be_nil
+ wait_for { ScimClient.find_by(name: "My SCIM-client") }.not_to be_nil
- created_client = ScimClient.find_by(name: "My SCIM Client")
+ created_client = ScimClient.find_by(name: "My SCIM-client")
expect(page).to have_current_path(edit_admin_scim_client_path(created_client, first_time_setup: true))
page.within_modal("Token created") do
diff --git a/spec/features/admin/scim_clients/index_spec.rb b/spec/features/admin/scim_clients/index_spec.rb
index f4b858f6940..f7e28716b68 100644
--- a/spec/features/admin/scim_clients/index_spec.rb
+++ b/spec/features/admin/scim_clients/index_spec.rb
@@ -30,7 +30,7 @@
require "spec_helper"
-RSpec.describe "Listing SCIM clients", :js, :selenium, driver: :firefox_de do
+RSpec.describe "Listing SCIM-clients", :js, :selenium, driver: :firefox_de do
shared_let(:admin) { create(:admin, preferences: { time_zone: "Etc/UTC" }) }
current_user { admin }
@@ -46,12 +46,12 @@ RSpec.describe "Listing SCIM clients", :js, :selenium, driver: :firefox_de do
expect(page).to have_no_test_selector("Admin::ScimClients::TableComponent")
within(".SubHeader") do
- expect(page).to have_no_link("SCIM client")
+ expect(page).to have_no_link("SCIM-client")
end
end
end
- context "when there are no SCIM clients", with_ee: [:scim_api] do
+ context "when there are no SCIM-clients", with_ee: [:scim_api] do
it "renders a proper blank slate" do
visit admin_scim_clients_path
@@ -64,14 +64,14 @@ RSpec.describe "Listing SCIM clients", :js, :selenium, driver: :firefox_de do
end
within(".SubHeader") do
- click_on "SCIM client"
+ click_on "SCIM-client"
end
expect(page).to have_current_path(new_admin_scim_client_path)
end
end
- context "when there are SCIM clients", with_ee: [:scim_api] do
+ context "when there are SCIM-clients", with_ee: [:scim_api] do
let!(:sso_client) { create(:scim_client) }
it "renders a proper clients table" do
diff --git a/spec/features/admin/scim_clients/update_spec.rb b/spec/features/admin/scim_clients/update_spec.rb
index 2104956b42b..f2dbb0983bc 100644
--- a/spec/features/admin/scim_clients/update_spec.rb
+++ b/spec/features/admin/scim_clients/update_spec.rb
@@ -30,7 +30,7 @@
require "spec_helper"
-RSpec.describe "Updating a SCIM client", :js, :selenium, driver: :firefox_de do
+RSpec.describe "Updating a SCIM-client", :js, :selenium, driver: :firefox_de do
shared_let(:admin) { create(:admin, preferences: { time_zone: "Etc/UTC" }) }
shared_let(:auth_provider) { create(:oidc_provider) }
@@ -48,7 +48,7 @@ RSpec.describe "Updating a SCIM client", :js, :selenium, driver: :firefox_de do
current_user { admin }
- it "can update a SCIM client authenticating through JWT", :aggregate_failures, with_ee: [:scim_api] do
+ it "can update a SCIM-client authenticating through JWT", :aggregate_failures, with_ee: [:scim_api] do
visit edit_admin_scim_client_path(sso_scim_client)
expect(page).to be_axe_clean.within("#content")
@@ -72,12 +72,12 @@ RSpec.describe "Updating a SCIM client", :js, :selenium, driver: :firefox_de do
visit edit_admin_scim_client_path(sso_scim_client)
within(".PageHeader") { click_on "Delete" }
- page.within_modal("Delete SCIM client") { click_on "Delete" }
+ page.within_modal("Delete SCIM-client") { click_on "Delete" }
expect(page).to have_current_path(admin_scim_clients_path)
expect(ScimClient.where(id: sso_scim_client.id)).to be_empty
end
- it "can update a SCIM client authenticating through client credentials", :aggregate_failures, with_ee: [:scim_api] do
+ it "can update a SCIM-client authenticating through client credentials", :aggregate_failures, with_ee: [:scim_api] do
visit edit_admin_scim_client_path(oauth_client_scim_client)
expect(page).to be_axe_clean.within("#content")
@@ -101,12 +101,12 @@ RSpec.describe "Updating a SCIM client", :js, :selenium, driver: :firefox_de do
expect(page).to have_no_field("Client secret")
within(".PageHeader") { click_on "Delete" }
- page.within_modal("Delete SCIM client") { click_on "Delete" }
+ page.within_modal("Delete SCIM-client") { click_on "Delete" }
expect(page).to have_current_path(admin_scim_clients_path)
expect(ScimClient.where(id: oauth_client_scim_client.id)).to be_empty
end
- it "can update a SCIM client authenticating through a static access token", :aggregate_failures, with_ee: [:scim_api] do
+ it "can update a SCIM-client authenticating through a static access token", :aggregate_failures, with_ee: [:scim_api] do
visit edit_admin_scim_client_path(token_scim_client)
expect(page).to be_axe_clean.within("#content")
@@ -159,7 +159,7 @@ RSpec.describe "Updating a SCIM client", :js, :selenium, driver: :firefox_de do
end
within(".PageHeader") { click_on "Delete" }
- page.within_modal("Delete SCIM client") { click_on "Delete" }
+ page.within_modal("Delete SCIM-client") { click_on "Delete" }
expect(page).to have_current_path(admin_scim_clients_path)
expect(ScimClient.where(id: token_scim_client.id)).to be_empty
end