Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[chore] improved test context

Eric Schubert8b1be5b9e139
diff --git a/modules/storages/spec/common/storages/adapters/providers/nextcloud/queries/files_info_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/nextcloud/queries/files_info_query_spec.rb
index 0cb037f43e1..3a3192f117b 100644
--- a/modules/storages/spec/common/storages/adapters/providers/nextcloud/queries/files_info_query_spec.rb
+++ b/modules/storages/spec/common/storages/adapters/providers/nextcloud/queries/files_info_query_spec.rb
@@ -50,14 +50,14 @@ module Storages
context "with an empty array of file ids" do
let(:file_ids) { [] }
- let(:file_infos) { [] }
+ let(:expected_file_infos) { [] }
it_behaves_like "adapter files_info_query: successful list response"
end
- context "with outbound request successful", vcr: "nextcloud/files_info_query_success" do
+ context "with several file ids", vcr: "nextcloud/files_info_query_success" do
let(:file_ids) { %w[182 203 222] }
- let(:file_infos) do
+ let(:expected_file_infos) do
[
Results::StorageFileInfo.new(
status: "Forbidden",
@@ -89,9 +89,9 @@ module Storages
it_behaves_like "adapter files_info_query: successful list response"
end
- context "with outbound request not found", vcr: "nextcloud/files_info_query_not_found" do
+ context "with not existent file id requested", vcr: "nextcloud/files_info_query_not_found" do
let(:file_ids) { %w[1234] }
- let(:file_infos) { [Results::StorageFileInfo.new(status: "Not Found", status_code: 404, id: "1234")] }
+ let(:expected_file_infos) { [Results::StorageFileInfo.new(status: "Not Found", status_code: 404, id: "1234")] }
it_behaves_like "adapter files_info_query: successful list response"
end
@@ -99,7 +99,7 @@ module Storages
context "with multiple file IDs, with different errors",
vcr: "nextcloud/files_info_query_only_one_not_authorized" do
let(:file_ids) { %w[182 1234] }
- let(:file_infos) do
+ let(:expected_file_infos) do
[
Results::StorageFileInfo.new(
status: "Forbidden",
diff --git a/modules/storages/spec/common/storages/adapters/providers/one_drive/queries/files_info_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/one_drive/queries/files_info_query_spec.rb
index ddba343f115..0d52e7362d2 100644
--- a/modules/storages/spec/common/storages/adapters/providers/one_drive/queries/files_info_query_spec.rb
+++ b/modules/storages/spec/common/storages/adapters/providers/one_drive/queries/files_info_query_spec.rb
@@ -46,7 +46,7 @@ module Storages
context "with an empty array of file ids" do
let(:file_ids) { [] }
- let(:file_infos) { [] }
+ let(:expected_file_infos) { [] }
it_behaves_like "adapter files_info_query: successful list response"
end
@@ -59,7 +59,7 @@ module Storages
01AZJL5PNCQCEBFI3N7JGZSX5AOX32Z3LA
)
end
- let(:file_infos) do
+ let(:expected_file_infos) do
[
Results::StorageFileInfo.new(
status: "ok",
@@ -114,7 +114,7 @@ module Storages
context "with one outbound request returning not found", vcr: "one_drive/files_info_query_one_not_found" do
let(:file_ids) { %w[01AZJL5PJTICED3C5YSVAY6NWTBNA2XERU not_existent] }
- let(:file_infos) do
+ let(:expected_file_infos) do
[
Results::StorageFileInfo.new(
status: "ok",
diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rb
index 8e436d5971d..6185a1a2ba9 100644
--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rb
+++ b/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rb
@@ -46,7 +46,7 @@ module Storages
context "with an empty array of file ids" do
let(:file_ids) { [] }
- let(:file_infos) { [] }
+ let(:expected_file_infos) { [] }
it_behaves_like "adapter files_info_query: successful list response"
end
@@ -60,7 +60,7 @@ module Storages
#{drive_id}||01ANJ53W5UJK2CQO6IY5HLBVYBVNJ4TKHZ
]
end
- let(:file_infos) do
+ let(:expected_file_infos) do
[
Results::StorageFileInfo.new(
status: "ok",
@@ -116,7 +116,7 @@ module Storages
context "with one outbound request returning not found", vcr: "share_point/files_info_query_one_not_found" do
let(:drive_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY87vnZ6fgfvQanZHX-XCAyw" }
let(:file_ids) { %W[#{drive_id}||01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS #{drive_id}||not_existent] }
- let(:file_infos) do
+ let(:expected_file_infos) do
[
Results::StorageFileInfo.new(
status: "ok",
diff --git a/modules/storages/spec/support/shared_examples_for_storage_providers/files_info_query_examples.rb b/modules/storages/spec/support/shared_examples_for_storage_providers/files_info_query_examples.rb
index 0459d26afc5..ef5f6d260ed 100644
--- a/modules/storages/spec/support/shared_examples_for_storage_providers/files_info_query_examples.rb
+++ b/modules/storages/spec/support/shared_examples_for_storage_providers/files_info_query_examples.rb
@@ -52,8 +52,7 @@ RSpec.shared_examples_for "adapter files_info_query: successful list response" d
response = result.value!
expect(response).to be_an(Array)
- response.each { expect(it).to be_a(Storages::Adapters::Results::StorageFileInfo) }
- expect(response.size).to eq(file_infos.size)
- expect(response).to eq(file_infos)
+ expect(response).to all(be_a(Storages::Adapters::Results::StorageFileInfo))
+ expect(response).to eq(expected_file_infos)
end
end