Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

use consistent naming

as-op8ca51ff77b6e
diff --git a/app/models/work_package/pdf_export/export/wp/attributes.rb b/app/models/work_package/pdf_export/export/wp/attributes.rb
index 1253d5e6ba9..dd4e0a8f51e 100644
--- a/app/models/work_package/pdf_export/export/wp/attributes.rb
+++ b/app/models/work_package/pdf_export/export/wp/attributes.rb
@@ -140,7 +140,7 @@ module WorkPackage::PDFExport::Export::Wp::Attributes
current_part = { type: :attribute, list: [] }
parts = [current_part]
group.attributes.each do |form_key|
- next if skip_attribute?(form_key, work_package)
+ next unless show_attribute?(form_key, work_package)
if allowed_long_text_custom_field?(form_key, work_package)
cf = form_key_to_custom_field(form_key)
@@ -160,8 +160,8 @@ module WorkPackage::PDFExport::Export::Wp::Attributes
parts
end
- def skip_attribute?(form_key, work_package)
- !CustomField.custom_field_attribute?(form_key) && !user_allowed_view_attribute?(work_package, form_key)
+ def show_attribute?(form_key, work_package)
+ CustomField.custom_field_attribute?(form_key) || user_allowed_view_attribute?(work_package, form_key)
end
def allowed_long_text_custom_field?(form_key, work_package)