Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#67516] removed unused i18n keys

Eric Schubert9003d9bcf2cc
diff --git a/modules/storages/config/locales/en.yml b/modules/storages/config/locales/en.yml
index 653cd3e3ddb..ebee1159ee5 100644
--- a/modules/storages/config/locales/en.yml
+++ b/modules/storages/config/locales/en.yml
@@ -185,8 +185,6 @@ en:
not_found: The destination folder %{folder} could not be found on %{storage_name}.
storages:
buttons:
- complete_without_setup: Complete without it
- done_complete_setup: Done, complete setup
done_continue: Done, continue
open_storage: Open file storage
replace_oauth_application: Replace OpenProject OAuth
diff --git a/modules/storages/spec/features/storages/admin/create_storage_spec.rb b/modules/storages/spec/features/storages/admin/create_storage_spec.rb
index 76c107c9c76..5f4248341d5 100644
--- a/modules/storages/spec/features/storages/admin/create_storage_spec.rb
+++ b/modules/storages/spec/features/storages/admin/create_storage_spec.rb
@@ -159,7 +159,7 @@ RSpec.describe "Admin Create a new file storage",
expect(application_password_input.value).to be_empty
# Clicking submit with application password empty should show an error
- click_on("Done, complete setup")
+ click_on("Finish setup")
expect(page).to have_text("Application password can't be blank.")
# Test the error path for an invalid storage password.
@@ -170,7 +170,7 @@ RSpec.describe "Admin Create a new file storage",
expect(automatically_managed_switch).to be_checked
fill_in "Application password", with: "1234567890"
# Clicking submit with application password empty should show an error
- click_on("Done, complete setup")
+ click_on("Finish setup")
expect(page).to have_text("Application password is not valid.")
# Test the happy path for a valid storage password.
@@ -180,7 +180,7 @@ RSpec.describe "Admin Create a new file storage",
automatically_managed_switch = page.find('[name="storages_nextcloud_storage[automatic_management_enabled]"]')
expect(automatically_managed_switch).to be_checked
fill_in "Application password", with: "1234567890"
- click_on("Done, complete setup")
+ click_on("Finish setup")
end
expect(page).to have_current_path(edit_admin_settings_storage_path(Storages::Storage.last))
@@ -238,7 +238,7 @@ RSpec.describe "Admin Create a new file storage",
expect(application_password_input.value).to be_empty
# Clicking submit with application password empty should show an error
- click_on("Done, complete setup")
+ click_on("Finish setup")
expect(page).to have_text("Application password can't be blank.")
# Test the error path for an invalid storage password.
@@ -249,7 +249,7 @@ RSpec.describe "Admin Create a new file storage",
expect(automatically_managed_switch).to be_checked
fill_in "Application password", with: "1234567890"
# Clicking submit with application password empty should show an error
- click_on("Done, complete setup")
+ click_on("Finish setup")
expect(page).to have_text("Application password is not valid.")
# Test the happy path for a valid storage password.
@@ -259,7 +259,7 @@ RSpec.describe "Admin Create a new file storage",
automatically_managed_switch = page.find('[name="storages_nextcloud_storage[automatic_management_enabled]"]')
expect(automatically_managed_switch).to be_checked
fill_in "Application password", with: "1234567890"
- click_on("Done, complete setup")
+ click_on("Finish setup")
end
expect(page).to have_current_path(edit_admin_settings_storage_path(Storages::Storage.last))
diff --git a/modules/storages/spec/features/storages/admin/edit_storage_spec.rb b/modules/storages/spec/features/storages/admin/edit_storage_spec.rb
index e2972c47f44..679944e07c4 100644
--- a/modules/storages/spec/features/storages/admin/edit_storage_spec.rb
+++ b/modules/storages/spec/features/storages/admin/edit_storage_spec.rb
@@ -194,7 +194,7 @@ RSpec.describe "Admin Edit File storage",
expect(application_password_input.value).to be_empty
# Clicking submit with application password empty should show an error
- click_on("Done, complete setup")
+ click_on("Finish setup")
expect(page).to have_text("Application password can't be blank.")
# Test the error path for an invalid storage password.
@@ -205,7 +205,7 @@ RSpec.describe "Admin Edit File storage",
expect(automatically_managed_switch).to be_checked
fill_in "Application password", with: "1234567890"
# Clicking submit with application password empty should show an error
- click_on("Done, complete setup")
+ click_on("Finish setup")
expect(page).to have_text("Application password is not valid.")
# Test the happy path for a valid storage password.
@@ -215,7 +215,7 @@ RSpec.describe "Admin Edit File storage",
automatically_managed_switch = page.find('[name="storages_nextcloud_storage[automatic_management_enabled]"]')
expect(automatically_managed_switch).to be_checked
fill_in "Application password", with: "1234567890"
- click_on("Done, complete setup")
+ click_on("Finish setup")
end
expect(page).to have_test_selector("label-managed-project-folders-status", text: "Active")