Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

obey rubocop rule: Assignment Branch Condition size

as-op9a3220cf730f
diff --git a/app/models/work_package/pdf_export/work_package_list_to_pdf.rb b/app/models/work_package/pdf_export/work_package_list_to_pdf.rb
index 0d6fab6f733..349158d4ce6 100644
--- a/app/models/work_package/pdf_export/work_package_list_to_pdf.rb
+++ b/app/models/work_package/pdf_export/work_package_list_to_pdf.rb
@@ -83,8 +83,15 @@ class WorkPackage::PDFExport::WorkPackageListToPdf < WorkPackage::Exports::Query
end
def export!
- file = render_work_packages query.results.work_packages
- success(file)
+ handle_export_errors do
+ success(render_work_packages(query.results.work_packages))
+ end
+ end
+
+ private
+
+ def handle_export_errors
+ yield
rescue Prawn::Errors::CannotFit
error(I18n.t(:error_pdf_export_too_many_columns))
rescue Exports::PDF::Components::Gantt::InvalidDateRangeError => e
@@ -94,8 +101,6 @@ class WorkPackage::PDFExport::WorkPackageListToPdf < WorkPackage::Exports::Query
error(I18n.t(:error_pdf_failed_to_export, error: e.message))
end
- private
-
def setup_page!
self.pdf = get_pdf