Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

avoid using CTE in subquery which leads to full wp table scan

ulfertsa2faa3bd23f9
diff --git a/app/models/work_packages/scopes/allowed_to.rb b/app/models/work_packages/scopes/allowed_to.rb
index 51da208c82e..4461ef32940 100644
--- a/app/models/work_packages/scopes/allowed_to.rb
+++ b/app/models/work_packages/scopes/allowed_to.rb
@@ -45,13 +45,11 @@ module WorkPackages::Scopes
elsif user.anonymous?
where(project_id: Project.allowed_to(user, permissions))
else
- allowed_via_wp_membership = allowed_to_member_relation(user, permissions).select(arel_table[:id]).arel
- allowed_via_project_membership = Project.unscoped.allowed_to(user, permissions).select(:id)
+ allowed_via_wp_membership = allowed_to_member_relation(user, permissions)
+ allowed_via_project_membership = Project.unscoped.allowed_to(user, permissions)
- with(
- allowed_work_packages: allowed_via_wp_membership,
- allowed_projects: allowed_via_project_membership
- ).where("work_packages.project_id IN (SELECT id FROM allowed_projects) OR work_packages.id IN (SELECT id FROM allowed_work_packages)")
+ where(project_id: allowed_via_project_membership.select(:id))
+ .or(where(id: allowed_via_wp_membership.select(arel_table[:id])))
end
end
@@ -72,7 +70,6 @@ module WorkPackages::Scopes
.joins(member_roles: :role)
.joins(allowed_to_role_permission_join(permissions))
.where(member_conditions(user))
- .select(arel_table[:id])
end
def allowed_to_enabled_module_join(permissions) # rubocop:disable Metrics/AbcSize