OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
[#59359] amended feature spec expectations
Eric Schubertab2d9d1aaa35
diff --git a/spec/features/admin/custom_fields/projects/create_in_section_spec.rb b/spec/features/admin/custom_fields/projects/create_in_section_spec.rbindex 6eaf3a77cfc..ba05aa847ae 100644--- a/spec/features/admin/custom_fields/projects/create_in_section_spec.rb+++ b/spec/features/admin/custom_fields/projects/create_in_section_spec.rb@@ -75,14 +75,13 @@ RSpec.describe "Create project custom fields in sections", :js doclick_on("Save")- # redirects to the overview page- # the tab parameter is set as the redirect originates from the former custom field controller but does not have an effect- expect(page).to have_current_path(admin_settings_project_custom_fields_path(tab: "ProjectCustomField"))-- expect(page).to have_text("New custom field")+ expect(page).to have_text("Successful creation")latest_custom_field = ProjectCustomField.reorder(created_at: :asc).last+ expect(page).to have_current_path(admin_settings_project_custom_field_path(latest_custom_field))+ expect(page).to have_text("New custom field")+expect(latest_custom_field.name).to eq("New custom field")expect(latest_custom_field.admin_only).to be(true)expect(latest_custom_field.project_custom_field_section).to eq(section_for_select_fields)@@ -96,12 +95,12 @@ RSpec.describe "Create project custom fields in sections", :js doclick_on("Save")- # redirects to the overview page- # the tab parameter is set as the redirect originates from the former custom field controller but does not have an effect- expect(page).to have_current_path(admin_settings_project_custom_fields_path(tab: "ProjectCustomField"))+ expect(page).to have_text("Successful creation")latest_custom_field = ProjectCustomField.reorder(created_at: :asc).last+ expect(page).to have_current_path(admin_settings_project_custom_field_path(latest_custom_field))+expect(latest_custom_field.name).to eq("New custom field")expect(latest_custom_field.project_custom_field_section).to eq(section_for_multi_select_fields)end@@ -157,11 +156,10 @@ RSpec.describe "Create project custom fields in sections", :js doclick_on("Save")- # redirects to the overview page- # the tab parameter is set as the redirect originates from the- # former custom field controller but does not have an effect- expect(page).to have_current_path(admin_settings_project_custom_fields_path(tab: "ProjectCustomField"))+ expect(page).to have_text("Successful creation")+ created = ProjectCustomField.find_by_name("New calculated value custom field")+ expect(page).to have_current_path(admin_settings_project_custom_field_path(created))expect(page).to have_text("New calculated value custom field")endenddiff --git a/spec/features/admin/custom_fields/shared_custom_field_expectations.rb b/spec/features/admin/custom_fields/shared_custom_field_expectations.rbindex 949a69c2e80..ef6caf19975 100644--- a/spec/features/admin/custom_fields/shared_custom_field_expectations.rb+++ b/spec/features/admin/custom_fields/shared_custom_field_expectations.rb@@ -80,9 +80,6 @@ RSpec.shared_examples_for "list custom fields" do |type|expect(page).to have_text("Successful creation")- click_on "Operating System"- wait_for_reload-expect(page).to have_field("custom_field_multi_value", checked: true)expect(page).to have_css(".custom-option-row", count: 3)diff --git a/spec/features/admin/custom_fields/work_packages/hierarchy_spec.rb b/spec/features/admin/custom_fields/work_packages/hierarchy_spec.rbindex bc073d0f726..69f85dbe380 100644--- a/spec/features/admin/custom_fields/work_packages/hierarchy_spec.rb+++ b/spec/features/admin/custom_fields/work_packages/hierarchy_spec.rb@@ -49,22 +49,17 @@ RSpec.describe "work package custom fields of type hierarchy", :js dofill_in "Name", with: hierarchy_nameclick_on "Save"- new_custom_field_page.expect_and_dismiss_flash(message: "Successful creation.")-- custom_field_index_page.expect_current_path("tab=WorkPackageCustomField")- expect(page).to have_list_item(hierarchy_name)-- # endregion-- # region Edit the details of the custom field+ expect(page).to have_text("Successful creation.")CustomField.find_by(name: hierarchy_name).tap do |custom_field|hierarchy_page.add_custom_field_state(custom_field)end-- click_on hierarchy_namehierarchy_page.expect_current_path+ # endregion++ # region Edit the details of the custom field+expect(page).to have_test_selector("op-custom-fields--new-hierarchy-banner")expect(page).to have_css(".PageHeader-title", text: hierarchy_name)diff --git a/spec/features/admin/custom_fields/work_packages/user_spec.rb b/spec/features/admin/custom_fields/work_packages/user_spec.rbindex 4ecf49f0558..7d9b9e3b4eb 100644--- a/spec/features/admin/custom_fields/work_packages/user_spec.rb+++ b/spec/features/admin/custom_fields/work_packages/user_spec.rb@@ -53,13 +53,10 @@ RSpec.describe "User custom fields edit", :js donew_cf_page.expect_and_dismiss_flash(message: "Successful creation.")- # Expect field to be created- index_cf_page.expect_current_path("tab=WorkPackageCustomField")- expect(page).to have_list_item("My User CF")+ cf = CustomField.last+ expect(page).to have_current_path(edit_custom_field_path(cf))# Edit again- click_on "My User CF"-expect(page).to have_no_field("custom_field_custom_options_attributes_0_value")fill_in "Name", with: "My User CF (edited)"@@ -68,8 +65,9 @@ RSpec.describe "User custom fields edit", :js donew_cf_page.expect_and_dismiss_flash(message: "Successful update.")# Expect field to be saved+ cf.reload+expect(page).to have_css(".PageHeader-title", text: "My User CF (edited)")- cf = CustomField.lastexpect(cf.name).to eq("My User CF (edited)")endend