OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
[#64348] Spec for #usable_custom_field_references_for_formula
Tobias Dillmannb0b3f3ad4101
diff --git a/spec/models/custom_field/calculated_value_spec.rb b/spec/models/custom_field/calculated_value_spec.rbindex d32dca547b9..e0978fa186d 100644--- a/spec/models/custom_field/calculated_value_spec.rb+++ b/spec/models/custom_field/calculated_value_spec.rb@@ -33,6 +33,43 @@ require "spec_helper"RSpec.describe CustomField::CalculatedValue, with_flag: { calculated_value_project_attribute: true } dosubject(:custom_field) { create(:calculated_value_project_custom_field, formula: "1 + 1") }+ describe "#usable_custom_field_references_for_formula" do+ let!(:int) { create(:project_custom_field, :integer, default_value: 4, is_for_all: true) }+ let!(:float) { create(:project_custom_field, :float, default_value: 5.5, is_for_all: true) }+ let!(:other_calculated_value) { create(:calculated_value_project_custom_field, formula: "2 + 2", is_for_all: true) }++ current_user { create(:admin) }++ context "with permission to see all custom fields" do+ it "returns custom fields with formats that can be used in formulas" do+ expect(subject.usable_custom_field_references_for_formula).to contain_exactly(int, float, other_calculated_value)+ end++ it "excludes custom field formats that are not usable in formulas" do+ text = create(:project_custom_field, :text, default_value: "txt", is_for_all: true)+ expect(subject.usable_custom_field_references_for_formula).not_to include(text)+ end+ end++ context "with insufficient permission to see some custom fields" do+ let(:project_with_permission) { create(:project) }+ let(:project_without_permission) { create(:project) }+ let(:user) { create(:user, member_with_permissions: { project_with_permission => [:view_project_attributes] }) }++ let!(:int) { create(:project_custom_field, :integer, default_value: 4, projects: [project_with_permission]) }+ let!(:float) { create(:project_custom_field, :float, default_value: 5.5, projects: [project_with_permission]) }+ let!(:other_calculated_value) do+ create(:calculated_value_project_custom_field, formula: "2 + 2", projects: [project_without_permission])+ end++ current_user { user }++ it "returns only custom fields that the user has permission to see" do+ expect(subject.usable_custom_field_references_for_formula).to contain_exactly(int, float)+ end+ end+ end+describe "#formula=" dolet!(:int) { create(:project_custom_field, :integer, default_value: 2, is_for_all: true) }let!(:float) { create(:project_custom_field, :float, default_value: 3.5, is_for_all: true) }@@ -118,6 +155,12 @@ RSpec.describe CustomField::CalculatedValue, with_flag: { calculated_value_projeit_behaves_like "invalid formula", "contains invalid characters."end+ context "with a formula containing references to custom fields without pattern-mustaches" do+ let(:formula) { "100 * cf_3" }++ it_behaves_like "invalid formula", "contains invalid characters."+ end+context "with a formula that is not a valid equation" dolet(:formula) { "1 / + - 3" }