OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Trigger change detection after adding widget
Oliver Güntherb3e48357e8df
diff --git a/frontend/src/app/shared/components/grids/grid/add-widget.service.ts b/frontend/src/app/shared/components/grids/grid/add-widget.service.tsindex ea212eec3bb..5e5be719a61 100644--- a/frontend/src/app/shared/components/grids/grid/add-widget.service.ts+++ b/frontend/src/app/shared/components/grids/grid/add-widget.service.ts@@ -1,4 +1,5 @@import {+ ChangeDetectorRef, inject,Injectable,Injector,OnDestroy,@@ -19,20 +20,22 @@ import { GridResource } from 'core-app/features/hal/resources/grid-resource';@Injectable()export class GridAddWidgetService implements OnDestroy {+ readonly opModalService = inject(OpModalService);+ readonly injector = inject(Injector);+ readonly halResource = inject(HalResourceService);+ readonly layout = inject(GridAreaService);+ readonly drag = inject(GridDragAndDropService);+ readonly move = inject(GridMoveService);+ readonly resize = inject(GridResizeService);+ readonly i18n = inject(I18nService);+ readonly cdRef = inject(ChangeDetectorRef);+text = { add: this.i18n.t('js.grid.add_widget') };private boundListener = this.createNewWidget.bind(this);- constructor(- readonly opModalService:OpModalService,- readonly injector:Injector,- readonly halResource:HalResourceService,- readonly layout:GridAreaService,- readonly drag:GridDragAndDropService,- readonly move:GridMoveService,- readonly resize:GridResizeService,- readonly i18n:I18nService,- ) {++ constructor() {document.addEventListener('overview:addWidget', this.boundListener);}@@ -52,7 +55,7 @@ export class GridAddWidgetService implements OnDestroy {.select(area).then(async (widgetResource) => {if (this.layout.isGap(area)) {- this.addLine(area as GridGap);+ this.addLine(area);}const newArea = new GridWidgetArea(widgetResource);@@ -138,8 +141,9 @@ export class GridAddWidgetService implements OnDestroy {return this.layout.gridResource && this.layout.gridResource.updateImmediately;}- private createNewWidget():void {+ private async createNewWidget():Promise<void> {const newGap = new GridGap(1, 2, 1, 2, 'row');- void this.widget(newGap);+ await this.widget(newGap);+ this.cdRef.detectChanges();}}diff --git a/frontend/src/app/shared/components/grids/widgets/add/add.modal.ts b/frontend/src/app/shared/components/grids/widgets/add/add.modal.tsindex ac5b4ed6c7d..f220a97a782 100644--- a/frontend/src/app/shared/components/grids/widgets/add/add.modal.ts+++ b/frontend/src/app/shared/components/grids/widgets/add/add.modal.ts@@ -27,7 +27,7 @@ export class AddGridWidgetModalComponent extends OpModalComponent implements OnIcancel_button: this.i18n.t('js.button_cancel'),};- public chosenWidget:WidgetRegistration;+ public chosenWidget?:WidgetRegistration;public eeShowBanners = false;