OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
Fix cost entry spec
Klaus Zandersbc89c897e987
diff --git a/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb b/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rbindex 5936792cd94..52519fd9230 100644--- a/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb+++ b/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb@@ -1,3 +1,5 @@+# frozen_string_literal: true+#-- copyright# OpenProject is an open source project management software.# Copyright (C) the OpenProject GmbH@@ -36,10 +38,12 @@ RSpec.describe "API v3 Cost Entry resource" dolet(:current_user) docreate(:user, member_with_roles: { project => role })end- let(:cost_entry) { create(:cost_entry, project:) }+ let(:cost_entry) { create(:cost_entry, entity: work_package, user: entry_user) }let(:role) { create(:project_role, permissions:) }let(:permissions) { [:view_cost_entries] }let(:project) { create(:project) }+ let(:work_package) { create(:work_package, project:) }+ let(:entry_user) { create(:user) }subject(:response) { last_response }@@ -52,44 +56,44 @@ RSpec.describe "API v3 Cost Entry resource" dodescribe "cost_entries/:id" dolet(:get_path) { api_v3_paths.cost_entry cost_entry.id }- context "user can see cost entries" do- context "valid id" do+ context "when user can see cost entries" do+ context "with a valid id" doit "returns HTTP 200" do- expect(response.status).to be(200)+ expect(response).to have_http_status(200)endend- context "invalid id" do+ context "with an invalid id" dolet(:get_path) { api_v3_paths.cost_type "bogus" }it_behaves_like "not found"endend- context "user can only see own cost entries" do+ context "when user can only see own cost entries" dolet(:permissions) { [:view_own_cost_entries] }- context "cost entry is not his own" do+ context "when ost entry is not his own" doit_behaves_like "error response",403,"MissingPermission",I18n.t("api_v3.errors.code_403")end- context "cost entry is his own" do- let(:cost_entry) { create(:cost_entry, project:, user: current_user) }+ context "when cost entry is his own" do+ let(:entry_user) { current_user }it "returns HTTP 200" do- expect(response.status).to be(200)+ expect(response).to have_http_status(200)endendend- context "user has no cost entry permissions" do+ context "when user has no cost entry permissions" dolet(:permissions) { [] }describe "he can't even see own cost entries" do- let(:cost_entry) { create(:cost_entry, project:, user: current_user) }+ let(:entry_user) { current_user }it_behaves_like "error response",403,