Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#65532] removed more remnants of SharePoint naming

Eric Schubertcd84bc56d5e6
diff --git a/modules/storages/spec/common/storages/url_builder_spec.rb b/modules/storages/spec/common/storages/url_builder_spec.rb
index 85ca3f8df91..865a40bbf89 100644
--- a/modules/storages/spec/common/storages/url_builder_spec.rb
+++ b/modules/storages/spec/common/storages/url_builder_spec.rb
@@ -87,7 +87,7 @@ RSpec.describe Storages::UrlBuilder do
end
end
- context "if storage is of OneDrive/SharePoint provider type" do
+ context "if storage is of OneDrive provider type" do
let(:storage) { create(:one_drive_storage) }
it "returns the correct request URL" do
diff --git a/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb b/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb
index 4c9dc475338..b0305d57a7e 100644
--- a/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb
+++ b/modules/storages/spec/components/storages/admin/storage_row_component_spec.rb
@@ -93,8 +93,8 @@ RSpec.describe Storages::Admin::StorageRowComponent, type: :component do
end
end
- describe "OneDrive/SharePoint storage" do
- shared_examples "a OneDrive/SharePoint storage row" do
+ describe "OneDrive storage" do
+ shared_examples "a OneDrive storage row" do
it "render the storage name" do
expect(page).to have_link(storage.name, href: edit_admin_settings_storage_path(storage))
end
@@ -105,14 +105,14 @@ RSpec.describe Storages::Admin::StorageRowComponent, type: :component do
end
it "renders the storage provider" do
- expect(page).to have_test_selector("storage-provider", text: "OneDrive/SharePoint")
+ expect(page).to have_test_selector("storage-provider", text: "OneDrive")
end
end
context "with complete storage" do
shared_let(:storage) { create(:one_drive_sandbox_storage) }
- it_behaves_like "a OneDrive/SharePoint storage row"
+ it_behaves_like "a OneDrive storage row"
it "does not show an incomplete label" do
expect(page).not_to have_test_selector("label-incomplete")
@@ -122,7 +122,7 @@ RSpec.describe Storages::Admin::StorageRowComponent, type: :component do
context "with incomplete storage" do
shared_let(:storage) { create(:one_drive_storage) }
- it_behaves_like "a OneDrive/SharePoint storage row"
+ it_behaves_like "a OneDrive storage row"
it 'renders an "Incomplete" label' do
expect(page).to have_test_selector("label-incomplete", text: "Incomplete")
diff --git a/modules/storages/spec/features/storages/admin/create_storage_spec.rb b/modules/storages/spec/features/storages/admin/create_storage_spec.rb
index 0377675a998..b55d5f03176 100644
--- a/modules/storages/spec/features/storages/admin/create_storage_spec.rb
+++ b/modules/storages/spec/features/storages/admin/create_storage_spec.rb
@@ -279,12 +279,12 @@ RSpec.describe "Admin Create a new file storage",
within_test_selector("storages-select-provider-action-menu") do
expect(page).to have_css(".octicon-op-enterprise-addons")
- click_on("OneDrive/SharePoint")
+ click_on("OneDrive")
end
end
expect(page).to have_current_path(upsell_admin_settings_storages_path)
- wait_for { page }.to have_text("OneDrive/SharePoint integration")
+ wait_for { page }.to have_text("OneDrive integration")
end
end
@@ -296,16 +296,16 @@ RSpec.describe "Admin Create a new file storage",
within(".SubHeader") do
page.find_test_selector("storages-create-new-provider-button").click
- within_test_selector("storages-select-provider-action-menu") { click_on("OneDrive/SharePoint") }
+ within_test_selector("storages-select-provider-action-menu") { click_on("OneDrive") }
end
expect(page).to have_current_path(new_admin_settings_storage_path(provider: "one_drive"))
aggregate_failures "New provider view" do
# Page Header
- expect(page).to have_test_selector("storage-new-page-header--title", text: "New OneDrive/SharePoint storage")
+ expect(page).to have_test_selector("storage-new-page-header--title", text: "New OneDrive storage")
expect(page).to have_test_selector("storage-new-page-header--description",
- text: "Read our documentation on setting up a OneDrive/SharePoint " \
+ text: "Read our documentation on setting up a OneDrive " \
"file storage integration for more information.")
# General information
@@ -327,7 +327,7 @@ RSpec.describe "Admin Create a new file storage",
expect(page).not_to have_test_selector("label-storage_oauth_client_configured-status")
expect(page).to have_test_selector("storage-oauth-client-id-description",
text: "Allow OpenProject to access Azure data using OAuth " \
- "to connect OneDrive/Sharepoint.")
+ "to connect OneDrive.")
expect(page).to have_test_selector("storage-redirect-uri-description",
text: "Complete the setup with the correct URI redirection.")
end
@@ -351,7 +351,7 @@ RSpec.describe "Admin Create a new file storage",
wait_for { page }.to have_test_selector("label-name_configured-storage_tenant_drive_configured-status",
text: "Completed")
- expect(page).to have_test_selector("storage-description", text: "OneDrive/SharePoint - My OneDrive")
+ expect(page).to have_test_selector("storage-description", text: "OneDrive - My OneDrive")
end
aggregate_failures "Access Management" do
diff --git a/modules/storages/spec/features/storages/admin/edit_storage_spec.rb b/modules/storages/spec/features/storages/admin/edit_storage_spec.rb
index e6bc320e78c..6a0b9f2e211 100644
--- a/modules/storages/spec/features/storages/admin/edit_storage_spec.rb
+++ b/modules/storages/spec/features/storages/admin/edit_storage_spec.rb
@@ -395,7 +395,7 @@ RSpec.describe "Admin Edit File storage",
end
end
- context "with OneDrive/SharePoint Storage" do
+ context "with OneDrive Storage" do
let(:storage) { create(:one_drive_storage, :as_automatically_managed, name: "Test Drive") }
let(:oauth_client) { create(:oauth_client, integration: storage) }
@@ -408,14 +408,14 @@ RSpec.describe "Admin Edit File storage",
.within("#content")
.skipping("heading-order")
- expect(page).to have_test_selector("storage-new-page-header--title", text: "Test Drive (OneDrive/SharePoint)")
+ expect(page).to have_test_selector("storage-new-page-header--title", text: "Test Drive (OneDrive)")
aggregate_failures "Storage edit view" do
# General information
expect(page).to have_test_selector("storage-provider-label", text: "Storage provider")
expect(page).to have_test_selector("label-name_configured-storage_tenant_drive_configured-status",
text: "Completed")
- expect(page).to have_test_selector("storage-description", text: "OneDrive/SharePoint - Test Drive")
+ expect(page).to have_test_selector("storage-description", text: "OneDrive - Test Drive")
# OAuth client
expect(page).to have_test_selector("storage-oauth-client-label", text: "Azure OAuth")
@@ -432,8 +432,8 @@ RSpec.describe "Admin Edit File storage",
click_on "Save and continue"
end
- expect(page).to have_test_selector("storage-new-page-header--title", text: "My OneDrive (OneDrive/SharePoint)")
- expect(page).to have_test_selector("storage-description", text: "OneDrive/SharePoint - My OneDrive")
+ expect(page).to have_test_selector("storage-new-page-header--title", text: "My OneDrive (OneDrive)")
+ expect(page).to have_test_selector("storage-description", text: "OneDrive - My OneDrive")
# Update a storage - unhappy path
find_test_selector("storage-edit-host-button").click
@@ -505,7 +505,7 @@ RSpec.describe "Admin Edit File storage",
end
end
- context "with OneDrive/SharePoint Storage and not automatically managed" do
+ context "with OneDrive Storage and not automatically managed" do
let(:storage) { create(:one_drive_storage, :as_not_automatically_managed, name: "Cloud Storage") }
it "renders health status information but without health notifications for automatically managed folders" do
diff --git a/modules/storages/spec/features/storages/admin/project_storages_spec.rb b/modules/storages/spec/features/storages/admin/project_storages_spec.rb
index 1443a649d51..9aaadb7da30 100644
--- a/modules/storages/spec/features/storages/admin/project_storages_spec.rb
+++ b/modules/storages/spec/features/storages/admin/project_storages_spec.rb
@@ -329,7 +329,7 @@ RSpec.describe "Admin lists project mappings for a storage",
end
end
- context "with OneDrive/Sharepoint with AMPF enabled" do
+ context "with OneDrive with AMPF enabled" do
let(:storage) { create(:one_drive_storage_configured, :as_automatically_managed) }
let(:project_storage) { create(:project_storage, storage:) }
diff --git a/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb b/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb
index 14f0a85fb0c..17db7d8a901 100644
--- a/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb
+++ b/modules/storages/spec/lib/api/v3/storages/storages_representer_parsing_spec.rb
@@ -37,11 +37,11 @@ RSpec.describe API::V3::Storages::StorageRepresenter, "parsing" do
subject(:parsed) { representer.from_hash parsed_hash }
- describe "OneDrive/SharePoint" do
+ describe "OneDrive" do
let(:storage) { build_stubbed(:one_drive_storage) }
let(:parsed_hash) do
{
- "name" => "My SharePoint",
+ "name" => "My OneDrive",
"tenantId" => "e36f1dbc-fdae-427e-b61b-0d96ddfb81a4",
"_links" => {
"type" => {
@@ -53,7 +53,7 @@ RSpec.describe API::V3::Storages::StorageRepresenter, "parsing" do
context "with basic attributes" do
it "is parsed correctly" do
- expect(parsed).to have_attributes(name: "My SharePoint",
+ expect(parsed).to have_attributes(name: "My OneDrive",
tenant_id: "e36f1dbc-fdae-427e-b61b-0d96ddfb81a4",
provider_type: "Storages::OneDriveStorage")
diff --git a/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb b/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb
index bd0ac8a679e..ac82556cf45 100644
--- a/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb
+++ b/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb
@@ -334,7 +334,7 @@ RSpec.describe API::V3::Storages::StorageRepresenter, "rendering" do
end
end
- context "if file storage has provider type OneDrive/SharePoint" do
+ context "if file storage has provider type OneDrive" do
let(:storage) { build_stubbed(:one_drive_storage, oauth_client: oauth_client_credentials) }
it_behaves_like "common file storage properties"
@@ -347,7 +347,7 @@ RSpec.describe API::V3::Storages::StorageRepresenter, "rendering" do
end
end
- describe "properties (OneDrive/SharePoint only)" do
+ describe "properties (OneDrive only)" do
it_behaves_like "property", :tenantId do
let(:value) { storage.tenant_id }
end