Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

[#65740] Spec for grouped project phase PDF export

Tobias Dillmanne0b936a18e2a
diff --git a/spec/features/work_packages/export_spec.rb b/spec/features/work_packages/export_spec.rb
index 6c4ac1a655b..19c9a1b8978 100644
--- a/spec/features/work_packages/export_spec.rb
+++ b/spec/features/work_packages/export_spec.rb
@@ -74,6 +74,8 @@ RSpec.describe "work package export", :js, :selenium do
end
before do
+ login_as(current_user)
+
service_instance = instance_double(WorkPackages::Exports::ScheduleService)
allow(WorkPackages::Exports::ScheduleService)
.to receive(:new)
@@ -92,8 +94,6 @@ RSpec.describe "work package export", :js, :selenium do
query.column_names = query_columns
query.save!
-
- login_as(current_user)
end
RSpec::Matchers.define :has_mandatory_params do |expected|
@@ -423,6 +423,37 @@ RSpec.describe "work package export", :js, :selenium do
click_on I18n.t("export.dialog.submit")
expect(page).to have_button(I18n.t("export.dialog.submit")) # form not submitted, button is still there
end
+
+ context "when exporting grouped by project phase column (regression #65740)" do
+ let!(:project_phase_with_gates) do
+ create(:project_phase,
+ :with_gated_definition,
+ project: project,
+ start_date: Date.new(2024, 12, 1),
+ finish_date: Date.new(2024, 12, 13))
+ end
+ let!(:project_phase) do
+ create(:project_phase,
+ project:,
+ start_date: Date.new(2024, 12, 1),
+ finish_date: Date.new(2024, 12, 13))
+ end
+
+ let(:query) { create(:query, user: current_user, project:, group_by: "project_phase", name: "My custom query title") }
+ let(:export_type) { I18n.t("export.dialog.format.options.pdf.label") }
+ let(:export_sub_type) { I18n.t("export.dialog.pdf.export_type.options.table.label") }
+ let(:expected_params) { default_expected_params.merge({ pdf_export_type: "table", groupBy: "project_phase" }) }
+ let(:expected_columns) { %w[ID Subject Type Status Assignee Priority ProjectPhase] }
+
+ before do
+ wp1.update!(project_phase_definition_id: project_phase_with_gates.definition_id)
+ wp2.update!(project_phase_definition_id: project_phase.definition_id)
+ end
+
+ it "exports a pdf table" do
+ export!
+ end
+ end
end
context "as report" do
diff --git a/spec/models/work_packages/pdf_export/work_package_list_to_pdf_spec.rb b/spec/models/work_packages/pdf_export/work_package_list_to_pdf_spec.rb
index c0487b9a1c4..203fb78e0db 100644
--- a/spec/models/work_packages/pdf_export/work_package_list_to_pdf_spec.rb
+++ b/spec/models/work_packages/pdf_export/work_package_list_to_pdf_spec.rb
@@ -33,6 +33,7 @@ require "spec_helper"
RSpec.describe WorkPackage::PDFExport::WorkPackageListToPdf do
include Redmine::I18n
include PDFExportSpecUtils
+
shared_let(:type_standard) { create(:type_standard) }
shared_let(:type_bug) { create(:type_bug) }
shared_let(:list_custom_field) do
@@ -218,6 +219,43 @@ RSpec.describe WorkPackage::PDFExport::WorkPackageListToPdf do
"1/1", export_date_formatted, query.name
].join(" ")
end
+
+ context "when grouped by project phase column (regression #65740)" do
+ let(:user) { create(:admin) }
+ let!(:project_phase_with_gates) do
+ create(:project_phase, :with_gated_definition, project:)
+ end
+ let!(:project_phase) do
+ create(:project_phase, project:)
+ end
+ let(:query_attributes) { { group_by: "project_phase" } }
+ let(:column_names) { %w[id subject project_phase] }
+
+ before do
+ work_package_parent.update!(project_phase_definition_id: project_phase_with_gates.definition.id)
+ work_package_child.update!(project_phase_definition_id: project_phase.definition.id)
+ end
+
+ it "contains correct data" do
+ expected_pdf_strings = [
+ query.name,
+
+ project_phase_with_gates.name,
+ *column_titles - ["Project phase"],
+ work_package_parent.id.to_s,
+ work_package_parent.subject,
+
+ project_phase.name,
+ *column_titles - ["Project phase"],
+ work_package_child.id.to_s,
+ work_package_child.subject,
+
+ "1/1", export_date_formatted, query.name
+ ]
+
+ expect(pdf_strings).to eq(expected_pdf_strings.join(" "))
+ end
+ end
end
describe "grouped with sums" do