OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
FeatureDecision for Sharepoint and Renaming of namespaces (#19953)
Marcello Rochae9daa1ea51ec
diff --git a/.env.test.local.example b/.env.test.local.exampleindex 44a57195ff1..4a2b5ee689b 100644--- a/.env.test.local.example+++ b/.env.test.local.example@@ -49,11 +49,11 @@ ONE_DRIVE_TEST_OAUTH_CLIENT_SECRET=ONE_DRIVE_TEST_OAUTH_CLIENT_ACCESS_TOKEN=ONE_DRIVE_TEST_OAUTH_CLIENT_REFRESH_TOKEN=-SHARE_POINT_TEST_HOST=-SHARE_POINT_TEST_TENANT_ID=+SHAREPOINT_TEST_HOST=+SHAREPOINT_TEST_TENANT_ID=-SHARE_POINT_TEST_OAUTH_CLIENT_ID=-SHARE_POINT_TEST_OAUTH_CLIENT_SECRET=+SHAREPOINT_TEST_OAUTH_CLIENT_ID=+SHAREPOINT_TEST_OAUTH_CLIENT_SECRET=-SHARE_POINT_TEST_OAUTH_CLIENT_ACCESS_TOKEN=-SHARE_POINT_TEST_OAUTH_CLIENT_REFRESH_TOKEN=+SHAREPOINT_TEST_OAUTH_CLIENT_ACCESS_TOKEN=+SHAREPOINT_TEST_OAUTH_CLIENT_REFRESH_TOKEN=diff --git a/frontend/src/app/shared/components/storages/file-picker-modal/file-picker-modal.component.ts b/frontend/src/app/shared/components/storages/file-picker-modal/file-picker-modal.component.tsindex b6f70cff16a..ee0f9478391 100644--- a/frontend/src/app/shared/components/storages/file-picker-modal/file-picker-modal.component.ts+++ b/frontend/src/app/shared/components/storages/file-picker-modal/file-picker-modal.component.ts@@ -46,7 +46,7 @@ import { FileLinksResourceService } from 'core-app/core/state/file-links/file-liimport { isDirectory, storageLocaleString } from 'core-app/shared/components/storages/functions/storages.functions';import { StorageFilesResourceService } from 'core-app/core/state/storage-files/storage-files.service';import {- StorageFileListItem,+ StorageFileListItem, StorageFileListItemCheckbox,} from 'core-app/shared/components/storages/storage-file-list-item/storage-file-list-item';import {FilePickerBaseModalComponent,@@ -192,13 +192,19 @@ export class FilePickerModalComponent extends FilePickerBaseModalComponent {this.enterDirectoryCallback(file),false,this.tooltip(file),- {- selected: this.selection.has(file.id as string),- changeSelection: () => { this.changeSelection(file); },- },+ this.hasCheckbox(file),);}+ private hasCheckbox(file:IStorageFile):StorageFileListItemCheckbox|undefined {+ if (file.mimeType !== 'application/x-op-drive') {+ return {+ selected: this.selection.has(file.id as string),+ changeSelection: () => { this.changeSelection(file); }+ };+ } else { return; }+ }+private isAlreadyLinked(file:IStorageFile):boolean {const currentFileLinks = this.locals.fileLinks as IFileLink[];const found = currentFileLinks.find((a) => a.originData.id === file.id);diff --git a/frontend/src/app/shared/components/storages/functions/storages.functions.ts b/frontend/src/app/shared/components/storages/functions/storages.functions.tsindex 02db0057405..b0247056c5b 100644--- a/frontend/src/app/shared/components/storages/functions/storages.functions.ts+++ b/frontend/src/app/shared/components/storages/functions/storages.functions.ts@@ -33,10 +33,14 @@ import {} from 'core-app/shared/components/storages/icons.mapping';import { IHalResourceLink } from 'core-app/core/state/hal-resource';import { IFileLinkOriginData } from 'core-app/core/state/file-links/file-link.model';-import { nextcloud, oneDrive } from 'core-app/shared/components/storages/storages-constants.const';+import { nextcloud, oneDrive, sharepoint } from 'core-app/shared/components/storages/storages-constants.const';export function isDirectory(originData:IFileLinkOriginData):boolean {- return originData.mimeType === 'application/x-op-directory';+ return originData.mimeType === 'application/x-op-directory' || isDrive(originData);+}++function isDrive(originData:IFileLinkOriginData):boolean {+ return originData.mimeType === 'application/x-op-drive';}export function getIconForMimeType(mimeType?:string):IFileIcon {@@ -67,6 +71,7 @@ export function makeFilesCollectionLink(storageLink:IHalResourceLink, location:sconst storageTypeMap:Record<string, string> = {[nextcloud]: 'js.storages.types.nextcloud',[oneDrive]: 'js.storages.types.one_drive',+ [sharepoint]: 'js.storages.types.sharepoint',default: 'js.storages.types.default',};diff --git a/frontend/src/app/shared/components/storages/icons.mapping.ts b/frontend/src/app/shared/components/storages/icons.mapping.tsindex 3dd5a17557b..ec7cf973f6b 100644--- a/frontend/src/app/shared/components/storages/icons.mapping.ts+++ b/frontend/src/app/shared/components/storages/icons.mapping.ts@@ -29,7 +29,7 @@import { nextcloud } from 'core-app/shared/components/storages/storages-constants.const';export interface IFileIcon {- icon:'image1'|'movie'|'file-text'|'export-pdf-descr'|'file-doc'|'file-sheet'|'file-presentation'|'folder'|'ticket'+ icon:'image1'|'movie'|'file-text'|'export-pdf-descr'|'file-doc'|'file-sheet'|'file-presentation'|'folder'|'ticket'|'inbox'clazz:'pdf'|'img'|'txt'|'doc'|'sheet'|'presentation'|'form'|'primary'|'mov'|'default'}@@ -100,6 +100,7 @@ export const fileIconMappings:Record<string, IFileIcon> = {'video/3gpp-2': { icon: 'movie', clazz: 'mov' },'application/x-op-directory': { icon: 'folder', clazz: 'primary' },+ 'application/x-op-drive': { icon: 'inbox', clazz: 'primary' },default: { icon: 'ticket', clazz: 'default' },};diff --git a/frontend/src/app/shared/components/storages/storage-file-list-item/storage-file-list-item.ts b/frontend/src/app/shared/components/storages/storage-file-list-item/storage-file-list-item.tsindex 96a1a67e492..81a9be41e46 100644--- a/frontend/src/app/shared/components/storages/storage-file-list-item/storage-file-list-item.ts+++ b/frontend/src/app/shared/components/storages/storage-file-list-item/storage-file-list-item.ts@@ -31,7 +31,7 @@ import { TimezoneService } from 'core-app/core/datetime/timezone.service';import { IFileIcon } from 'core-app/shared/components/storages/icons.mapping';import { getIconForMimeType, isDirectory } from 'core-app/shared/components/storages/functions/storages.functions';-interface StorageFileListItemCheckbox {+export interface StorageFileListItemCheckbox {selected:boolean;changeSelection?:() => void;}diff --git a/frontend/src/app/shared/components/storages/storages-constants.const.ts b/frontend/src/app/shared/components/storages/storages-constants.const.tsindex df0634de8f6..05962a3a351 100644--- a/frontend/src/app/shared/components/storages/storages-constants.const.ts+++ b/frontend/src/app/shared/components/storages/storages-constants.const.ts@@ -1,6 +1,7 @@// Storage typesexport const nextcloud = 'urn:openproject-org:api:v3:storages:Nextcloud';export const oneDrive = 'urn:openproject-org:api:v3:storages:OneDrive';+export const sharepoint = 'urn:openproject-org:api:v3:storages:Sharepoint';// Storage authorization stateexport const storageConnected = 'urn:openproject-org:api:v3:storages:authorization:Connected';diff --git a/frontend/src/app/shared/components/storages/upload/storage-upload.service.ts b/frontend/src/app/shared/components/storages/upload/storage-upload.service.tsindex b52b2551560..3a77c1dae09 100644--- a/frontend/src/app/shared/components/storages/upload/storage-upload.service.ts+++ b/frontend/src/app/shared/components/storages/upload/storage-upload.service.ts@@ -34,7 +34,7 @@ import { HttpClient, HttpEvent } from '@angular/common/http';import { IUploadFile, OpUploadService } from 'core-app/core/upload/upload.service';import { IUploadStrategy } from 'core-app/shared/components/storages/upload/upload-strategy';import { NextcloudUploadStrategy } from 'core-app/shared/components/storages/upload/nextcloud-upload.strategy';-import { nextcloud, oneDrive } from 'core-app/shared/components/storages/storages-constants.const';+import { nextcloud, oneDrive, sharepoint } from 'core-app/shared/components/storages/storages-constants.const';import { OneDriveUploadStrategy } from 'core-app/shared/components/storages/upload/one-drive-upload.strategy';export interface IStorageFileUploadResponse {@@ -73,6 +73,9 @@ export class StorageUploadService extends OpUploadService {case oneDrive:this.uploadStrategy = new OneDriveUploadStrategy(this.http);break;+ case sharepoint:+ this.uploadStrategy = new OneDriveUploadStrategy(this.http);+ break;default:throw new Error('unknown storage type');}diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/base.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/base.rbsimilarity index 93%rename from modules/storages/app/common/storages/adapters/providers/share_point/base.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/base.rbindex af919210d59..2e314dc422a 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/base.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/base.rb@@ -31,12 +31,12 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointclass Baseinclude TaggedLogginginclude Dry::Monads::Result(Results::Error)- # @param storage [Storages::SharePointStorage]+ # @param storage [Storages::SharepointStorage]# @param auth_strategy [Result(Input::Strategy)]# @param input_data [Data]# @return [Success, Failure(Results::Error)]@@ -44,7 +44,7 @@ module Storagesnew(storage).call(auth_strategy:, input_data:)end- # @param storage [Storages::SharePointStorage]+ # @param storage [Storages::SharepointStorage]def initialize(storage)@storage = storageend@@ -66,7 +66,7 @@ module Storagesenddef split_identifier(location)- drive_id, item_id = location.to_s.split(SharePointStorage::IDENTIFIER_SEPARATOR)+ drive_id, item_id = location.to_s.split(SharepointStorage::IDENTIFIER_SEPARATOR){ drive_id:, location: Peripherals::ParentFolder.new(item_id || "/") }enddiff --git a/modules/storages/app/common/storages/adapters/providers/share_point/commands/create_folder_command.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/commands/create_folder_command.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/commands/create_folder_command.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/commands/create_folder_command.rbindex 0db70fc6895..618c8b9d361 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/commands/create_folder_command.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/commands/create_folder_command.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Commandsclass CreateFolderCommand < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/commands/delete_folder_command.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/commands/delete_folder_command.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/commands/delete_folder_command.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/commands/delete_folder_command.rbindex 55f0bb5d7ba..d584a45cc2e 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/commands/delete_folder_command.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/commands/delete_folder_command.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Commandsclass DeleteFolderCommand < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/oauth_configuration.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/oauth_configuration.rbsimilarity index 98%rename from modules/storages/app/common/storages/adapters/providers/share_point/oauth_configuration.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/oauth_configuration.rbindex af3c43b4c9c..20471725fbc 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/oauth_configuration.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/oauth_configuration.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module SharepointOAuthConfiguration = Providers::OneDrive::OAuthConfigurationendenddiff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/download_link_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/download_link_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/download_link_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/download_link_query.rbindex fe8d2996968..e7a248db633 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/download_link_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/download_link_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass DownloadLinkQuery < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/file_info_query.rbsimilarity index 96%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/file_info_query.rbindex b56f947b9eb..c183b66854c 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/file_info_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/file_info_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass FileInfoQuery < BaseFIELDS = %w[id name fileSystemInfo file folder size createdBy lastModifiedBy parentReference webUrl].freeze@@ -70,7 +70,7 @@ module Storagesendend- def userless_strategy = Registry.resolve("share_point.authentication.userless").call+ def userless_strategy = Registry.resolve("#{@storage}.authentication.userless").calldef storage_file_info(json, status: "ok", status_code: 200)StorageFileTransformer.new(site_name).transform_file_info({ status:, status_code: }.merge(json))diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/files_info_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/files_info_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/files_info_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/files_info_query.rbindex 7fea570acf0..415147f9859 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/files_info_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/files_info_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass FilesInfoQuery < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/files_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/files_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/files_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/files_query.rbindex af5d4c385b0..54599731668 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/files_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/files_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass FilesQuery < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/children_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/children_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/children_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/children_query.rbindex 31d197b006f..5bc697b05ff 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/children_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/children_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesmodule Internalclass ChildrenQuery < Basediff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/drive_item_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/drive_item_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/drive_item_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/drive_item_query.rbindex 3151062e7a7..0d1338c8cd5 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/drive_item_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/drive_item_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesmodule Internalclass DriveItemQuery < Basediff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/lists_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/lists_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/lists_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/lists_query.rbindex d2072e6dcdc..bf5ee7205f1 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/internal/lists_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/internal/lists_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesmodule Internalclass ListsQuery < Basediff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/open_file_link_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/open_file_link_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/open_file_link_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/open_file_link_query.rbindex 7c8117cdaa2..237958dda0d 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/open_file_link_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/open_file_link_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass OpenFileLinkQuery < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/open_storage_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/open_storage_query.rbsimilarity index 98%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/open_storage_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/open_storage_query.rbindex a01b55f39cd..e535106924e 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/open_storage_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/open_storage_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass OpenStorageQuery < Basedef call(**)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/queries/upload_link_query.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/upload_link_query.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/queries/upload_link_query.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/queries/upload_link_query.rbindex 0adedf90564..5403752db94 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/queries/upload_link_query.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/queries/upload_link_query.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Queriesclass UploadLinkQuery < Basedef call(auth_strategy:, input_data:)diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/share_point_contract.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/sharepoint_contract.rbsimilarity index 96%rename from modules/storages/app/common/storages/adapters/providers/share_point/share_point_contract.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/sharepoint_contract.rbindex 47b6362add3..598d4a0643c 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/share_point_contract.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/sharepoint_contract.rb@@ -31,8 +31,8 @@module Storagesmodule Adaptersmodule Providers- module SharePoint- class SharePointContract < ::ModelContract+ module Sharepoint+ class SharepointContract < ::ModelContractattribute :namevalidates :name, presence: true, length: { maximum: 255 }diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/share_point_registry.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/sharepoint_registry.rbsimilarity index 93%rename from modules/storages/app/common/storages/adapters/providers/share_point/share_point_registry.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/sharepoint_registry.rbindex 2e2e9176663..ef6f338cb97 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/share_point_registry.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/sharepoint_registry.rb@@ -31,8 +31,8 @@module Storagesmodule Adaptersmodule Providers- module SharePoint- SharePointRegistry = Dry::Container::Namespace.new("share_point") do+ module Sharepoint+ SharepointRegistry = Dry::Container::Namespace.new("sharepoint") donamespace("authentication") doregister(:userless, ->(use_cache = true) { Input::Strategy.build(key: :oauth_client_credentials, use_cache:) })register(:user_bound, ->(user, storage = nil) { Input::Strategy.build(key: :oauth_user_token, user:, storage:) })@@ -60,8 +60,8 @@ module Storagesendnamespace("contracts") do- register(:storage, SharePointContract)- register(:general_information, SharePointContract)+ register(:storage, SharepointContract)+ register(:general_information, SharepointContract)endnamespace("validators") dodiff --git a/modules/storages/app/common/storages/adapters/providers/share_point/storage_file_transformer.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/storage_file_transformer.rbsimilarity index 96%rename from modules/storages/app/common/storages/adapters/providers/share_point/storage_file_transformer.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/storage_file_transformer.rbindex 9fa48c30c5b..44744f283e8 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/storage_file_transformer.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/storage_file_transformer.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointclass StorageFileTransformerattr_reader :site_name@@ -112,13 +112,13 @@ module Storagesenddef compose_id(json)- "#{json.dig(:parentReference, :driveId)}#{SharePointStorage::IDENTIFIER_SEPARATOR}#{json[:id]}"+ "#{json.dig(:parentReference, :driveId)}#{SharepointStorage::IDENTIFIER_SEPARATOR}#{json[:id]}"enddef compose_parent_id(parent)item_id = parent[:path].ends_with?("root:") ? nil : parent[:id]- "#{parent[:driveId]}#{SharePointStorage::IDENTIFIER_SEPARATOR}#{item_id}"+ "#{parent[:driveId]}#{SharepointStorage::IDENTIFIER_SEPARATOR}#{item_id}"endendenddiff --git a/modules/storages/app/common/storages/adapters/providers/share_point/storage_wizard.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/storage_wizard.rbsimilarity index 99%rename from modules/storages/app/common/storages/adapters/providers/share_point/storage_wizard.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/storage_wizard.rbindex 38c490e2cc7..dfecea8f3e3 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/storage_wizard.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/storage_wizard.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointclass StorageWizard < Wizardstep :general_information, completed_if: ->(storage) { storage.name.present? }diff --git a/modules/storages/app/common/storages/adapters/providers/share_point/validators/authentication_validator.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/validators/authentication_validator.rbsimilarity index 91%rename from modules/storages/app/common/storages/adapters/providers/share_point/validators/authentication_validator.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/validators/authentication_validator.rbindex a59b7edde3c..a74dc587f6c 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/validators/authentication_validator.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/validators/authentication_validator.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Validatorsclass AuthenticationValidator < ConnectionValidators::BaseValidatorGroupdef self.key = :authentication@@ -58,13 +58,13 @@ module Storagesenddef user_bound_request- Registry["share_point.queries.user"].call(storage: @storage, auth_strategy:).either(+ Registry["sharepoint.queries.user"].call(storage: @storage, auth_strategy:).either(->(_) { pass_check(:user_bound_request) },-> { fail_check(:user_bound_request, :"sp_oauth_request_#{it.code}") })end- def auth_strategy = Registry["share_point.authentication.user_bound"].call(@user, @storage)+ def auth_strategy = Registry["sharepoint.authentication.user_bound"].call(@user, @storage)endendenddiff --git a/modules/storages/app/common/storages/adapters/providers/share_point/validators/connection_validator.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/validators/connection_validator.rbsimilarity index 98%rename from modules/storages/app/common/storages/adapters/providers/share_point/validators/connection_validator.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/validators/connection_validator.rbindex bd6b92720b0..40607b4d321 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/validators/connection_validator.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/validators/connection_validator.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Validatorsclass ConnectionValidator < ConnectionValidators::BaseConnectionValidatorregister_group StorageConfigurationValidatordiff --git a/modules/storages/app/common/storages/adapters/providers/share_point/validators/storage_configuration_validator.rb b/modules/storages/app/common/storages/adapters/providers/sharepoint/validators/storage_configuration_validator.rbsimilarity index 97%rename from modules/storages/app/common/storages/adapters/providers/share_point/validators/storage_configuration_validator.rbrename to modules/storages/app/common/storages/adapters/providers/sharepoint/validators/storage_configuration_validator.rbindex b4f591c4a64..c415e525460 100644--- a/modules/storages/app/common/storages/adapters/providers/share_point/validators/storage_configuration_validator.rb+++ b/modules/storages/app/common/storages/adapters/providers/sharepoint/validators/storage_configuration_validator.rb@@ -31,7 +31,7 @@module Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule Validatorsclass StorageConfigurationValidator < ConnectionValidators::BaseValidatorGroupdef self.key = :base_configuration@@ -121,7 +121,7 @@ module Storagesendend- def auth_strategy = Registry["share_point.authentication.userless"].call+ def auth_strategy = Registry["sharepoint.authentication.userless"].calldef error_payload@error_payload ||= query_result.either(->(_) { {} }, -> { MultiJson.load(it.payload, symbolize_keys: true) })diff --git a/modules/storages/app/common/storages/adapters/registry.rb b/modules/storages/app/common/storages/adapters/registry.rbindex 8830aee615b..a03cac6bbc5 100644--- a/modules/storages/app/common/storages/adapters/registry.rb+++ b/modules/storages/app/common/storages/adapters/registry.rb@@ -62,7 +62,7 @@ module Storages# Need to make this dynamic to ease new providers to be registeredimport Providers::Nextcloud::NextcloudRegistryimport Providers::OneDrive::OneDriveRegistry- import Providers::SharePoint::SharePointRegistry+ import Providers::Sharepoint::SharepointRegistryendendenddiff --git a/modules/storages/app/contracts/storages/file_links/create_contract.rb b/modules/storages/app/contracts/storages/file_links/create_contract.rbindex 77328891b8b..b546e69c65a 100644--- a/modules/storages/app/contracts/storages/file_links/create_contract.rb+++ b/modules/storages/app/contracts/storages/file_links/create_contract.rb@@ -36,7 +36,6 @@ class Storages::FileLinks::CreateContract < ModelContractattribute :container_typeattribute :origin_id- validates :origin_id, length: 1..100attribute :origin_namevalidates :origin_name, presence: trueattribute :origin_created_by_namediff --git a/modules/storages/app/models/storages/share_point_storage.rb b/modules/storages/app/models/storages/sharepoint_storage.rbsimilarity index 88%rename from modules/storages/app/models/storages/share_point_storage.rbrename to modules/storages/app/models/storages/sharepoint_storage.rbindex 1975495b15b..43bb7e0b020 100644--- a/modules/storages/app/models/storages/share_point_storage.rb+++ b/modules/storages/app/models/storages/sharepoint_storage.rb@@ -29,8 +29,8 @@#++module Storages- class SharePointStorage < Storage- IDENTIFIER_SEPARATOR = "||"+ class SharepointStorage < Storage+ IDENTIFIER_SEPARATOR = ":"PROVIDER_FIELDS_DEFAULTS = {automatically_managed: false,@@ -42,10 +42,10 @@ module Storages# For now SharePoint is visible only in tests.# This is to prevent it from being shown in the UI, as it is not ready yet.def self.visible?- Rails.env.local?+ OpenProject::FeatureDecisions.sharepoint_storage_active? || Rails.env.local?end- def self.short_provider_name = :share_point+ def self.short_provider_name = :sharepointdef self.non_confidential_provider_fieldssuper + %i[tenant_id]@@ -69,7 +69,12 @@ module Storages@uri ||= URI("https://graph.microsoft.com").normalizeend- def oauth_configuration = Adapters::Providers::SharePoint::OAuthConfiguration.new(self)+ def connect_src+ host_uri = URI(host)+ ["#{host_uri.scheme}://#{host_uri.host}"]+ end++ def oauth_configuration = Adapters::Providers::Sharepoint::OAuthConfiguration.new(self)def provider_fields_defaultsPROVIDER_FIELDS_DEFAULTSdiff --git a/modules/storages/app/models/storages/storage.rb b/modules/storages/app/models/storages/storage.rbindex 727eb38c706..d4cd1b00270 100644--- a/modules/storages/app/models/storages/storage.rb+++ b/modules/storages/app/models/storages/storage.rb@@ -199,7 +199,7 @@ module Storagesenddef provider_type_share_point?- is_a?(SharePointStorage)+ is_a?(SharepointStorage)enddef health_reason_identifierdiff --git a/modules/storages/config/locales/en.yml b/modules/storages/config/locales/en.ymlindex 284a9635906..ee6c0ea7d55 100644--- a/modules/storages/config/locales/en.yml+++ b/modules/storages/config/locales/en.yml@@ -22,7 +22,7 @@ en:project_folder_mode: Project folder modestorage: Storagestorage_url: Storage URL- storages/share_point_storage:+ storages/sharepoint_storage:host: Sharepoint Site URLlibrary: Library IDname: Name@@ -196,10 +196,10 @@ en:oauth_client_incomplete:nextcloud: Allow OpenProject to access Nextcloud data using OAuth.one_drive: Allow OpenProject to access Azure data using OAuth to connect OneDrive.- share_point: Allow OpenProject to access SharePoint data using OAuth.+ sharepoint: Allow OpenProject to access SharePoint data using OAuth.redirect_uri_incomplete:one_drive: Complete the setup with the correct URI redirection.- share_point: Complete the setup with the correct URI redirection.+ sharepoint: Complete the setup with the correct URI redirection.confirm_replace_oauth_application: This action will reset the current OAuth credentials. After confirming you will have to reenter the credentials at the storage provider and all remote users will have to authorize against OpenProject again. Are you sure you want to proceed?confirm_replace_oauth_client: This action will reset the current OAuth credentials. After confirming you will have to enter new credentials from the storage provider and all users will have to authorize against %{provider_type} again. Are you sure you want to proceed?delete_warning:@@ -396,7 +396,7 @@ en:setting_up_additional_storages_non_admin: Administrators can set up additional file storages in Administration / File storages.setting_up_storages: For setting up file storages, please visitsetting_up_storages_non_admin: Administrators can set up file storages in Administration / File storages.- share_point:+ sharepoint:application_link_text: SharePoint siteintegration: SharePoint Administration / OpenProjectoauth_configuration: Copy these values from the desired application in the %{application_link_text}.@@ -502,7 +502,7 @@ en:label_oauth_client_secret: Azure OAuth Client Secret Valuename: OneDrivename_placeholder: e.g. OneDrive- share_point:+ sharepoint:label_oauth_client_id: Azure OAuth Application (client) IDlabel_oauth_client_secret: Azure OAuth Client Secret Valuename: SharePointdiff --git a/modules/storages/config/locales/js-en.yml b/modules/storages/config/locales/js-en.ymlindex 1c35ee5ca1b..ad0af627c72 100644--- a/modules/storages/config/locales/js-en.yml+++ b/modules/storages/config/locales/js-en.yml@@ -18,7 +18,8 @@ en:types:nextcloud: "Nextcloud"- one_drive: "OneDrive/SharePoint"+ one_drive: "OneDrive"+ sharepoint: "SharePoint"default: "Storage"information:diff --git a/modules/storages/lib/api/v3/storages/storage_representer.rb b/modules/storages/lib/api/v3/storages/storage_representer.rbindex 4eb134024ef..d0a510fcf0b 100644--- a/modules/storages/lib/api/v3/storages/storage_representer.rb+++ b/modules/storages/lib/api/v3/storages/storage_representer.rb@@ -40,12 +40,12 @@ module API::V3::StoragesURN_STORAGE_TYPE_NEXTCLOUD = "#{::API::V3::URN_PREFIX}storages:Nextcloud".freezeURN_STORAGE_TYPE_ONE_DRIVE = "#{::API::V3::URN_PREFIX}storages:OneDrive".freeze- URN_STORAGE_TYPE_SHARE_POINT = "#{::API::V3::URN_PREFIX}storages:SharePoint".freeze+ URN_STORAGE_TYPE_SHARE_POINT = "#{::API::V3::URN_PREFIX}storages:Sharepoint".freezeSTORAGE_TYPE_MAP = {URN_STORAGE_TYPE_NEXTCLOUD => Storages::NextcloudStorage.name,URN_STORAGE_TYPE_ONE_DRIVE => Storages::OneDriveStorage.name,- URN_STORAGE_TYPE_SHARE_POINT => Storages::SharePointStorage.name+ URN_STORAGE_TYPE_SHARE_POINT => Storages::SharepointStorage.name}.freezeSTORAGE_TYPE_URN_MAP = STORAGE_TYPE_MAP.invert.freezediff --git a/modules/storages/lib/open_project/storages/engine.rb b/modules/storages/lib/open_project/storages/engine.rbindex 06008d18729..fbcaab475ae 100644--- a/modules/storages/lib/open_project/storages/engine.rb+++ b/modules/storages/lib/open_project/storages/engine.rb@@ -52,6 +52,7 @@ module OpenProject::Storagesinitializer "openproject_storages.feature_decisions" doOpenProject::FeatureDecisions.add :storage_file_picking_select_all+ OpenProject::FeatureDecisions.add :sharepoint_storageendinitializer "openproject_storages.event_subscriptions" do@@ -261,7 +262,7 @@ module OpenProject::StoragesStorages::Storage::InexistentStorageStorages::OneDriveStorageStorages::NextcloudStorage- Storages::SharePointStorage+ Storages::SharepointStorage# Allow the browser to connect to external servers for direct file uploads.AppendStoragesHostsToCspHookdiff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/commands/create_folder_command_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/commands/create_folder_command_spec.rbsimilarity index 85%rename from modules/storages/spec/common/storages/adapters/providers/share_point/commands/create_folder_command_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/commands/create_folder_command_spec.rbindex 12361805ae1..dada54ffe40 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/commands/create_folder_command_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/commands/create_folder_command_spec.rb@@ -34,17 +34,17 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule CommandsRSpec.describe CreateFolderCommand, :webmock do- let(:storage) { create(:share_point_storage, :sandbox) }- let(:auth_strategy) { Registry.resolve("share_point.authentication.userless").call(false) }+ let(:storage) { create(:sharepoint_storage, :sandbox) }+ let(:auth_strategy) { Registry.resolve("sharepoint.authentication.userless").call(false) }let(:base_drive) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW" }let(:input_data) { Input::CreateFolder.build(folder_name:, parent_location:).value! }it_behaves_like "adapter create_folder_command: basic command setup"- context "when creating a folder in the root", vcr: "share_point/create_folder_root" do+ context "when creating a folder in the root", vcr: "sharepoint/create_folder_root" dolet(:folder_name) { "Földer CreatedBy Çommand" }let(:parent_location) { composite_identifier(nil) }let(:path) { "/Marcello%20VCR/F%C3%B6lder%20CreatedBy%20%C3%87ommand" }@@ -52,7 +52,7 @@ module Storagesit_behaves_like "adapter create_folder_command: successful folder creation"end- context "when creating a folder in a parent folder", vcr: "share_point/create_folder_parent" do+ context "when creating a folder in a parent folder", vcr: "sharepoint/create_folder_parent" dolet(:folder_name) { "Földer CreatedBy Çommand" }let(:parent_location) { composite_identifier("01ANJ53W7TITEF4WCHRBDKR7VMNUWZ33WD") }let(:path) { "/Marcello%20VCR/Folder%20with%20spaces/F%C3%B6lder%20CreatedBy%20%C3%87ommand" }@@ -60,14 +60,14 @@ module Storagesit_behaves_like "adapter create_folder_command: successful folder creation"end- context "when creating a folder in a non-existing parent folder", vcr: "share_point/create_folder_parent_not_found" do+ context "when creating a folder in a non-existing parent folder", vcr: "sharepoint/create_folder_parent_not_found" dolet(:folder_name) { "Földer CreatedBy Çommand" }let(:parent_location) { composite_identifier("01AZJL5PKU2WV3U3RKKFF4A7ZCWVBXRTEU") }it_behaves_like "adapter create_folder_command: parent not found"end- context "when folder already exists", vcr: "share_point/create_folder_already_exists" do+ context "when folder already exists", vcr: "sharepoint/create_folder_already_exists" dolet(:folder_name) { "data" }let(:parent_location) { composite_identifier(nil) }@@ -75,7 +75,7 @@ module Storagesendcontext "when trying to create a folder under the root of the site",- vcr: "share_point/create_folder_invalid_request" do+ vcr: "sharepoint/create_folder_invalid_request" dolet(:folder_name) { "cant_do_that_folder" }let(:parent_location) { "/" }@@ -92,11 +92,11 @@ module Storagesprivate- def composite_identifier(item_id) = "#{base_drive}#{SharePointStorage::IDENTIFIER_SEPARATOR}#{item_id}"+ def composite_identifier(item_id) = "#{base_drive}#{SharepointStorage::IDENTIFIER_SEPARATOR}#{item_id}"def delete_created_folder(folder)Input::DeleteFolder.build(location: folder.id).bind do |input_data|- Registry.resolve("share_point.commands.delete_folder").call(storage:, auth_strategy:, input_data:)+ Registry.resolve("sharepoint.commands.delete_folder").call(storage:, auth_strategy:, input_data:)endendenddiff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/commands/delete_folder_command_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/commands/delete_folder_command_spec.rbsimilarity index 82%rename from modules/storages/spec/common/storages/adapters/providers/share_point/commands/delete_folder_command_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/commands/delete_folder_command_spec.rbindex 5150855c17c..246208c3da6 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/commands/delete_folder_command_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/commands/delete_folder_command_spec.rb@@ -34,15 +34,15 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule CommandsRSpec.describe DeleteFolderCommand, :vcr, :webmock do- let(:storage) { create(:share_point_storage, :sandbox) }- let(:auth_strategy) { Registry["share_point.authentication.userless"].call }+ let(:storage) { create(:sharepoint_storage, :sandbox) }+ let(:auth_strategy) { Registry["sharepoint.authentication.userless"].call }let(:base_drive) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW" }- it "is registered as commands.share_point.delete_folder" do- expect(Registry.resolve("share_point.commands.delete_folder")).to eq(described_class)+ it "is registered as commands.sharepoint.delete_folder" do+ expect(Registry.resolve("sharepoint.commands.delete_folder")).to eq(described_class)endit ".call requires storage and input_data as keyword arguments" do@@ -52,11 +52,11 @@ module Storagesexpect(method.parameters).to contain_exactly(%i[keyreq storage], %i[keyreq auth_strategy], %i[keyreq input_data])end- it "deletes a folder", vcr: "share_point/delete_folder" do+ it "deletes a folder", vcr: "sharepoint/delete_folder" docreate_result = Input::CreateFolder.build(folder_name: "To Be Deleted Soon", parent_location: composite_identifier(nil)).bind do |input_data|- Registry.resolve("share_point.commands.create_folder").call(storage:, auth_strategy:, input_data:)+ Registry.resolve("sharepoint.commands.create_folder").call(storage:, auth_strategy:, input_data:)endfolder = create_result.value_or { fail("Folder Creation Failed") }@@ -66,7 +66,7 @@ module Storagesendend- it "when the folder is not found, returns a failure", vcr: "share_point/delete_folder_not_found" do+ it "when the folder is not found, returns a failure", vcr: "sharepoint/delete_folder_not_found" doresult = Input::DeleteFolder.build(location: composite_identifier("NOT_HERE")).bind do |input_data|described_class.call(storage:, auth_strategy:, input_data:)end@@ -77,7 +77,7 @@ module Storagesprivate- def composite_identifier(item_id) = "#{base_drive}#{SharePointStorage::IDENTIFIER_SEPARATOR}#{item_id}"+ def composite_identifier(item_id) = "#{base_drive}#{SharepointStorage::IDENTIFIER_SEPARATOR}#{item_id}"endendenddiff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/download_link_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/download_link_query_spec.rbsimilarity index 88%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/download_link_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/download_link_query_spec.rbindex fc68a3c39e5..a3fa53ebd1d 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/download_link_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/download_link_query_spec.rb@@ -34,17 +34,17 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe DownloadLinkQuery, :vcr, :webmock dolet(:user) { create(:user) }- let(:storage) { create(:share_point_storage, :sandbox, oauth_client_token_user: user) }+ let(:storage) { create(:sharepoint_storage, :sandbox, oauth_client_token_user: user) }let(:auth_strategy) { Registry["one_drive.authentication.user_bound"].call(user, storage) }let(:drive_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY87vnZ6fgfvQanZHX-XCAyw" }- let(:file_link) { create(:file_link, origin_id: "#{drive_id}||01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS") }- let(:not_existent_file_link) { create(:file_link, origin_id: "#{drive_id}||IHaveTheHighGround") }- let(:folder_file_link) { create(:file_link, origin_id: "#{drive_id}||01ANJ53W4MWZNYS4FOTNDI3UVTLEXUZ5TQ") }+ let(:file_link) { create(:file_link, origin_id: "#{drive_id}:01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS") }+ let(:not_existent_file_link) { create(:file_link, origin_id: "#{drive_id}:IHaveTheHighGround") }+ let(:folder_file_link) { create(:file_link, origin_id: "#{drive_id}:01ANJ53W4MWZNYS4FOTNDI3UVTLEXUZ5TQ") }let(:input_data) { Input::DownloadLink.build(file_link:).value! }@@ -59,7 +59,7 @@ module Storagesendcontext "with outbound request successful" do- it "returns a result with a download url", vcr: "share_point/download_link_query_success" do+ it "returns a result with a download url", vcr: "sharepoint/download_link_query_success" dodownload_link = subject.call(auth_strategy:, input_data:)expect(download_link).to be_success@@ -69,7 +69,7 @@ module Storagesexpect(uri.path).to eq("/sites/OPTest/_layouts/15/download.aspx")end- it "returns an error on folders", vcr: "share_point/download_link_query_folder" do+ it "returns an error on folders", vcr: "sharepoint/download_link_query_folder" doinput_data = Input::DownloadLink.build(file_link: folder_file_link).value!download_link = subject.call(auth_strategy:, input_data:)@@ -81,7 +81,7 @@ module Storagesexpect(error.code).to eq(:not_found)end- it "returns an error if the file is not found", vcr: "share_point/download_link_query_not_found" do+ it "returns an error if the file is not found", vcr: "sharepoint/download_link_query_not_found" doinput_data = Input::DownloadLink.build(file_link: not_existent_file_link).value!download_link = subject.call(auth_strategy:, input_data:)diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/file_info_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/file_info_query_spec.rbsimilarity index 84%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/file_info_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/file_info_query_spec.rbindex 1d52e3d88ac..fb75018308e 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/file_info_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/file_info_query_spec.rb@@ -34,21 +34,21 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe FileInfoQuery, :webmock dolet(:user) { create(:user) }- let(:storage) { create(:share_point_storage, :sandbox, oauth_client_token_user: user) }+ let(:storage) { create(:sharepoint_storage, :sandbox, oauth_client_token_user: user) }let(:drive_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY87vnZ6fgfvQanZHX-XCAyw" }- let(:auth_strategy) { Registry["share_point.authentication.user_bound"].call(user, storage) }+ let(:auth_strategy) { Registry["sharepoint.authentication.user_bound"].call(user, storage) }let(:input_data) { Input::FileInfo.build(file_id:).value! }it_behaves_like "adapter file_info_query: basic query setup"- context "with a file id requested", vcr: "share_point/file_info_query_success_file" do- let(:file_id) { "#{drive_id}||01ANJ53W5UJK2CQO6IY5HLBVYBVNJ4TKHZ" }+ context "with a file id requested", vcr: "sharepoint/file_info_query_success_file" do+ let(:file_id) { "#{drive_id}:01ANJ53W5UJK2CQO6IY5HLBVYBVNJ4TKHZ" }let(:file_info) doResults::StorageFileInfo.new(id: "01ANJ53W5UJK2CQO6IY5HLBVYBVNJ4TKHZ",@@ -71,8 +71,8 @@ module Storagesit_behaves_like "adapter file_info_query: successful file/folder response"end- context "with a folder id requested", vcr: "share_point/file_info_query_success_folder" do- let(:file_id) { "#{drive_id}||01ANJ53WYP6TBC6T4G2RHIU4SVNEYGL6MF" }+ context "with a folder id requested", vcr: "sharepoint/file_info_query_success_folder" do+ let(:file_id) { "#{drive_id}:01ANJ53WYP6TBC6T4G2RHIU4SVNEYGL6MF" }let(:file_info) doResults::StorageFileInfo.new(id: "01ANJ53WYP6TBC6T4G2RHIU4SVNEYGL6MF",@@ -96,8 +96,8 @@ module Storagesendcontext "with a file with special characters in the path",- vcr: "share_point/file_info_query_success_special_characters" do- let(:file_id) { "#{drive_id}||01ANJ53W7BT4LBZ3PNORCYAXKILWJBLEBV" }+ vcr: "sharepoint/file_info_query_success_special_characters" do+ let(:file_id) { "#{drive_id}:01ANJ53W7BT4LBZ3PNORCYAXKILWJBLEBV" }let(:file_info) doResults::StorageFileInfo.new(id: "01ANJ53W7BT4LBZ3PNORCYAXKILWJBLEBV",@@ -120,8 +120,8 @@ module Storagesit_behaves_like "adapter file_info_query: successful file/folder response"end- context "with a not existing file id", vcr: "share_point/file_info_query_not_found" do- let(:file_id) { "#{drive_id}||not_existent" }+ context "with a not existing file id", vcr: "sharepoint/file_info_query_not_found" do+ let(:file_id) { "#{drive_id}:not_existent" }let(:error_source) { Internal::DriveItemQuery }it_behaves_like "adapter file_info_query: not found"diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/files_info_query_spec.rbsimilarity index 90%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/files_info_query_spec.rbindex 6185a1a2ba9..884c4551d49 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_info_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/files_info_query_spec.rb@@ -34,12 +34,12 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe FilesInfoQuery, :vcr, :webmock dolet(:user) { create(:user) }- let(:storage) { create(:share_point_storage, :sandbox, oauth_client_token_user: user) }- let(:auth_strategy) { Registry["share_point.authentication.user_bound"].call(user, storage) }+ let(:storage) { create(:sharepoint_storage, :sandbox, oauth_client_token_user: user) }+ let(:auth_strategy) { Registry["sharepoint.authentication.user_bound"].call(user, storage) }let(:input_data) { Input::FilesInfo.build(file_ids:).value! }it_behaves_like "adapter files_info_query: basic query setup"@@ -51,13 +51,13 @@ module Storagesit_behaves_like "adapter files_info_query: successful list response"end- context "with all outbound requests successful", vcr: "share_point/files_info_query_success" do+ context "with all outbound requests successful", vcr: "sharepoint/files_info_query_success" dolet(:drive_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY87vnZ6fgfvQanZHX-XCAyw" }let(:file_ids) do%W[- #{drive_id}||01ANJ53WYLXAJW5PXSCJB2CFCD42UPDKMI- #{drive_id}||01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS- #{drive_id}||01ANJ53W5UJK2CQO6IY5HLBVYBVNJ4TKHZ+ #{drive_id}:01ANJ53WYLXAJW5PXSCJB2CFCD42UPDKMI+ #{drive_id}:01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS+ #{drive_id}:01ANJ53W5UJK2CQO6IY5HLBVYBVNJ4TKHZ]endlet(:expected_file_infos) do@@ -113,9 +113,9 @@ module Storagesit_behaves_like "adapter files_info_query: successful list response"end- context "with one outbound request returning not found", vcr: "share_point/files_info_query_one_not_found" do+ context "with one outbound request returning not found", vcr: "sharepoint/files_info_query_one_not_found" dolet(:drive_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY87vnZ6fgfvQanZHX-XCAyw" }- let(:file_ids) { %W[#{drive_id}||01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS #{drive_id}||not_existent] }+ let(:file_ids) { %W[#{drive_id}:01ANJ53W4ELLSQL3JZHNA2MHKKHKAUQWNS #{drive_id}:not_existent] }let(:expected_file_infos) do[Results::StorageFileInfo.new(diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/files_query_spec.rbsimilarity index 90%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/files_query_spec.rbindex 53430fbe563..a2d570feca4 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/files_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/files_query_spec.rb@@ -34,19 +34,18 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe FilesQuery, :webmock dolet(:user) { create(:admin) }- let(:storage) { create(:share_point_storage, :sandbox, oauth_client_token_user: user) }+ let(:storage) { create(:sharepoint_storage, :sandbox, oauth_client_token_user: user) }- let(:auth_strategy) { Registry["share_point.authentication.userless"].call(false) }+ let(:auth_strategy) { Registry["sharepoint.authentication.userless"].call(false) }let(:input_data) { Input::Files.build(folder:).value! }it_behaves_like "adapter files_query: basic query setup"- # rubocop:disable Layout/LineLength- context "when parent folder is root", vcr: "share_point/files_query_root" do+ context "when parent folder is root", vcr: "sharepoint/files_query_root" dolet(:folder) { "/" }let(:files_result) doResults::StorageFileCollection.new(@@ -119,13 +118,13 @@ module Storagesit_behaves_like "adapter files_query: successful files response"end- context "when requesting a drive", vcr: "share_point/files_query_drive" do+ context "when requesting a drive", vcr: "sharepoint/files_query_drive" dolet(:folder) { "/Marcello VCR" }let(:files_result) doResults::StorageFileCollection.new(files: [Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W5P3SUY3ZCDTRA3KLXRGA5A2M3S",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W5P3SUY3ZCDTRA3KLXRGA5A2M3S",name: "data",size: 12605,mime_type: "application/x-op-directory",@@ -137,7 +136,7 @@ module Storagespermissions: %i[readable writeable]),Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W2MWJ6SKEZPHFGIAAB325KYYMPE",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W2MWJ6SKEZPHFGIAAB325KYYMPE",name: "empty",size: 0,mime_type: "application/x-op-directory",@@ -149,7 +148,7 @@ module Storagespermissions: %i[readable writeable]),Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W7TITEF4WCHRBDKR7VMNUWZ33WD",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W7TITEF4WCHRBDKR7VMNUWZ33WD",name: "Folder with spaces",size: 0,mime_type: "application/x-op-directory",@@ -161,7 +160,7 @@ module Storagespermissions: %i[readable writeable]),Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53WZVLAWJSVFKOFF3HLYZPMPUK6HI",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53WZVLAWJSVFKOFF3HLYZPMPUK6HI",name: "simply_oidc.jpg",size: 56483,mime_type: "image/jpeg",@@ -174,7 +173,7 @@ module Storages)],parent: Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:",name: "Marcello VCR",location: "/Marcello%20VCR",permissions: %i[readable writeable]@@ -188,14 +187,14 @@ module Storagesit_behaves_like "adapter files_query: successful files response"end- context "when requesting an folder", vcr: "share_point/files_query_folder" do+ context "when requesting an folder", vcr: "sharepoint/files_query_folder" dolet(:folder) { "/Marcello VCR/data" }let(:files_result) doResults::StorageFileCollection.new(files: [Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W6DBDYX553L4REYNOMUI6XVMTO6",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W6DBDYX553L4REYNOMUI6XVMTO6",name: "subfolder",size: 11845,mime_type: "application/x-op-directory",@@ -207,7 +206,7 @@ module Storagespermissions: %i[readable writeable]),Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W26P5RNXU7V2JBKCVQQAGGTO46A",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W26P5RNXU7V2JBKCVQQAGGTO46A",name: "edge one_drive_health_report_2025-07-22T16_03_25Z.txt",size: 760,mime_type: "text/plain",@@ -220,7 +219,7 @@ module Storages)],parent: Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W5P3SUY3ZCDTRA3KLXRGA5A2M3S",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W5P3SUY3ZCDTRA3KLXRGA5A2M3S",name: "data",location: "/Marcello%20VCR/data",permissions: %i[readable writeable]@@ -235,13 +234,13 @@ module Storagesit_behaves_like "adapter files_query: successful files response"end- context "when requesting a sub folder", vcr: "share_point/files_query_sub_folder" do+ context "when requesting a sub folder", vcr: "sharepoint/files_query_sub_folder" dolet(:folder) { "/Marcello VCR/data/subfolder" }let(:files_result) doResults::StorageFileCollection.new(files: [Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W7MUYDYQAA3WVEYDJQNZVSKNPGD",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W7MUYDYQAA3WVEYDJQNZVSKNPGD",name: "fw13-easy-effects.json",size: 11845,mime_type: "application/json",@@ -254,7 +253,7 @@ module Storages)],parent: Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W6DBDYX553L4REYNOMUI6XVMTO6",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W6DBDYX553L4REYNOMUI6XVMTO6",name: "subfolder",location: "/Marcello%20VCR/data/subfolder",permissions: %i[readable writeable]@@ -270,14 +269,14 @@ module Storagesit_behaves_like "adapter files_query: successful files response"end- context "when requesting an empty folder", vcr: "share_point/files_query_empty_folder" do+ context "when requesting an empty folder", vcr: "sharepoint/files_query_empty_folder" dolet(:folder) { "/Marcello VCR/empty" }let(:files_result) doResults::StorageFileCollection.new(files: [],parent: Results::StorageFile.new(- id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W2MWJ6SKEZPHFGIAAB325KYYMPE",+ id: "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W2MWJ6SKEZPHFGIAAB325KYYMPE",name: "empty",location: "/Marcello%20VCR/empty",permissions: %i[readable writeable]@@ -292,7 +291,7 @@ module Storagesit_behaves_like "adapter files_query: successful files response"end- context "when requesting an empty library", vcr: "share_point/files_query_empty_drive" do+ context "when requesting an empty library", vcr: "sharepoint/files_query_empty_drive" dolet(:folder) { "/Selected Permissions" }let(:files_result) do@@ -313,18 +312,17 @@ module Storagesit_behaves_like "adapter files_query: successful files response"end- context "when requesting an unknown file", vcr: "share_point/files_query_file_not_found" do+ context "when requesting an unknown file", vcr: "sharepoint/files_query_file_not_found" dolet(:folder) { "/Marcello VCR/POTATO" }it_behaves_like "adapter files_query: not found", Internal::ChildrenQueryend- context "when requestion an unknown drive", vcr: "share_point/files_query_drive_not_found" do+ context "when requestion an unknown drive", vcr: "sharepoint/files_query_drive_not_found" dolet(:folder) { "/That is no moon" }it_behaves_like "adapter files_query: not found"end- # rubocop:enable Layout/LineLengthendendenddiff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/open_file_link_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/open_file_link_query_spec.rbsimilarity index 84%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/open_file_link_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/open_file_link_query_spec.rbindex 28fb668d590..cfa9c586a54 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/open_file_link_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/open_file_link_query_spec.rb@@ -34,19 +34,19 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe OpenFileLinkQuery, :vcr, :webmock dolet(:user) { create(:user) }- let(:storage) { create(:share_point_storage, :sandbox, oauth_client_token_user: user) }- let(:auth_strategy) { Registry.resolve("share_point.authentication.user_bound").call(user, storage) }+ let(:storage) { create(:sharepoint_storage, :sandbox, oauth_client_token_user: user) }+ let(:auth_strategy) { Registry.resolve("sharepoint.authentication.user_bound").call(user, storage) }let(:drive_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY87vnZ6fgfvQanZHX-XCAyw" }- let(:separator) { SharePointStorage::IDENTIFIER_SEPARATOR }+ let(:separator) { SharepointStorage::IDENTIFIER_SEPARATOR }it_behaves_like "adapter open_file_link_query: basic query setup"context "with outbound requests successful" do- context "with open location flag not set", vcr: "share_point/open_file_link_query_success" do+ context "with open location flag not set", vcr: "sharepoint/open_file_link_query_success" dolet(:file_id) { "#{drive_id}#{separator}01ANJ53WYLXAJW5PXSCJB2CFCD42UPDKMI" }let(:input_data) { Input::OpenFileLink.build(file_id:).value! }let(:open_file_link) { "https://ymt6d.sharepoint.com/sites/OPTest/Shared%20Documents/Folder" }@@ -54,7 +54,7 @@ module Storagesit_behaves_like "adapter open_file_link_query: successful link response"end- context "with open location flag set", vcr: "share_point/open_file_link_location_query_success" do+ context "with open location flag set", vcr: "sharepoint/open_file_link_location_query_success" dolet(:file_id) { "#{drive_id}#{separator}01ANJ53WYLXAJW5PXSCJB2CFCD42UPDKMI" }let(:input_data) { Input::OpenFileLink.build(file_id:, open_location: true).value! }let(:open_file_link) { "https://ymt6d.sharepoint.com/sites/OPTest/Shared%20Documents" }@@ -62,7 +62,7 @@ module Storagesit_behaves_like "adapter open_file_link_query: successful link response"context "if file id already points at root element",- vcr: "share_point/open_file_link_location_on_root_query_success" do+ vcr: "sharepoint/open_file_link_location_on_root_query_success" dolet(:file_id) { "#{drive_id}#{separator}01ANJ53W56Y2GOVW7725BZO354PWSELRRZ" }it_behaves_like "adapter open_file_link_query: successful link response"@@ -70,7 +70,7 @@ module Storagesendend- context "with not existent file id", vcr: "share_point/open_file_link_query_not_found" do+ context "with not existent file id", vcr: "sharepoint/open_file_link_query_not_found" dolet(:file_id) { "#{drive_id}#{separator}YouShallNotPass" }let(:input_data) { Input::OpenFileLink.build(file_id:).value! }let(:error_source) { Internal::DriveItemQuery }diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/open_storage_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/open_storage_query_spec.rbsimilarity index 95%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/open_storage_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/open_storage_query_spec.rbindex 054dd264c28..94ef55d11f7 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/open_storage_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/open_storage_query_spec.rb@@ -34,10 +34,10 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe OpenStorageQuery do- let(:storage) { create(:share_point_storage, :sandbox) }+ let(:storage) { create(:sharepoint_storage, :sandbox) }it "responds to .call" doexpect(described_class).to respond_to(:call)diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/upload_link_query_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/upload_link_query_spec.rbsimilarity index 92%rename from modules/storages/spec/common/storages/adapters/providers/share_point/queries/upload_link_query_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/upload_link_query_spec.rbindex 64f3cb7db7e..c21828423f2 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/queries/upload_link_query_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/queries/upload_link_query_spec.rb@@ -34,18 +34,18 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule QueriesRSpec.describe UploadLinkQuery, :webmock do- let(:storage) { create(:share_point_storage, :sandbox) }- let(:auth_strategy) { Registry["share_point.authentication.userless"].call }+ let(:storage) { create(:sharepoint_storage, :sandbox) }+ let(:auth_strategy) { Registry["sharepoint.authentication.userless"].call }let(:upload_method) { :put }let(:input_data) { Input::UploadLink.build(folder_id:, file_name:).value! }let(:file_name) { "DeathStart_blueprints.tiff" }it_behaves_like "adapter upload_link_query: basic query setup"- context "when creating an upload link to the root folder of a list", vcr: "share_point/upload_link_success" do+ context "when creating an upload link to the root folder of a list", vcr: "sharepoint/upload_link_success" dolet(:folder_id) { "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY8Qconfm2i6SKEoCmuGYqQK" }let(:token) do@@ -69,9 +69,9 @@ module Storagesit_behaves_like "adapter upload_link_query: successful upload link response"end- context "when creating an upload link to a subfolder on a list", vcr: "share_point/upload_link_subfolder" do+ context "when creating an upload link to a subfolder on a list", vcr: "sharepoint/upload_link_subfolder" dolet(:folder_id) do- "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW||01ANJ53W5P3SUY3ZCDTRA3KLXRGA5A2M3S"+ "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY9jo6leJDqrT7muzvmiWjFW:01ANJ53W5P3SUY3ZCDTRA3KLXRGA5A2M3S"endlet(:token) do"v1.eyJzaXRlaWQiOiIxMDk5ZTMxNS1kMGM3LTQ3YzctODY0MC1hYTk1MDRiNzBmZmYiLCJhcHBfZGlzcGxheW5hbWUiOiJPUCBTZWx" \@@ -93,11 +93,11 @@ module Storagesit_behaves_like "adapter upload_link_query: successful upload link response"end- context "when requesting an upload link for a not existing file", vcr: "share_point/upload_link_not_found" do+ context "when requesting an upload link for a not existing file", vcr: "sharepoint/upload_link_not_found" dolet(:input_data) doInput::UploadLink.build(folder_id:- "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY8Qconfm2i6SKEoCmuGYqQK||04AZJL5PN6Y2GOVW7725BZO354PWSELRRZ",+ "b!FeOZEMfQx0eGQKqVBLcP__BG8mq-4-9FuRqOyk3MXY8Qconfm2i6SKEoCmuGYqQK:04AZJL5PN6Y2GOVW7725BZO354PWSELRRZ",file_name: "DeathStart_blueprints.tiff").value!enddiff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/share_point_contract_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/sharepoint_contract_spec.rbsimilarity index 95%rename from modules/storages/spec/common/storages/adapters/providers/share_point/share_point_contract_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/sharepoint_contract_spec.rbindex 413aaa4263e..15be7df91eb 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/share_point_contract_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/sharepoint_contract_spec.rb@@ -34,10 +34,10 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint- RSpec.describe SharePointContract, :storage_server_helpers, :webmock do+ module Sharepoint+ RSpec.describe SharepointContract, :storage_server_helpers, :webmock dolet(:current_user) { create(:admin) }- let(:storage) { build(:share_point_storage, :with_tenant_id) }+ let(:storage) { build(:sharepoint_storage, :with_tenant_id) }# As the SharePointContract is selected by the BaseContract to make writable attributes available,# the BaseContract needs to be instantiated here.diff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/storage_wizard_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/storage_wizard_spec.rbsimilarity index 97%rename from modules/storages/spec/common/storages/adapters/providers/share_point/storage_wizard_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/storage_wizard_spec.rbindex 074b2215275..9a593525560 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/storage_wizard_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/storage_wizard_spec.rb@@ -30,10 +30,10 @@require "spec_helper"-RSpec.describe Storages::Adapters::Providers::SharePoint::StorageWizard do+RSpec.describe Storages::Adapters::Providers::Sharepoint::StorageWizard dosubject(:wizard) { described_class.new(model:, user:) }- let(:model) { Storages::SharePointStorage.new }+ let(:model) { Storages::SharepointStorage.new }let(:user) { create(:admin) }before dodiff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/validators/authentication_validator_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/validators/authentication_validator_spec.rbsimilarity index 80%rename from modules/storages/spec/common/storages/adapters/providers/share_point/validators/authentication_validator_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/validators/authentication_validator_spec.rbindex 4d56d4fc2b6..4de4f75094a 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/validators/authentication_validator_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/validators/authentication_validator_spec.rb@@ -3,12 +3,12 @@require "spec_helper"require_module_spec_helper-RSpec.describe Storages::Adapters::Providers::SharePoint::Validators::AuthenticationValidator, :webmock do+RSpec.describe Storages::Adapters::Providers::Sharepoint::Validators::AuthenticationValidator, :webmock dosubject(:validator) { described_class.new(storage) }context "when using OAuth2" dolet(:user) { create(:user) }- let(:storage) { create(:share_point_storage, :sandbox, oauth_client_token_user: user) }+ let(:storage) { create(:sharepoint_storage, :sandbox, oauth_client_token_user: user) }let(:error) { Storages::Adapters::Results::Error.new(code: :unauthorized, source: self) }before { User.current = user }@@ -17,7 +17,7 @@ RSpec.describe Storages::Adapters::Providers::SharePoint::Validators::Authenticaexpect(described_class.key).to eq(:authentication)end- it "passes when the user has a token and the request works", vcr: "share_point/user_query_success" do+ it "passes when the user has a token and the request works", vcr: "sharepoint/user_query_success" doexpect(validator.call).to be_successend@@ -31,7 +31,7 @@ RSpec.describe Storages::Adapters::Providers::SharePoint::Validators::Authenticaendit "returns a failure if the remote call failed" do- Storages::Adapters::Registry.stub("share_point.queries.user", ->(_) { Failure(error) })+ Storages::Adapters::Registry.stub("sharepoint.queries.user", ->(_) { Failure(error) })result = validator.callexpect(result[:user_bound_request]).to be_a_failurediff --git a/modules/storages/spec/common/storages/adapters/providers/share_point/validators/storage_configuration_validator_spec.rb b/modules/storages/spec/common/storages/adapters/providers/sharepoint/validators/storage_configuration_validator_spec.rbsimilarity index 81%rename from modules/storages/spec/common/storages/adapters/providers/share_point/validators/storage_configuration_validator_spec.rbrename to modules/storages/spec/common/storages/adapters/providers/sharepoint/validators/storage_configuration_validator_spec.rbindex 5dddfef3e3c..a07c3a7bd3a 100644--- a/modules/storages/spec/common/storages/adapters/providers/share_point/validators/storage_configuration_validator_spec.rb+++ b/modules/storages/spec/common/storages/adapters/providers/sharepoint/validators/storage_configuration_validator_spec.rb@@ -6,15 +6,15 @@ require_module_spec_helpermodule Storagesmodule Adaptersmodule Providers- module SharePoint+ module Sharepointmodule ValidatorsRSpec.describe StorageConfigurationValidator, :webmock do- let(:storage) { create(:share_point_storage, :sandbox, :as_automatically_managed) }+ let(:storage) { create(:sharepoint_storage, :sandbox, :as_automatically_managed) }let(:error) { Results::Error.new(code: error_code, source: self) }subject(:validator) { described_class.new(storage) }- describe "success", vcr: "share_point/files_query_userless" do+ describe "success", vcr: "sharepoint/files_query_userless" doit "returns a GroupValidationResult" doresults = validator.call@@ -25,7 +25,7 @@ module Storagesdescribe "failure" dolet(:files_double) { class_double(Queries::FilesQuery) }- let(:auth_strategy) { Registry["share_point.authentication.userless"].call }+ let(:auth_strategy) { Registry["sharepoint.authentication.userless"].call }let(:input_data) { Input::Files.build(folder: "/").value! }let(:result) { Success() }@@ -34,7 +34,7 @@ module Storagesendcontext "when the storage isn't configured" do- let(:storage) { create(:share_point_storage) }+ let(:storage) { create(:sharepoint_storage) }it "the check fails" doresults = validator.call@@ -44,7 +44,7 @@ module Storagesendcontext "when the tenant id is wrong" do- it "but looks like an actual valid value", vcr: "share_point/validation_wrong_tenant_id" do+ it "but looks like an actual valid value", vcr: "sharepoint/validation_wrong_tenant_id" dostorage.tenant_id = "itdoesnotexists9000.sharepoint.com"results = described_class.new(storage).call@@ -52,7 +52,7 @@ module Storagesexpect(results[:tenant_id].code).to eq(:sp_tenant_id_invalid)end- it "but is blatantly wrong", vcr: "share_point/validation_absurd_tenant_id" do+ it "but is blatantly wrong", vcr: "sharepoint/validation_absurd_tenant_id" dostorage.tenant_id = "wrong"results = described_class.new(storage).call@@ -62,7 +62,7 @@ module Storagesendcontext "when the client secret is wrong" do- it "fails the check", vcr: "share_point/validation_wrong_client_secret" do+ it "fails the check", vcr: "sharepoint/validation_wrong_client_secret" dostorage.oauth_client.client_secret = "wrong"results = described_class.new(storage).call@@ -72,7 +72,7 @@ module Storagesendcontext "when the client id is wrong" do- it "fails the check", vcr: "share_point/validation_wrong_client_id" do+ it "fails the check", vcr: "sharepoint/validation_wrong_client_id" dostorage.oauth_client.client_id = "wrong"results = described_class.new(storage).calldiff --git a/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rbindex 77cf13f732f..a13aef72e27 100644--- a/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb+++ b/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb@@ -70,13 +70,13 @@ RSpec.shared_examples_for "file_link contract" docontext "when empty" dolet(:file_link_attributes) { { origin_id: "" } }- include_examples "contract is invalid", origin_id: %i[blank too_short]+ include_examples "contract is invalid", origin_id: %i[blank]endcontext "when nil" dolet(:file_link_attributes) { { origin_id: nil } }- include_examples "contract is invalid", origin_id: %i[blank too_short]+ include_examples "contract is invalid", origin_id: %i[blank]endcontext "when numeric" do@@ -96,12 +96,6 @@ RSpec.shared_examples_for "file_link contract" doinclude_examples "contract is valid"end-- context "when longer than 100 characters" do- let(:file_link_attributes) { { origin_id: "1" * 201 } }-- include_examples "contract is invalid", origin_id: :too_long- endenddescribe "origin_name" dodiff --git a/modules/storages/spec/factories/storage_factory.rb b/modules/storages/spec/factories/storage_factory.rbindex 610e1173af7..0bb0e2832bb 100644--- a/modules/storages/spec/factories/storage_factory.rb+++ b/modules/storages/spec/factories/storage_factory.rb@@ -232,9 +232,9 @@ FactoryBot.define doendend- factory :share_point_storage,+ factory :sharepoint_storage,parent: :storage,- class: "::Storages::SharePointStorage" do+ class: "::Storages::SharepointStorage" dohost { "https://openproject.sharepoint.com/sites/ProjectX" }automatically_managed { false }@@ -247,8 +247,8 @@ FactoryBot.define doendtrait :sandbox do- tenant_id { ENV.fetch("SHARE_POINT_TEST_TENANT_ID", "e36f1dbc-fdae-427e-b61b-0d96ddfb81a4") }- host { ENV.fetch("SHARE_POINT_TEST_HOST", "https://ymt6d.sharepoint.com/sites/OPTest") }+ tenant_id { ENV.fetch("SHAREPOINT_TEST_TENANT_ID", "e36f1dbc-fdae-427e-b61b-0d96ddfb81a4") }+ host { ENV.fetch("SHAREPOINT_TEST_HOST", "https://ymt6d.sharepoint.com/sites/OPTest") }transient dooauth_client_token_user { association :user }@@ -256,18 +256,18 @@ FactoryBot.define doafter(:create) do |storage, evaluator|create(:oauth_client,- client_id: ENV.fetch("SHARE_POINT_TEST_OAUTH_CLIENT_ID",+ client_id: ENV.fetch("SHAREPOINT_TEST_OAUTH_CLIENT_ID","MISSING_SHARE_POINT_TEST_OAUTH_CLIENT_ID"),- client_secret: ENV.fetch("SHARE_POINT_TEST_OAUTH_CLIENT_SECRET",+ client_secret: ENV.fetch("SHAREPOINT_TEST_OAUTH_CLIENT_SECRET","MISSING_SHARE_POINT_TEST_OAUTH_CLIENT_SECRET"),integration: storage)create(:oauth_client_token,oauth_client: storage.oauth_client,user: evaluator.oauth_client_token_user,- access_token: ENV.fetch("SHARE_POINT_TEST_OAUTH_CLIENT_ACCESS_TOKEN",+ access_token: ENV.fetch("SHAREPOINT_TEST_OAUTH_CLIENT_ACCESS_TOKEN","MISSING_SHARE_POINT_TEST_OAUTH_CLIENT_ACCESS_TOKEN"),- refresh_token: ENV.fetch("SHARE_POINT_TEST_OAUTH_CLIENT_REFRESH_TOKEN",+ refresh_token: ENV.fetch("SHAREPOINT_TEST_OAUTH_CLIENT_REFRESH_TOKEN","MISSING_SHARE_POINT_TEST_OAUTH_CLIENT_REFRESH_TOKEN"),token_type: "bearer")enddiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_already_exists.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_already_exists.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_already_exists.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_already_exists.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_invalid_request.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_invalid_request.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_invalid_request.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_invalid_request.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_parent.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_parent.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_parent.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_parent.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_parent_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_parent_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_parent_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_parent_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_root.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_root.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/create_folder_root.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/create_folder_root.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/delete_folder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/delete_folder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/delete_folder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/delete_folder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/delete_folder_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/delete_folder_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/delete_folder_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/delete_folder_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/download_link_query_folder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/download_link_query_folder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/download_link_query_folder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/download_link_query_folder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/download_link_query_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/download_link_query_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/download_link_query_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/download_link_query_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/download_link_query_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/download_link_query_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/download_link_query_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/download_link_query_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_success_file.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_success_file.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_success_file.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_success_file.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_success_folder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_success_folder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_success_folder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_success_folder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_success_special_characters.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_success_special_characters.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/file_info_query_success_special_characters.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/file_info_query_success_special_characters.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_info_query_one_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_info_query_one_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_info_query_one_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_info_query_one_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_info_query_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_info_query_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_info_query_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_info_query_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_drive.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_drive.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_drive.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_drive.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_drive_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_drive_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_drive_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_drive_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_empty_drive.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_empty_drive.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_empty_drive.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_empty_drive.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_empty_folder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_empty_folder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_empty_folder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_empty_folder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_file_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_file_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_file_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_file_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_folder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_folder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_folder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_folder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_root.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_root.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_root.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_root.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_sub_folder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_sub_folder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_sub_folder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_sub_folder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_userless.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_userless.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/files_query_userless.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/files_query_userless.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_location_on_root_query_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_location_on_root_query_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_location_on_root_query_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_location_on_root_query_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_location_query_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_location_query_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_location_query_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_location_query_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_query_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_query_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_query_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_query_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_query_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_query_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/open_file_link_query_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/open_file_link_query_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/upload_link_not_found.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/upload_link_not_found.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/upload_link_not_found.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/upload_link_not_found.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/upload_link_subfolder.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/upload_link_subfolder.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/upload_link_subfolder.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/upload_link_subfolder.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/upload_link_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/upload_link_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/upload_link_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/upload_link_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/user_query_success.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/user_query_success.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/user_query_success.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/user_query_success.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_absurd_tenant_id.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_absurd_tenant_id.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_absurd_tenant_id.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_absurd_tenant_id.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_wrong_client_id.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_wrong_client_id.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_wrong_client_id.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_wrong_client_id.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_wrong_client_secret.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_wrong_client_secret.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_wrong_client_secret.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_wrong_client_secret.ymldiff --git a/modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_wrong_tenant_id.yml b/modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_wrong_tenant_id.ymlsimilarity index 100%rename from modules/storages/spec/support/fixtures/vcr_cassettes/share_point/validation_wrong_tenant_id.ymlrename to modules/storages/spec/support/fixtures/vcr_cassettes/sharepoint/validation_wrong_tenant_id.yml