OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub
Ruby agile-developmentangularbcfboardsbug-trackerganttgantt-chartifcissue-trackerjira-alternativekanbanopenprojectproduct-managementproject-managementproject-planningroadmaprubyscrumtimelineworkflows
[#66093] Simplify and improve Calculated Value spec
Tobias Dillmannef7fd5e16927
diff --git a/spec/models/acts_as_customizable/calculated_value_spec.rb b/spec/models/acts_as_customizable/calculated_value_spec.rbindex 0f9de5e67cf..f9e749413ca 100644--- a/spec/models/acts_as_customizable/calculated_value_spec.rb+++ b/spec/models/acts_as_customizable/calculated_value_spec.rb@@ -393,12 +393,16 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valuendend+ def expect_no_calculated_value_errors(calc_val_cf, project)+ expect(calc_val_cf.first_calculation_error(project)).to be_nil+ end+let(:project) { create(:project) }- let(:enabled_custom_fields) { {} }+ let(:custom_field_values) { {} }before do- enabled_custom_fields.each do |cf, value|- create(:custom_value, customized: project, custom_field: cf, value:)+ custom_field_values.each do |custom_field, value|+ create(:custom_value, customized: project, custom_field:, value:)endend@@ -406,18 +410,15 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valulet(:cf_div) { create(:calculated_value_project_custom_field, projects: [project], formula: "5 / 0") }let(:cf_add) { create(:calculated_value_project_custom_field, projects: [project], formula: "5 + 0") }- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ cf_div => nil, cf_add => nil }endit "creates a mathematical error for division by zero" doproject.calculate_custom_fields([cf_div, cf_add])- expect(cf_add.calculated_value_errors.where(customized: project)).to be_empty-- errors = cf_div.calculated_value_errors.where(customized: project)- expect(errors.size).to eq(1)- expect(errors.first&.error_code).to eq("ERROR_MATHEMATICAL")+ expect_no_calculated_value_errors(cf_add, project)+ expect_calculated_value_error(cf_div, project, "ERROR_MATHEMATICAL")endend@@ -429,14 +430,14 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valulet(:cv2) { create(:calculated_value_project_custom_field, :skip_validations, projects: [project], formula: "5 + #{cv1}") }let(:cv3) { create(:calculated_value_project_custom_field, :skip_validations, projects: [project], formula: "5 + 5") }- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ cv1 => nil, cv2 => nil, cf_int => nil, cv3 => nil }endit "creates a missing value error" doproject.calculate_custom_fields([cv1, cv2, cv3])- expect(cv3.calculated_value_errors.where(customized: project)).to be_empty+ expect_no_calculated_value_errors(cv3, project)# Directly missing cf_intexpect_calculated_value_error(cv1, project, "ERROR_MISSING_VALUE", cf_int.name)@@ -447,21 +448,21 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valuenddescribe "disabled value" do- let(:cf_int) { create(:integer_project_custom_field) }+ let(:cf_int) { create(:integer_project_custom_field, projects: []) }let(:cv1) docreate(:calculated_value_project_custom_field, :skip_validations, projects: [project], formula: "5 + #{cf_int}")endlet(:cv2) { create(:calculated_value_project_custom_field, :skip_validations, projects: [project], formula: "5 + #{cv1}") }let(:cv3) { create(:calculated_value_project_custom_field, :skip_validations, projects: [project], formula: "5 + 5") }- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ cv1 => nil, cv2 => nil, cv3 => nil }endit "creates a disabled value error" doproject.calculate_custom_fields([cv1, cv2, cv3])- expect(cv3.first_calculation_error(project)).to be_blank+ expect_no_calculated_value_errors(cv3, project)# The referenced int field is disabled, we thus expect a `disabled` error.expect_calculated_value_error(cv1, project, "ERROR_DISABLED_VALUE", cf_int.name)@@ -479,7 +480,7 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valuendlet(:enabled_cv) { create(:calculated_value_project_custom_field, :skip_validations, projects: [project], formula:) }- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ enabled_cv => nil, cf_int => 0 }end@@ -507,7 +508,7 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valuformula: "#{a_plus_b} / #{a_minus_b}")end- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ a => 1, b => 2, a_plus_b => nil, a_minus_b => nil, nested_calculation => nil }end@@ -531,7 +532,7 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valucreate(:calculated_value_project_custom_field, :skip_validations, projects: [], formula: "#{a} - #{b}")end- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ a => 1, b => 2, a_plus_b => nil, nested_calculation => nil }end@@ -548,7 +549,7 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valucreate(:calculated_value_project_custom_field, :skip_validations, projects: [], formula: "#{a} + #{b}")end- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ a => 1, b => 2, a_minus_b => nil, nested_calculation => nil }end@@ -561,7 +562,7 @@ RSpec.describe ActsAsCustomizable::CalculatedValue, with_flag: { calculated_valuenddescribe "resulting in a division by zero error" do- let(:enabled_custom_fields) do+ let(:custom_field_values) do{ a => 1, b => 1, a_plus_b => nil, a_minus_b => nil, nested_calculation => nil }end