Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

also add EntityRepresenterFactory for cost

Klaus Zandersf738f496f677
diff --git a/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb b/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb
index 5bd646e6068..af20c8ffb76 100644
--- a/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb
+++ b/modules/costs/lib/api/v3/cost_entries/cost_entry_representer.rb
@@ -39,9 +39,9 @@ module API
associated_resource :cost_type
# for now not embedded, because work packages are quite large
- associated_resource :work_package,
- getter: ->(*) {},
- link_title_attribute: :subject
+ associated_resource :entity,
+ getter: ::API::V3::CostEntries::EntityRepresenterFactory.create_getter_lambda(:entity),
+ link: ::API::V3::CostEntries::EntityRepresenterFactory.create_link_lambda(:entity)
property :id, render_nil: true
property :units, as: :spentUnits
diff --git a/modules/costs/lib/api/v3/cost_entries/entity_representer_factory.rb b/modules/costs/lib/api/v3/cost_entries/entity_representer_factory.rb
new file mode 100644
index 00000000000..001cbf7acbc
--- /dev/null
+++ b/modules/costs/lib/api/v3/cost_entries/entity_representer_factory.rb
@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module API
+ module V3
+ module CostEntries
+ module EntityRepresenterFactory
+ module_function
+
+ ##
+ # Create the appropriate subclass representer
+ # for each principal entity
+ def create(model, **args)
+ representer_class(model).create(model, **args)
+ end
+
+ def representer_class(model)
+ case model
+ when WorkPackage then ::API::V3::WorkPackages::WorkPackageRepresenter
+ # when Meeting then ::API::V3::Meetings::MeetingRepresenter
+ else
+ raise ArgumentError, "Missing concrete entity representer for #{model}"
+ end
+ end
+
+ def representer_type(model)
+ case model
+ when WorkPackage then :work_package
+ # when Meeting then :meeting
+ else
+ raise ArgumentError, "Missing concrete entity representer for #{model}"
+ end
+ end
+
+ def title_attribute(model)
+ case model
+ when WorkPackage then :subject
+ # when Meeting then :title
+ else
+ raise ArgumentError, "Missing concrete entity representer for #{model}"
+ end
+ end
+
+ def create_link_lambda(name, getter: "#{name}_id")
+ ->(*) {
+ v3_path = API::V3::CostEntries::EntityRepresenterFactory.representer_type(represented.send(name))
+ title_attribute = API::V3::CostEntries::EntityRepresenterFactory.title_attribute(represented.send(name))
+
+ instance_exec(&self.class.associated_resource_default_link(name,
+ v3_path:,
+ skip_link: -> { false },
+ title_attribute:,
+ getter:))
+ }
+ end
+
+ def create_getter_lambda(name)
+ ->(*) {
+ next unless embed_links
+
+ instance = represented.send(name)
+ next if instance.nil?
+
+ ::API::V3::CostEntries::EntityRepresenterFactory.create(instance, current_user:)
+ }
+ end
+ end
+ end
+ end
+end