Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Fix inverted visibility logic for theme contrast options

Kabiru Mwenjafae50df4bf33
diff --git a/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts b/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts
index c16db186dff..36bbaaae081 100644
--- a/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts
+++ b/frontend/src/stimulus/controllers/dynamic/my/look-and-feel.controller.ts
@@ -52,12 +52,12 @@ export default class LookAndFeelController extends Controller {
private toggleOptionGroups() {
const isSyncWithOs = this.themeSelectTarget.value === this.syncWithOsValue;
- this.toggleElementVisibility(this.autoThemeContrastTarget, !isSyncWithOs);
- this.toggleElementVisibility(this.singleThemeContrastTarget, isSyncWithOs);
+ this.toggleElementVisibility(this.autoThemeContrastTarget, isSyncWithOs);
+ this.toggleElementVisibility(this.singleThemeContrastTarget, !isSyncWithOs);
}
- private toggleElementVisibility(targetElement:HTMLElement, shouldHide:boolean) {
+ private toggleElementVisibility(targetElement:HTMLElement, shouldShow:boolean) {
const container = targetElement.closest(this.viewComponentSelector);
- container?.classList.toggle(this.displayNoneClass, shouldHide);
+ container?.classList.toggle(this.displayNoneClass, !shouldShow);
}
}