Skip to content

OpenProject is the leading open source project management software for product, project and portfolio management. A powerful Jira alternative with agile planning, issue tracking, roadmaps, Gantt charts, time tracking, collaboration features, and more. Available on premises or in the cloud. ⭐ Star us on GitHub

Fix Rubocop offenses

Alexander Brandon Colesfdf5cc2ca935
diff --git a/db/migrate/20250422072119_rename_comment_permissions.rb b/db/migrate/20250422072119_rename_comment_permissions.rb
index efbe5231b93..131aff76de8 100644
--- a/db/migrate/20250422072119_rename_comment_permissions.rb
+++ b/db/migrate/20250422072119_rename_comment_permissions.rb
@@ -37,8 +37,10 @@ class RenameCommentPermissions < ActiveRecord::Migration[8.0]
::Migration::MigrationUtils::PermissionRenamer.rename("view_comments_with_restricted_visibility", "view_internal_comments")
::Migration::MigrationUtils::PermissionRenamer.rename("add_comments_with_restricted_visibility", "add_internal_comments")
- ::Migration::MigrationUtils::PermissionRenamer.rename("edit_own_comments_with_restricted_visibility", "edit_own_internal_comments")
- ::Migration::MigrationUtils::PermissionRenamer.rename("edit_others_comments_with_restricted_visibility", "edit_others_internal_comments")
+ ::Migration::MigrationUtils::PermissionRenamer.rename("edit_own_comments_with_restricted_visibility",
+ "edit_own_internal_comments")
+ ::Migration::MigrationUtils::PermissionRenamer.rename("edit_others_comments_with_restricted_visibility",
+ "edit_others_internal_comments")
end
def down
@@ -48,7 +50,9 @@ class RenameCommentPermissions < ActiveRecord::Migration[8.0]
::Migration::MigrationUtils::PermissionRenamer.rename("view_internal_comments", "view_comments_with_restricted_visibility")
::Migration::MigrationUtils::PermissionRenamer.rename("add_internal_comments", "add_comments_with_restricted_visibility")
- ::Migration::MigrationUtils::PermissionRenamer.rename("edit_own_internal_comments", "edit_own_comments_with_restricted_visibility")
- ::Migration::MigrationUtils::PermissionRenamer.rename("edit_others_internal_comments", "edit_others_comments_with_restricted_visibility")
+ ::Migration::MigrationUtils::PermissionRenamer.rename("edit_own_internal_comments",
+ "edit_own_comments_with_restricted_visibility")
+ ::Migration::MigrationUtils::PermissionRenamer.rename("edit_others_internal_comments",
+ "edit_others_comments_with_restricted_visibility")
end
end
diff --git a/db/migrate/migration_utils/permission_renamer.rb b/db/migrate/migration_utils/permission_renamer.rb
index a3a202f9060..39642d2f1ee 100644
--- a/db/migrate/migration_utils/permission_renamer.rb
+++ b/db/migrate/migration_utils/permission_renamer.rb
@@ -46,8 +46,8 @@ module Migration
@role_permissions_table ||= ActiveRecord::Base.connection.quote_table_name("role_permissions")
end
- def quote_value(s)
- ActiveRecord::Base.connection.quote(s)
+ def quote_value(value)
+ ActiveRecord::Base.connection.quote(value)
end
end
end