Skip to content

OpenRAG is a comprehensive, single package Retrieval-Augmented Generation platform built on Langflow, Docling, and Opensearch.

Python

Update agent.py

Edwin Jose1fe9d74b1787
diff --git a/src/agent.py b/src/agent.py
index 172bf23df..a59fe84f6 100644
--- a/src/agent.py
+++ b/src/agent.py
@@ -815,31 +815,36 @@ async def async_langflow_chat_stream(
async def delete_user_conversation(user_id: str, response_id: str) -> bool:
- """Delete a conversation for a user from both memory and persistent storage (async, non-blocking)"""
+ """Delete a conversation for a user from both memory and persistent storage.
+
+ Returns:
+ True — conversation was found and deleted from at least one store.
+ False — conversation did not exist in any store (confirmed not-found).
+
+ Raises:
+ Exception — on unexpected storage errors so callers can distinguish
+ a confirmed "not found" from a backend failure.
+ """
deleted = False
- try:
- # Delete from in-memory storage
- if user_id in active_conversations and response_id in active_conversations[user_id]:
- del active_conversations[user_id][response_id]
- logger.debug(f"Deleted conversation {response_id} from memory for user {user_id}")
- deleted = True
-
- # Delete from persistent storage
- conversation_deleted = await conversation_persistence.delete_conversation_thread(user_id, response_id)
- if conversation_deleted:
- logger.debug(f"Deleted conversation {response_id} from persistent storage for user {user_id}")
- deleted = True
-
- # Release session ownership
- try:
- from services.session_ownership_service import session_ownership_service
- session_ownership_service.release_session(user_id, response_id)
- logger.debug(f"Released session ownership for {response_id} for user {user_id}")
- except Exception as e:
- logger.warning(f"Failed to release session ownership: {e}")
+ # Delete from in-memory storage (cannot raise)
+ if user_id in active_conversations and response_id in active_conversations[user_id]:
+ del active_conversations[user_id][response_id]
+ logger.debug(f"Deleted conversation {response_id} from memory for user {user_id}")
+ deleted = True
+
+ # Delete from persistent storage — let real errors propagate to the caller
+ conversation_deleted = await conversation_persistence.delete_conversation_thread(user_id, response_id)
+ if conversation_deleted:
+ logger.debug(f"Deleted conversation {response_id} from persistent storage for user {user_id}")
+ deleted = True
- return deleted
+ # Release session ownership (best-effort; never masks storage errors above)
+ try:
+ from services.session_ownership_service import session_ownership_service
+ session_ownership_service.release_session(user_id, response_id)
+ logger.debug(f"Released session ownership for {response_id} for user {user_id}")
except Exception as e:
- logger.error(f"Error deleting conversation {response_id} for user {user_id}: {e}")
- return False
+ logger.warning(f"Failed to release session ownership: {e}")
+
+ return deleted