Skip to content

OpenRAG is a comprehensive, single package Retrieval-Augmented Generation platform built on Langflow, Docling, and Opensearch.

Python

Handle missing chat deletion and 404 response

Edwin Jose2440b73a52c1
diff --git a/sdks/python/openrag_sdk/chat.py b/sdks/python/openrag_sdk/chat.py
index ef33bc243..749ca54ae 100644
--- a/sdks/python/openrag_sdk/chat.py
+++ b/sdks/python/openrag_sdk/chat.py
@@ -490,11 +490,16 @@ class ChatClient:
chat_id: The ID of the conversation to delete.
Returns:
- True if deletion was successful.
+ True if deletion was successful, False if the conversation was not found.
"""
- response = await self._client._request("DELETE", f"/api/v1/chat/{chat_id}")
- data = response.json()
- return data.get("success", False)
+ from .exceptions import NotFoundError
+
+ try:
+ response = await self._client._request("DELETE", f"/api/v1/chat/{chat_id}")
+ data = response.json()
+ return data.get("success", False)
+ except NotFoundError:
+ return False
# Import Literal for type hints
diff --git a/src/api/v1/chat.py b/src/api/v1/chat.py
index b87507afe..1a27804cd 100644
--- a/src/api/v1/chat.py
+++ b/src/api/v1/chat.py
@@ -226,6 +226,8 @@ async def chat_delete_endpoint(
"""Delete a conversation. DELETE /v1/chat/{chat_id}"""
try:
result = await chat_service.delete_session(user.user_id, chat_id)
+ if result.get("not_found"):
+ return JSONResponse({"error": "Conversation not found"}, status_code=404)
if result.get("success"):
return JSONResponse({"success": True})
else:
diff --git a/src/services/chat_service.py b/src/services/chat_service.py
index d0451918a..7c5fb5302 100644
--- a/src/services/chat_service.py
+++ b/src/services/chat_service.py
@@ -607,20 +607,21 @@ class ChatService:
from agent import delete_user_conversation
local_deleted = await delete_user_conversation(user_id, session_id)
- # Delete from Langflow using the monitor API
- langflow_deleted = await self._delete_langflow_session(session_id)
-
- success = local_deleted or langflow_deleted
- error_msg = None
+ if not local_deleted:
+ return {
+ "success": False,
+ "not_found": True,
+ "error": "Conversation not found",
+ }
- if not success:
- error_msg = "Session not found in local storage or Langflow"
+ # Delete from Langflow using the monitor API (best-effort)
+ langflow_deleted = await self._delete_langflow_session(session_id)
return {
- "success": success,
+ "success": True,
"local_deleted": local_deleted,
"langflow_deleted": langflow_deleted,
- "error": error_msg
+ "error": None,
}
except Exception as e: