Skip to content

OpenRAG is a comprehensive, single package Retrieval-Augmented Generation platform built on Langflow, Docling, and Opensearch.

Python

refactor(knowledge-dropdown): dedupe duplicate count, centralize dialog reset

Olfa Maslah6aff5499c2d8
diff --git a/frontend/components/knowledge-dropdown.tsx b/frontend/components/knowledge-dropdown.tsx
index bf72c7408..4f98f02d4 100644
--- a/frontend/components/knowledge-dropdown.tsx
+++ b/frontend/components/knowledge-dropdown.tsx
@@ -131,9 +131,6 @@ export function KnowledgeDropdown() {
const [s3Configured, setS3Configured] = useState(false);
const [pendingFile, setPendingFile] = useState<File | null>(null);
const [duplicateFilename, setDuplicateFilename] = useState<string>("");
- const [duplicateCountForDialog, setDuplicateCountForDialog] = useState<
- number | undefined
- >(undefined);
const [pendingFolderUpload, setPendingFolderUpload] = useState<{
allFiles: File[];
nonDuplicateFiles: File[];
@@ -152,6 +149,12 @@ export function KnowledgeDropdown() {
const fileInputRef = useRef<HTMLInputElement>(null);
const folderInputRef = useRef<HTMLInputElement>(null);
+ const resetDuplicateDialogState = () => {
+ setPendingFolderUpload(null);
+ setPendingFile(null);
+ setDuplicateFilename("");
+ };
+
// Check AWS availability and cloud connectors on mount
useEffect(() => {
const checkAvailability = async () => {
@@ -294,9 +297,9 @@ export function KnowledgeDropdown() {
if (exists) {
console.log("[Duplicate Check] Duplicate detected, showing dialog");
+ resetDuplicateDialogState();
setPendingFile(file);
setDuplicateFilename(file.name);
- setDuplicateCountForDialog(undefined);
setShowDuplicateDialog(true);
resetFileInput();
return;
@@ -357,9 +360,6 @@ export function KnowledgeDropdown() {
try {
const result = await uploadFiles(batch, replace);
addTask(result.taskId);
- console.log(
- `[Folder Upload] Batch uploaded: taskId=${result.taskId}, files=${result.fileCount}`,
- );
} catch (error) {
console.error("[Folder Upload] Batch upload failed:", error);
toast.error("Batch upload failed", {
@@ -382,9 +382,7 @@ export function KnowledgeDropdown() {
toast.success(
`Processed ${allFiles.length} file(s), including ${duplicateCount} overwrite(s)${unsupportedMessage}`,
);
- setPendingFolderUpload(null);
- setDuplicateFilename("");
- setDuplicateCountForDialog(undefined);
+ resetDuplicateDialogState();
return;
}
@@ -400,9 +398,7 @@ export function KnowledgeDropdown() {
await uploadFile(pendingFile, true);
- setPendingFile(null);
- setDuplicateFilename("");
- setDuplicateCountForDialog(undefined);
+ resetDuplicateDialogState();
}
};
@@ -434,9 +430,7 @@ export function KnowledgeDropdown() {
}
}
- setPendingFolderUpload(null);
- setDuplicateFilename("");
- setDuplicateCountForDialog(undefined);
+ resetDuplicateDialogState();
}
setShowDuplicateDialog(open);
@@ -518,14 +512,13 @@ export function KnowledgeDropdown() {
console.log(
`[Folder Upload] Found ${duplicateCount} duplicate file(s), showing overwrite dialog`,
);
+ resetDuplicateDialogState();
setPendingFolderUpload({
allFiles: cleanFiles,
nonDuplicateFiles,
duplicateCount,
unsupportedCount,
});
- setDuplicateFilename("");
- setDuplicateCountForDialog(duplicateCount);
setShowDuplicateDialog(true);
return;
}
@@ -783,7 +776,7 @@ export function KnowledgeDropdown() {
onOverwrite={handleOverwriteFile}
isLoading={fileUploading || folderLoading}
duplicateLabel={duplicateFilename}
- duplicateCount={duplicateCountForDialog}
+ duplicateCount={pendingFolderUpload?.duplicateCount}
/>
</>
);