Skip to content

OpenRAG is a comprehensive, single package Retrieval-Augmented Generation platform built on Langflow, Docling, and Opensearch.

Python

fix: get all file info at the same time displayed in the table (#1576)

Wallgau8de6da93fe0c
diff --git a/frontend/app/api/mutations/useDeleteDocument.ts b/frontend/app/api/mutations/useDeleteDocument.ts
index 47b852b12..f4fd9ce41 100644
--- a/frontend/app/api/mutations/useDeleteDocument.ts
+++ b/frontend/app/api/mutations/useDeleteDocument.ts
@@ -41,6 +41,7 @@ export const useDeleteDocument = () => {
// Invalidate and refetch search queries to update the UI
setTimeout(() => {
queryClient.invalidateQueries({ queryKey: ["search"] });
+ queryClient.invalidateQueries({ queryKey: ["listFiles"] });
}, 1000);
},
});
diff --git a/frontend/app/knowledge/page.tsx b/frontend/app/knowledge/page.tsx
index 6fa0a7eed..a5f0a4efc 100644
--- a/frontend/app/knowledge/page.tsx
+++ b/frontend/app/knowledge/page.tsx
@@ -53,13 +53,21 @@ import {
import AwsLogo from "../../components/icons/aws-logo";
import GoogleDriveIcon from "../../components/icons/google-drive-logo";
import IBMCOSIcon from "../../components/icons/ibm-cos-icon";
-import IBMLogo from "../../components/icons/ibm-logo";
import OneDriveIcon from "../../components/icons/one-drive-logo";
import SharePointIcon from "../../components/icons/share-point-logo";
import { useDeleteDocument } from "../api/mutations/useDeleteDocument";
import { useRefreshOpenragDocs } from "../api/mutations/useRefreshOpenragDocs";
import { useSyncAllConnectors } from "../api/mutations/useSyncConnector";
+/** List-files uses term filters; "*" means "any" in the UI — do not send it literally. */
+function listFilesFilterParam(values?: string[]): string | undefined {
+ const raw = values?.[0]?.trim();
+ if (!raw || raw === "*") {
+ return undefined;
+ }
+ return raw;
+}
+
// Function to get the appropriate icon for a connector type
function getSourceIcon(connectorType?: string) {
switch (connectorType) {
@@ -101,7 +109,8 @@ function SearchPage() {
setRecentTasksExpanded,
selectTask,
} = useTask();
- const { parsedFilterData, queryOverride } = useKnowledgeFilter();
+ const { parsedFilterData, queryOverride, selectedFilter } =
+ useKnowledgeFilter();
const [selectedRows, setSelectedRows] = useState<File[]>([]);
const [showBulkDeleteDialog, setShowBulkDeleteDialog] = useState(false);
const lastErrorRef = useRef<string | null>(null);
@@ -210,12 +219,12 @@ function SearchPage() {
getFailedFileKey,
]);
- // Use server-side file listing for default/wildcard view,
- // fall back to search-based aggregation for semantic queries
+ // Use server-side file listing for default/wildcard view; search otherwise.
+ // Wildcard follows bar text or saved filter query (bar is cleared when a filter is picked).
+ const effectiveSearchText =
+ queryOverride.trim() || parsedFilterData?.query?.trim() || "";
const isWildcardQuery =
- !queryOverride ||
- queryOverride.trim() === "" ||
- queryOverride.trim() === "*";
+ effectiveSearchText === "" || effectiveSearchText === "*";
const {
data: listFilesData,
@@ -226,9 +235,11 @@ function SearchPage() {
{
pageSize: 100,
search: isWildcardQuery ? undefined : queryOverride,
- connectorType: parsedFilterData?.filters?.connector_types?.[0],
- mimetype: parsedFilterData?.filters?.document_types?.[0],
- owner: parsedFilterData?.filters?.owners?.[0],
+ connectorType: listFilesFilterParam(
+ parsedFilterData?.filters?.connector_types,
+ ),
+ mimetype: listFilesFilterParam(parsedFilterData?.filters?.document_types),
+ owner: listFilesFilterParam(parsedFilterData?.filters?.owners),
},
{
refetchInterval: 5000,
@@ -242,9 +253,9 @@ function SearchPage() {
error: searchError,
isError: isSearchError,
} = useGetSearchQuery(queryOverride, parsedFilterData, {
- refetchInterval: 5000,
enabled: !isWildcardQuery,
});
+
const { files: searchFiles, warnings: searchWarnings } =
searchData as SearchResult;
@@ -347,10 +358,11 @@ function SearchPage() {
lastErrorRef.current = null;
}
}, [isError, error]);
+ // Third arg: saved filter only — draft `parsedFilterData` (create mode) must still show task rows.
const fileResults = buildKnowledgeTableRows(
effectiveData,
taskFiles,
- !!parsedFilterData,
+ Boolean(selectedFilter),
);
const gridRows = fileResults;
@@ -830,7 +842,7 @@ function SearchPage() {
</div>
</div>
)}
- {searchWarnings.length > 0 && (
+ {!isWildcardQuery && searchWarnings.length > 0 && (
<div className="mb-4 flex flex-col gap-2">
{searchWarnings.map((warning, idx) => {
const isEmbeddingWarning =
diff --git a/frontend/contexts/task-context.tsx b/frontend/contexts/task-context.tsx
index d4cde01b4..a1e0cdb67 100644
--- a/frontend/contexts/task-context.tsx
+++ b/frontend/contexts/task-context.tsx
@@ -141,6 +141,10 @@ export function TaskProvider({ children }: { children: React.ReactNode }) {
queryKey: ["search"],
exact: false,
});
+ queryClient.invalidateQueries({
+ queryKey: ["listFiles"],
+ exact: false,
+ });
}, [queryClient]);
const addFiles = useCallback(
@@ -326,7 +330,7 @@ export function TaskProvider({ children }: { children: React.ReactNode }) {
});
return changed ? updated : prevFiles;
});
- setTimeout(() => refetchSearch(), 500);
+ refetchSearch();
}
}
if (
@@ -378,19 +382,35 @@ export function TaskProvider({ children }: { children: React.ReactNode }) {
const completedHasFailures = hasFailedFileEntries(currentTask);
- setTimeout(() => {
- // Remove overlay rows for this completed task so backend becomes
- // source of truth. For partial-success completions, keep failed
- // rows visible in the table.
- setFiles((prevFiles) =>
- prevFiles.filter(
- (file) =>
- file.task_id !== currentTask.task_id ||
- (completedHasFailures && file.status === "failed"),
- ),
- );
- refetchSearch();
- }, 500);
+ async function refetchKnowledgeAfterTaskCompletion() {
+ // Refetch before dropping overlays (wildcard uses listFiles, not only search).
+ try {
+ await Promise.all([
+ queryClient.refetchQueries({
+ queryKey: ["search"],
+ exact: false,
+ }),
+ queryClient.refetchQueries({
+ queryKey: ["listFiles"],
+ exact: false,
+ }),
+ ]);
+ } catch (e) {
+ console.error(
+ "Knowledge refetch after task completion failed",
+ e,
+ );
+ } finally {
+ setFiles((prevFiles) =>
+ prevFiles.filter(
+ (file) =>
+ file.task_id !== currentTask.task_id ||
+ (completedHasFailures && file.status === "failed"),
+ ),
+ );
+ }
+ }
+ void refetchKnowledgeAfterTaskCompletion();
} else if (
shouldShowToast &&
previousTask &&
diff --git a/frontend/lib/knowledge-table-state.ts b/frontend/lib/knowledge-table-state.ts
index 74d374217..82466f417 100644
--- a/frontend/lib/knowledge-table-state.ts
+++ b/frontend/lib/knowledge-table-state.ts
@@ -63,11 +63,25 @@ export function buildKnowledgeTableRows(
const taskFile = taskFileMap.get(getKnowledgeFileIdentity(file));
if (taskFile) {
const backendStatus = file.status ?? "active";
- return { ...file, ...taskFile, status: backendStatus };
+ return {
+ ...file,
+ filename: taskFile.filename,
+ source_url: taskFile.source_url,
+ connector_type: taskFile.connector_type,
+ status: backendStatus,
+ error: taskFile.error,
+ embedding_model: taskFile.embedding_model ?? file.embedding_model,
+ embedding_dimensions:
+ taskFile.embedding_dimensions ?? file.embedding_dimensions,
+ };
}
return file;
});
+ const backendIdentities = new Set(
+ backendFiles.map((f) => getKnowledgeFileIdentity(f)),
+ );
+
const filteredTaskFiles = taskFilesAsFiles.filter((taskFile) => {
if (
taskFile.filename === "OpenRAG docs refresh" ||
@@ -78,14 +92,12 @@ export function buildKnowledgeTableRows(
if (taskFile.connector_type === "openrag_docs") {
return false;
}
- return (
- taskFile.status !== "active" &&
- !backendFiles.some(
- (backendFile) =>
- getKnowledgeFileIdentity(backendFile) ===
- getKnowledgeFileIdentity(taskFile),
- )
- );
+ const identity = getKnowledgeFileIdentity(taskFile);
+ if (backendIdentities.has(identity)) {
+ return false;
+ }
+ // Keep "active" overlays until the index lists the file (task drops key before refetch).
+ return true;
});
if (hasActiveFilter) {